You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by eatoncys <gi...@git.apache.org> on 2017/05/22 09:29:41 UTC

[GitHub] spark pull request #18060: [SPARK-20835][Core]It should exit directly when t...

GitHub user eatoncys opened a pull request:

    https://github.com/apache/spark/pull/18060

    [SPARK-20835][Core]It should exit directly when the --total-executor-cores parameter is setted less than 0 when submit a application

    ## What changes were proposed in this pull request?
    In my test, the submitted app running with out an error when the --total-executor-cores less than 0
    and given the warnings:
    "2017-05-22 17:19:36,319 WARN org.apache.spark.scheduler.TaskSchedulerImpl: Initial job has not accepted any resources; check your cluster UI to ensure that workers are registered and have sufficient resources";
    
    It should exit directly when the --total-executor-cores parameter is setted less than 0 when submit a application
    (Please fill in changes proposed in this fix)
    
    ## How was this patch tested?
    Run the ut tests
    (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
    (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eatoncys/spark totalcores

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18060.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18060
    
----
commit 714648baf96732d7e5d28fc92df6cfd1daf05815
Author: 10129659 <ch...@zte.com.cn>
Date:   2017-05-22T09:02:28Z

    Exit if total cores less then 0

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18060
  
    **[Test build #3757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3757/testReport)** for PR 18060 at commit [`eae0f3d`](https://github.com/apache/spark/commit/eae0f3d4a22911156b1bf47dd6df0cd0ed31dc28).
     * This patch **fails Scala style tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

Posted by eatoncys <gi...@git.apache.org>.

Github user eatoncys commented on the issue:

    https://github.com/apache/spark/pull/18060
  
    @srowen The other parameters are validated at some other places, for example, the --executor-memory parameter is validated at org.apache.spark.memory.UnifiedMemoryManager$.getMaxMemory,  the app can exit with error: "java.lang.NumberFormatException" if it is a negative number. But the --total-executor-cores parameter is not validated at anywhere, the app can not exit  if it is a negative number.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18060
  
    **[Test build #3750 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3750/testReport)** for PR 18060 at commit [`4c4bfbb`](https://github.com/apache/spark/commit/4c4bfbb9fd2f03a8ab9747dd09aa897eea6b8463).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18060
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18060
  
    **[Test build #3750 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3750/testReport)** for PR 18060 at commit [`4c4bfbb`](https://github.com/apache/spark/commit/4c4bfbb9fd2f03a8ab9747dd09aa897eea6b8463).
     * This patch **fails Scala style tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/18060
  
    Yeah but maybe a good idea to valid all these aren't negative upfront. Fail faster and more consistently. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

Posted by eatoncys <gi...@git.apache.org>.

Github user eatoncys commented on the issue:

    https://github.com/apache/spark/pull/18060
  
    @SparkQA Retest this please,thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18060
  
    **[Test build #3760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3760/testReport)** for PR 18060 at commit [`caacdc0`](https://github.com/apache/spark/commit/caacdc04ccbc6bdfcc6ade77559c85c114c9b075).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

Posted by eatoncys <gi...@git.apache.org>.

Github user eatoncys commented on the issue:

    https://github.com/apache/spark/pull/18060
  
    @srowen Thank you for suggestion. I have validated other  numerical parameters here, any other suggestion? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/18060
  
    Merged to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org