You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Malcolm Rowe <ma...@farside.org.uk> on 2007/05/01 09:13:43 UTC
Re: [PATCH] Make DAV activity db location configurable
On Mon, Apr 30, 2007 at 10:43:32AM -0700, Eric Gillespie wrote:
> Make the location of mod_dav_svn's activity database configurable with a
> new SVNActivitiesDB configuration directive. If set, use it directly as
> the activity db for SVNPath repositories. For SVNParentPath repositories,
> use it to contain activity db directories named after the repository
> basename. If this directive is not specified, use "dav/activities.d" at
> the top of the repository.
It's a pity that we can't define the default behaviour of
SVNActivitiesDB in terms of a valid value, but I guess that's okay. Do
we need to document this new directive somewhere?
+1, looks good - you just need to update some comments to reflect the
change to create the dav directory if --pre-1.4-compatible.
One in the log message:
> * subversion/libsvn_repos/repos.c
> (create_svn_repos_t): Don't fill in dav_path.
> (create_repos_structure): Take fs_config argument and create the
> "dav" path (SVN_REPOS__DAV_DIR) only if it has the
> SVN_FS_CONFIG_PRE_1_5_COMPATIBLE setting.
And one in the comments:
> ]]]
>
> Index: subversion/libsvn_repos/repos.c
> ===================================================================
> - /* Create the DAV sandbox directory. */
> - SVN_ERR_W(create_repos_dir(repos->dav_path, pool),
> - _("Creating DAV sandbox dir"));
> + /* Create the DAV sandbox directory if pre-1.5-compatible. */
Or if pre-1.4-compatible. Or perhaps more generally, "if a repository
compatible with a version before 1.5 was requested".
> + if (fs_config
> + && (apr_hash_get(fs_config, SVN_FS_CONFIG_PRE_1_4_COMPATIBLE,
> + APR_HASH_KEY_STRING)
> + || apr_hash_get(fs_config, SVN_FS_CONFIG_PRE_1_5_COMPATIBLE,
> + APR_HASH_KEY_STRING)))
Regards,
Malcolm
Re: [PATCH] Make DAV activity db location configurable
Posted by "C. Michael Pilato" <cm...@collab.net>.
Cc:ing svnbook-dev@red-bean.com as a reminder.
Eric Gillespie wrote:
> Malcolm Rowe <ma...@farside.org.uk> writes:
>
>> On Mon, Apr 30, 2007 at 10:43:32AM -0700, Eric Gillespie wrote:
>>> Make the location of mod_dav_svn's activity database configurable with a
>>> new SVNActivitiesDB configuration directive. If set, use it directly as
>>> the activity db for SVNPath repositories. For SVNParentPath repositories,
>>> use it to contain activity db directories named after the repository
>>> basename. If this directive is not specified, use "dav/activities.d" at
>>> the top of the repository.
>> It's a pity that we can't define the default behaviour of
>> SVNActivitiesDB in terms of a valid value, but I guess that's okay. Do
>> we need to document this new directive somewhere?
>
> I used r22606 ("Merge in dav-mirror branch into trunk.") as my
> guiding example, so i wouldn't miss anything. It doesn't update
> any documentation. As far as i know, svnbook is all we have.
>
>> +1, looks good - you just need to update some comments to reflect the
>> change to create the dav directory if --pre-1.4-compatible.
>
> Fixed and committed (r24873), thanks.
>
> --
> Eric Gillespie <*> epg@pretzelnet.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: [PATCH] Make DAV activity db location configurable
Posted by Eric Gillespie <ep...@pretzelnet.org>.
Malcolm Rowe <ma...@farside.org.uk> writes:
> On Mon, Apr 30, 2007 at 10:43:32AM -0700, Eric Gillespie wrote:
> > Make the location of mod_dav_svn's activity database configurable with a
> > new SVNActivitiesDB configuration directive. If set, use it directly as
> > the activity db for SVNPath repositories. For SVNParentPath repositories,
> > use it to contain activity db directories named after the repository
> > basename. If this directive is not specified, use "dav/activities.d" at
> > the top of the repository.
>
> It's a pity that we can't define the default behaviour of
> SVNActivitiesDB in terms of a valid value, but I guess that's okay. Do
> we need to document this new directive somewhere?
I used r22606 ("Merge in dav-mirror branch into trunk.") as my
guiding example, so i wouldn't miss anything. It doesn't update
any documentation. As far as i know, svnbook is all we have.
> +1, looks good - you just need to update some comments to reflect the
> change to create the dav directory if --pre-1.4-compatible.
Fixed and committed (r24873), thanks.
--
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org