You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2025/08/14 10:25:25 UTC
[Impala-ASF-CR] IMPALA-14140: Adds built-in function prettyprint quantity
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23296
Change subject: IMPALA-14140: Adds built-in function prettyprint_quantity
......................................................................
IMPALA-14140: Adds built-in function prettyprint_quantity
This patch adds prettyprint_quantity function to support converting
numeric values into a human-readable format.
Utility functions in pretty-print.h are also updated to handle
negative values and support numeric output formatting.
Documentation is added to the built-in string functions documentation.
Testing:
- Adds unit tests for prettyprint_quantity function.
- Adds benchmark tests for prettyprint_quantity and update
related string function performance data.
- Adds an e2e test to exercise this new function.
Change-Id: I4b85ffb0b16a5bbac69faabf22e05ffb02c2628a
---
M be/src/benchmarks/expr-benchmark.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M be/src/exprs/string-functions.h
M be/src/util/pretty-printer.h
M common/function-registry/impala_functions.py
M docs/topics/impala_functions.xml
M docs/topics/impala_string_functions.xml
A testdata/workloads/functional-query/queries/QueryTest/prettyprint-quantity.test
A tests/query_test/test_prettyprint_quantity.py
10 files changed, 332 insertions(+), 59 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/23296/1
--
To view, visit http://gerrit.cloudera.org:8080/23296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b85ffb0b16a5bbac69faabf22e05ffb02c2628a
Gerrit-Change-Number: 23296
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-14140: Adds built-in function prettyprint quantity
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23296 )
Change subject: IMPALA-14140: Adds built-in function prettyprint_quantity
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12328/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b85ffb0b16a5bbac69faabf22e05ffb02c2628a
Gerrit-Change-Number: 23296
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Aug 2025 09:52:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14140: Adds built-in function prettyprint quantity
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23296 )
Change subject: IMPALA-14140: Adds built-in function prettyprint_quantity
......................................................................
Patch Set 2:
> Patch Set 2:
>
> Hi Yifan, please let me know if this is ready for review.
Yes, it's ready for review.
--
To view, visit http://gerrit.cloudera.org:8080/23296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b85ffb0b16a5bbac69faabf22e05ffb02c2628a
Gerrit-Change-Number: 23296
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 12 Nov 2025 11:42:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14140: Adds built-in function prettyprint quantity
Posted by "Pranav Lodha (Code Review)" <ge...@cloudera.org>.
Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23296 )
Change subject: IMPALA-14140: Adds built-in function prettyprint_quantity
......................................................................
Patch Set 2:
Hi Yifan, please let me know if this is ready for review.
--
To view, visit http://gerrit.cloudera.org:8080/23296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b85ffb0b16a5bbac69faabf22e05ffb02c2628a
Gerrit-Change-Number: 23296
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 20:19:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14140: Adds built-in function prettyprint quantity
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23296 )
Change subject: IMPALA-14140: Adds built-in function prettyprint_quantity
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12328/
--
To view, visit http://gerrit.cloudera.org:8080/23296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b85ffb0b16a5bbac69faabf22e05ffb02c2628a
Gerrit-Change-Number: 23296
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Aug 2025 15:10:48 +0000
Gerrit-HasComments: No