You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/11/25 10:00:37 UTC
[GitHub] [netbeans-tools] neilcsmith-net opened a new pull request, #57: NBPackage RPM fixes and options tidy up towards first release
neilcsmith-net opened a new pull request, #57:
URL: https://github.com/apache/netbeans-tools/pull/57
Tidy up of options and move to global options where appropriate (publisher, URL, etc.) Allow missing out `package.` prefix when passing option on command line.
Various fixes for RPM issues including missing options breaking build, noarch build including binaries, file layout mismatch with `/usr/lib64` and `rpm --eval` call failing to report arch.
cc/ @javierllorente can you have a look at some of the RPM updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net merged pull request #57: NBPackage RPM fixes and options tidy up towards first release
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged PR #57:
URL: https://github.com/apache/netbeans-tools/pull/57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net commented on pull request #57: NBPackage RPM fixes and options tidy up towards first release
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #57:
URL: https://github.com/apache/netbeans-tools/pull/57#issuecomment-1328040112
> One question: why are you using hard-coded paths instead of rpm macros? ie: /usr/bin vs %{_bindir}
Because I had a problem with `rpmbuild` resolving `%{_libdir}` to be `/usr/lib64` and then complaining about missing files. The image and the `/bin/netbeans` file are currently built to expect `/usr/lib`. This is mentioned in the to-do at https://github.com/apache/netbeans-tools/blob/master/nbpackage/src/main/java/org/apache/netbeans/nbpackage/rpm/RpmTask.java#L68
While `%{_bindir}` is probably OK, it made sense to hard-code all the paths set in the image for now, unless I'm missing something obvious?
Removing the wildcard on `/usr/lib/` also seems to be needed to ensure the `/usr/lib/apache-netbeans` directory is deleted on uninstall.
I couldn't get either the noarch (without JDK) or x86_64 (with JDK) packaging to work on my setup. They both work for you before? And with these changes?
> I also have a suggestion for a future version: signing rpms.
Sounds like it could be a good addition. The macOS packager is the only one with built in signing, including signing of binaries inside JARs, currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net commented on pull request #57: NBPackage RPM fixes and options tidy up towards first release
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #57:
URL: https://github.com/apache/netbeans-tools/pull/57#issuecomment-1328104349
> Having `BuildArch: noarch` should make `%{_libdir}` resolve to `/usr/lib/` ...
> I have only tested the rpm without JDK
That explains it then. Adding the JDK changes the arch to eg. x86_64 (now the --eval call is fixed). This then changes the libdir value. Need to consider option to change the image layout in future.
I needed the define to not terminate on binaries in the spec file to get build without JDK to work.
Thanks for confirming this doesn't break things on your end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on pull request #57: NBPackage RPM fixes and options tidy up towards first release
Posted by GitBox <gi...@apache.org>.
javierllorente commented on PR #57:
URL: https://github.com/apache/netbeans-tools/pull/57#issuecomment-1327932784
Nice job cleaning :)
One question: why are you using hard-coded paths instead of rpm macros? ie: /usr/bin vs %{_bindir}
I also have a suggestion for a future version: signing rpms.
```
apache-netbeans-16-0.noarch.rpm:
Package header is not signed!
apache-netbeans-16-0.noarch (Plain RPM files cache): Signature verification failed [6-File is unsigned]
Abort, retry, ignore? [a/r/i] (a):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on pull request #57: NBPackage RPM fixes and options tidy up towards first release
Posted by GitBox <gi...@apache.org>.
javierllorente commented on PR #57:
URL: https://github.com/apache/netbeans-tools/pull/57#issuecomment-1328093167
> Because I had a problem with rpmbuild resolving %{_libdir} to be /usr/lib64 and then complaining about missing files. The image and the /bin/netbeans file are currently built to expect /usr/lib. This is mentioned in the to-do at https://github.com/apache/netbeans-tools/blob/master/nbpackage/src/main/java/org/apache/netbeans/nbpackage/rpm/RpmTask.java#L68
Having `BuildArch: noarch` should make `%{_libdir}` resolve to `/usr/lib/`. I had no problems with this. Same with `%{_bindir}`
> Removing the wildcard on /usr/lib/ also seems to be needed to ensure the /usr/lib/apache-netbeans directory is deleted on uninstall.
I have just seen that there was a leftover after uninstalling it. Thanks for fixing it.
>I couldn't get either the noarch (without JDK) or x86_64 (with JDK) packaging to work on my setup. They both work for you before? And with these changes?
I have only tested the rpm without JDK. I had no issues with packaging before (and after your changes). I am not using any fancy options;
`nbpackage-1.0-beta1-SNAPSHOT/bin/nbpackage --verbose --type linux-rpm --input /home/javier/Descargas/netbeans-16-rc4-bin.zip -Ppackage.name="Apache NetBeans" -Ppackage.version=16 -Ppackage.rpm.maintainer="My name <my...@somewhere.com>"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists