You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by ma...@apache.org on 2017/12/15 05:59:12 UTC

[trafficserver] branch quic-latest updated: MAX_DATA is now in units of octets

This is an automated email from the ASF dual-hosted git repository.

maskit pushed a commit to branch quic-latest
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/quic-latest by this push:
     new 937019a  MAX_DATA is now in units of octets
937019a is described below

commit 937019af98332ee9f4dd978fde62e837c1035d07
Author: Masakazu Kitajo <ma...@apache.org>
AuthorDate: Fri Dec 15 14:57:40 2017 +0900

    MAX_DATA is now in units of octets
---
 iocore/net/QUICNetVConnection.cc      | 2 +-
 iocore/net/quic/QUICConfig.h          | 2 +-
 iocore/net/quic/QUICFlowController.cc | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/iocore/net/QUICNetVConnection.cc b/iocore/net/QUICNetVConnection.cc
index 83c5a9e..587ba71 100644
--- a/iocore/net/QUICNetVConnection.cc
+++ b/iocore/net/QUICNetVConnection.cc
@@ -325,7 +325,7 @@ QUICNetVConnection::handle_frame(std::shared_ptr<const QUICFrame> frame)
 
   switch (frame->type()) {
   case QUICFrameType::MAX_DATA:
-    this->_remote_flow_controller->forward_limit(std::static_pointer_cast<const QUICMaxDataFrame>(frame)->maximum_data() * 1024);
+    this->_remote_flow_controller->forward_limit(std::static_pointer_cast<const QUICMaxDataFrame>(frame)->maximum_data());
     Debug("quic_flow_ctrl", "Connection [%" PRIx64 "] [REMOTE] %" PRIu64 "/%" PRIu64,
           static_cast<uint64_t>(this->_quic_connection_id), this->_remote_flow_controller->current_offset(),
           this->_remote_flow_controller->current_limit());
diff --git a/iocore/net/quic/QUICConfig.h b/iocore/net/quic/QUICConfig.h
index 6f427c1..c6adba4 100644
--- a/iocore/net/quic/QUICConfig.h
+++ b/iocore/net/quic/QUICConfig.h
@@ -40,7 +40,7 @@ public:
 private:
   // FIXME Fill appropriate values
   uint32_t _no_activity_timeout_in     = 0;
-  uint32_t _initial_max_data           = 100; // in units of 1024 octets
+  uint32_t _initial_max_data           = 131072;
   uint32_t _initial_max_stream_data    = 2048;
   uint32_t _initial_max_stream_id_bidi = 100;
   uint32_t _initial_max_stream_id_uni  = 102;
diff --git a/iocore/net/quic/QUICFlowController.cc b/iocore/net/quic/QUICFlowController.cc
index a468561..66f9de9 100644
--- a/iocore/net/quic/QUICFlowController.cc
+++ b/iocore/net/quic/QUICFlowController.cc
@@ -126,7 +126,7 @@ QUICRemoteConnectionFlowController::_create_frame()
 QUICFrameUPtr
 QUICLocalConnectionFlowController::_create_frame()
 {
-  return QUICFrameFactory::create_max_data_frame(this->_limit / 1024);
+  return QUICFrameFactory::create_max_data_frame(this->_limit);
 }
 
 QUICFrameUPtr

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].