You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2018/05/05 14:10:36 UTC

Re: Review Request 66628: Added role tracking unit tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66628/
-----------------------------------------------------------

(Updated May 5, 2018, 2:10 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, Michael Park, and Meng Zhu.


Changes
-------

rebased


Bugs: MESOS-8069
    https://issues.apache.org/jira/browse/MESOS-8069


Repository: mesos


Description
-------

Added role tracking unit tests.


Diffs (updated)
-----

  src/Makefile.am 7e91681e3b8b217f8b23fa5347e059640c62fc65 
  src/tests/role_tracking_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/66628/diff/2/

Changes: https://reviews.apache.org/r/66628/diff/1-2/


Testing
-------

make check


Thanks,

Till Toenshoff


Re: Review Request 66628: Added role tracking unit tests.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66628/#review202523
-----------------------------------------------------------



Patch looks great!

Reviews applied: [65939, 66625, 66973, 65940, 66628]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 5, 2018, 7:10 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66628/
> -----------------------------------------------------------
> 
> (Updated May 5, 2018, 7:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, Michael Park, and Meng Zhu.
> 
> 
> Bugs: MESOS-8069
>     https://issues.apache.org/jira/browse/MESOS-8069
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added role tracking unit tests.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7e91681e3b8b217f8b23fa5347e059640c62fc65 
>   src/tests/role_tracking_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66628/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 66628: Added role tracking unit tests.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66628/#review202522
-----------------------------------------------------------



PASS: Mesos patch 66628 was successfully built and tested.

Reviews applied: `['65939', '66625', '66973', '65940', '66628']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66628

- Mesos Reviewbot Windows


On May 5, 2018, 7:10 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66628/
> -----------------------------------------------------------
> 
> (Updated May 5, 2018, 7:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, Michael Park, and Meng Zhu.
> 
> 
> Bugs: MESOS-8069
>     https://issues.apache.org/jira/browse/MESOS-8069
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added role tracking unit tests.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7e91681e3b8b217f8b23fa5347e059640c62fc65 
>   src/tests/role_tracking_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66628/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>