[jira] [Updated] (SSHD-761) The agent forwarding channel is not closed at the end of the session

["Li Fangning (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SSHD-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Li Fangning updated SSHD-761:
-----------------------------
    Description: 
Use the Putty client to connect to SSHD and enable Agent Forwarding.
When the session is closed (with the "exit" command), the putty client does not exit properly because the agent forwarding channel is still open.

I modified the SSH source code to fix this issue:
org.apache.sshd.agent.local.ChannelAgentForwarding
{code:java}
......
    // Overwice handleEof in AbstractChannel
    @Override
    public void handleEof() throws IOException {
        // Close agent forwarding channel
        if (agent != null) {
            agent.close();
        }

        super.handleEof();
    }
}
{code}

However, it works

Please help me confirm whether this change is OK.
Thanks

  was:
Use the Putty client to connect to SSHD and enable Agent Forwarding.
When the session is closed (with the "exit" command), the putty client does not exit properly because the agent forwarding channel is still open.

I modified the SSH source code to fix this issue:
org.apache.sshd.agent.local.ChannelAgentForwarding
{code:java}
......
    private void closeImmediately0() {
        // Close the agent forwarding channel
        if (agent != null) {
            try {
                agent.close();
            } catch (IOException e) {
                super.log.warn("Failed to close the SshAgent", e);
            }
        }
        ......
{code}

However, it works

Please help me confirm whether this change is OK.
Thanks


> The agent forwarding channel is not closed at the end of the session
> --------------------------------------------------------------------
>
>                 Key: SSHD-761
>                 URL: https://issues.apache.org/jira/browse/SSHD-761
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 1.6.0
>            Reporter: Li Fangning
>
> Use the Putty client to connect to SSHD and enable Agent Forwarding.
> When the session is closed (with the "exit" command), the putty client does not exit properly because the agent forwarding channel is still open.
> I modified the SSH source code to fix this issue:
> org.apache.sshd.agent.local.ChannelAgentForwarding
> {code:java}
> ......
>     // Overwice handleEof in AbstractChannel
>     @Override
>     public void handleEof() throws IOException {
>         // Close agent forwarding channel
>         if (agent != null) {
>             agent.close();
>         }
>         super.handleEof();
>     }
> }
> {code}
> However, it works
> Please help me confirm whether this change is OK.
> Thanks



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)