You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/02/01 16:44:00 UTC

[jira] [Commented] (OFBIZ-11385) Possible NPE in DatabaseUtil.getColumnInfo(...)

    [ https://issues.apache.org/jira/browse/OFBIZ-11385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276455#comment-17276455 ] 

ASF subversion and git services commented on OFBIZ-11385:
---------------------------------------------------------

Commit c7f4a27f662015e2e96b68ef0697196c0565f4e0 in ofbiz-framework's branch refs/heads/release18.12 from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c7f4a27 ]

Fixed: Possible NPE in DatabaseUtil.getColumnInfo(...) (OFBIZ-11385)

Manually backported to 18.12 because of code differences.

> Possible NPE in DatabaseUtil.getColumnInfo(...)
> -----------------------------------------------
>
>                 Key: OFBIZ-11385
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11385
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/webtools
>    Affects Versions: Trunk
>            Reporter: Benjamin Jugl
>            Assignee: Michael Brohl
>            Priority: Major
>              Labels: backport-needed
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-11385_Possible_NPE_in_DatabaseUtil_001.patch
>
>
> Right at the start DatabaseUtil.getColumnInfo(....) does an if comparison to 0 with the unchecked parameter tableNames.
> The way this method and especially the parameter is used in DatabaseUtil.induceModelFromDb(Collection<String> messages) is not secure to not provide null-values for this parameter.
> I suggest using a UtilValidate.isEmpty(...) instead of the unsave comparison.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)