You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by fp...@apache.org on 2013/05/07 21:49:19 UTC
svn commit: r1480051 - in /zookeeper/bookkeeper/trunk: CHANGES.txt
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java
Author: fpj
Date: Tue May 7 19:49:19 2013
New Revision: 1480051
URL: http://svn.apache.org/r1480051
Log:
BOOKkEEPER-577: BookieFailureTest uses sync/wait()/notify() incorrectly (ivank via fpj)
Modified:
zookeeper/bookkeeper/trunk/CHANGES.txt
zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java
Modified: zookeeper/bookkeeper/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/CHANGES.txt?rev=1480051&r1=1480050&r2=1480051&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/CHANGES.txt (original)
+++ zookeeper/bookkeeper/trunk/CHANGES.txt Tue May 7 19:49:19 2013
@@ -48,6 +48,8 @@ Trunk (unreleased changes)
BOOKKEEPER-599: NPE in PerChannelBookieClient (jiannan via sijie)
+ BOOKkEEPER-577: BookieFailureTest uses sync/wait()/notify() incorrectly (ivank via fpj)
+
hedwig-client:
BOOKKEEPER-598: Fails to compile - RESUBSCRIBE_EXCEPTION conflict (Matthew Farrellee via sijie)
Modified: zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java?rev=1480051&r1=1480050&r2=1480051&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java (original)
+++ zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java Tue May 7 19:49:19 2013
@@ -202,11 +202,10 @@ public class BookieFailureTest extends M
lh.asyncReadEntries(0, numEntriesToWrite - 1, this, sync);
synchronized (sync) {
- while (sync.value == false) {
- sync.wait(10000);
- assertTrue("Haven't received entries", sync.value);
- assertFalse("Failure occurred during read", sync.failureOccurred);
- }
+ int i = 0;
+ sync.wait(10000);
+ assertFalse("Failure occurred during read", sync.failureOccurred);
+ assertTrue("Haven't received entries", sync.value);
}
LOG.debug("*** READ COMPLETE ***");