You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@spark.apache.org by "Hyukjin Kwon (JIRA)" <ji...@apache.org> on 2019/05/21 04:14:18 UTC

[jira] [Resolved] (SPARK-22502) OnlineLDAOptimizer variationalTopicInference might be able to handle empty documents

     [ https://issues.apache.org/jira/browse/SPARK-22502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hyukjin Kwon resolved SPARK-22502.
----------------------------------
    Resolution: Incomplete

> OnlineLDAOptimizer variationalTopicInference might be able to handle empty documents
> ------------------------------------------------------------------------------------
>
>                 Key: SPARK-22502
>                 URL: https://issues.apache.org/jira/browse/SPARK-22502
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>    Affects Versions: 2.2.0
>            Reporter: yuhao yang
>            Priority: Trivial
>              Labels: bulk-closed
>
> Currently we assume OnlineLDAOptimizer.variationalTopicInference cannot take empty documents and added a few checks during training and inference. Yet I tested and in my local env sending empty vectors to  OnlineLDAOptimizer.variationalTopicInference does not trigger any error.
> If this is true, maybe we can remove the extra check. Please be cautious as compared with the gain (some code cleaning and little performance improvement), we do want to avoid a regression.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org