You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by "ilgrosso (via GitHub)" <gi...@apache.org> on 2024/05/10 14:29:09 UTC
[PR] [SYNCOPE-1815] Further Macro improvements [syncope]
ilgrosso opened a new pull request, #713:
URL: https://github.com/apache/syncope/pull/713
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYNCOPE-1815] Further Macro improvements [syncope]
Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso merged PR #713:
URL: https://github.com/apache/syncope/pull/713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYNCOPE-1815] Further Macro improvements [syncope]
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #713:
URL: https://github.com/apache/syncope/pull/713#discussion_r1596856197
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/macro/MacroActions.java:
##########
@@ -28,14 +29,18 @@
*/
public interface MacroActions {
- default void validate(SyncopeForm macroTaskForm) throws ValidationException {
- // does nothing by default
+ default Optional<String> getDefaultValue(String formProperty) {
+ return Optional.empty();
}
default Map<String, String> getDropdownValues(String formProperty) {
return Map.of();
}
+ default void validate(SyncopeForm form, Map<String, Object> vars) throws ValidationException {
Review Comment:
## Useless parameter
The parameter 'vars' is never used.
[Show more details](https://github.com/apache/syncope/security/code-scanning/1597)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/macro/MacroActions.java:
##########
@@ -28,14 +29,18 @@
*/
public interface MacroActions {
- default void validate(SyncopeForm macroTaskForm) throws ValidationException {
- // does nothing by default
+ default Optional<String> getDefaultValue(String formProperty) {
+ return Optional.empty();
}
default Map<String, String> getDropdownValues(String formProperty) {
return Map.of();
}
+ default void validate(SyncopeForm form, Map<String, Object> vars) throws ValidationException {
Review Comment:
## Useless parameter
The parameter 'form' is never used.
[Show more details](https://github.com/apache/syncope/security/code-scanning/1596)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/macro/MacroActions.java:
##########
@@ -28,14 +29,18 @@
*/
public interface MacroActions {
- default void validate(SyncopeForm macroTaskForm) throws ValidationException {
- // does nothing by default
+ default Optional<String> getDefaultValue(String formProperty) {
Review Comment:
## Useless parameter
The parameter 'formProperty' is never used.
[Show more details](https://github.com/apache/syncope/security/code-scanning/1599)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org