You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/24 20:26:01 UTC

[GitHub] [beam] ibzib commented on a change in pull request #15330: [BEAM-12683] Fix failing integration tests for Python Recommendation AI

ibzib commented on a change in pull request #15330:
URL: https://github.com/apache/beam/pull/15330#discussion_r756400538



##########
File path: sdks/python/apache_beam/ml/gcp/recommendations_ai_test_it.py
##########
@@ -102,7 +104,16 @@ def test_predict(self):
 
       assert_that(output, is_not_empty())
 
+  @classmethod
+  def tearDownClass(cls):
+    client = recommendationengine.CatalogServiceClient()

Review comment:
       Use `with` syntax here to release resources https://cloud.google.com/python/docs/reference/recommendationengine/latest/google.cloud.recommendationengine_v1beta1.services.catalog_service.CatalogServiceClient?skip_cache=false%22%2Fshopping-content%2Freference%2Frest%2Fv2.1%2Fproducts%5C%22#google_cloud_recommendationengine_v1beta1_services_catalog_service_CatalogServiceClient___exit__




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org