[jira] [Commented] (MSHARED-431) # (Hash-Sign) should trigger quoting in BourneShell.java

["Dennis Lundberg (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHARED-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161053#comment-17161053 ] 

Dennis Lundberg commented on MSHARED-431:
-----------------------------------------

Can this issue be closed now?

> # (Hash-Sign) should trigger quoting in BourneShell.java
> --------------------------------------------------------
>
>                 Key: MSHARED-431
>                 URL: https://issues.apache.org/jira/browse/MSHARED-431
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-shared-utils
>    Affects Versions: maven-shared-utils-0.8
>         Environment: Unix (Linux)
>            Reporter: Fritz Elfert
>            Priority: Major
>
> When trying to use the latest maven-jarsign-plugin using a keystore-password which started with a hash (#), signing failed. After enabling debug output with -X, I got a strange debug message:
> [DEBUG] Option lacks argument
> Since signtool is invoked using /bin/sh -c ..., of course, any # must be quoted, because otherwise it acts as a comment-start and thus effectively cuts-off the rest of the cmdline.
> After single-quoting the password in the pom.xml, the jar signing was ok.
> =>
> Adding '#' to BASH_QUOTING_TRIGGER_CHARS in org.apache.maven.shared.utils.cli.shell.BourneShell.java should fix the problem.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)