You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "pbaumard (via GitHub)" <gi...@apache.org> on 2025/05/04 15:32:19 UTC
[PR] [IO-875] CopyDirectoryVisitor ignores fileFilter [commons-io]
pbaumard opened a new pull request, #743:
URL: https://github.com/apache/commons-io/pull/743
- Fix [IO-875](https://issues.apache.org/jira/browse/IO-875)
- Fix javadoc
- Removed useless unit tests and added tests for the actual copied files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-875] CopyDirectoryVisitor ignores fileFilter [commons-io]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #743:
URL: https://github.com/apache/commons-io/pull/743#issuecomment-2850834472
@pbaumard
Thank you for your updates. I merged this PR followed up by some cleanups in git master.
TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-875] CopyDirectoryVisitor ignores fileFilter [commons-io]
Posted by "pbaumard (via GitHub)" <gi...@apache.org>.
pbaumard commented on PR #743:
URL: https://github.com/apache/commons-io/pull/743#issuecomment-2850241160
> @pbaumard Please do not remove assertions.
I don't see the point of the removed assertions, which are flagged by [SonarQube IDE](https://www.sonarsource.com/fr/products/sonarlint/) :
"Assertions should not compare an object to itself" ([RSPEC-5863](https://rules.sonarsource.com/java/RSPEC-5863/))
```java
assertEquals(visitFileTree, visitFileTree);
```
"Assertions comparing incompatible types should not be made" ([RSPEC-5845](https://rules.sonarsource.com/java/RSPEC-5845/))
```java
assertNotEquals(visitFileTree, "not");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-875] CopyDirectoryVisitor ignores fileFilter [commons-io]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #743:
URL: https://github.com/apache/commons-io/pull/743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-875] CopyDirectoryVisitor ignores fileFilter [commons-io]
Posted by "pbaumard (via GitHub)" <gi...@apache.org>.
pbaumard commented on PR #743:
URL: https://github.com/apache/commons-io/pull/743#issuecomment-2850477214
> @pbaumard Please do not remove assertions.
I thought at first that those removed assertions were useless since they were flagged by SonarLint ([RSPEC-5845](https://rules.sonarsource.com/java/RSPEC-5845/) and [RSPEC-5863](https://rules.sonarsource.com/java/RSPEC-5863/)).
I added them back and also added some new assertions to get a 100% coverage.
It could be better to move the equals and hashCode tests to some new method to make the intent clearer. For now I just added some comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org