[GitHub] [tinkerpop] spmallette commented on a change in pull request #1582: TINKERPOP-2716 implement eslint and prettier for code formatting

[GitBox <gi...@apache.org>]

spmallette commented on a change in pull request #1582:
URL: https://github.com/apache/tinkerpop/pull/1582#discussion_r832344998



##########
File path: gremlin-javascript/pom.xml
##########
@@ -236,6 +236,16 @@ file.write(file.getText("UTF-8").replaceFirst(/"version": "(.*)",/, "\"version\"
                             <failOnError>true</failOnError>
                         </configuration>
                     </execution>
+                    <execution>
+                      <id>npm lint</id>
+                      <phase>lint</phase>

Review comment:
       it needs to be a valid maven phase and "lint" is not one of those. you would want to probably tie this to the "verify" phase which would happen after integration tests. something like:
   
   ```xml
   <execution>
       <id>npm test</id>
       <phase>verify</phase>
       <goals>
           <goal>npm</goal>
       </goals>
       <configuration>
           <skip>${skipTests}</skip>
           <arguments>run lint</arguments>
           <failOnError>true</failOnError>
       </configuration>
   </execution>
   ```
   
   not sure if `run lint` needs other flags to exit out nicely in maven....you'll have to test but at least you hopefully see the pattern now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org