You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2014/10/21 17:46:34 UTC
Review Request 26979: Admin View: attempting to create instance using
same instance name fails
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26979/
-----------------------------------------------------------
Review request for Ambari, Andriy Babiichuk and Alexandr Antonenko.
Bugs: AMBARI-7886
https://issues.apache.org/jira/browse/AMBARI-7886
Repository: ambari
Description
-------
I created a view instance named JOBS_1, then attempted to create another instance, using the same name. The POST fails Conflict, which is correct but the UI shows nothing.
The user needs information on the failure when they click save.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js 76b4a7f
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/mainCtrl_test.js 5117a3f
Diff: https://reviews.apache.org/r/26979/diff/
Testing
-------
tested on real cluster
Thanks,
Aleksandr Kovalenko
Re: Review Request 26979: Admin View: attempting to create instance
using same instance name fails
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26979/#review57586
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On Окт. 21, 2014, 3:46 п.п., Aleksandr Kovalenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26979/
> -----------------------------------------------------------
>
> (Updated Окт. 21, 2014, 3:46 п.п.)
>
>
> Review request for Ambari, Andriy Babiichuk and Alexandr Antonenko.
>
>
> Bugs: AMBARI-7886
> https://issues.apache.org/jira/browse/AMBARI-7886
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I created a view instance named JOBS_1, then attempted to create another instance, using the same name. The POST fails Conflict, which is correct but the UI shows nothing.
> The user needs information on the failure when they click save.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js 76b4a7f
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/mainCtrl_test.js 5117a3f
>
> Diff: https://reviews.apache.org/r/26979/diff/
>
>
> Testing
> -------
>
> tested on real cluster
>
>
> Thanks,
>
> Aleksandr Kovalenko
>
>
Re: Review Request 26979: Admin View: attempting to create instance
using same instance name fails
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26979/#review57592
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On Oct. 21, 2014, 3:46 p.m., Aleksandr Kovalenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26979/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2014, 3:46 p.m.)
>
>
> Review request for Ambari, Andriy Babiichuk and Alexandr Antonenko.
>
>
> Bugs: AMBARI-7886
> https://issues.apache.org/jira/browse/AMBARI-7886
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I created a view instance named JOBS_1, then attempted to create another instance, using the same name. The POST fails Conflict, which is correct but the UI shows nothing.
> The user needs information on the failure when they click save.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js 76b4a7f
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/mainCtrl_test.js 5117a3f
>
> Diff: https://reviews.apache.org/r/26979/diff/
>
>
> Testing
> -------
>
> tested on real cluster
>
>
> Thanks,
>
> Aleksandr Kovalenko
>
>