You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@apr.apache.org by yl...@apache.org on 2020/06/01 11:09:17 UTC

svn propchange: r1878279 - svn:log

Author: ylavic
Revision: 1878279
Modified property: svn:log

Modified: svn:log at Mon Jun  1 11:09:17 2020
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Mon Jun  1 11:09:17 2020
@@ -4,3 +4,8 @@ apr_os_file_put() adds no cleanup so it
 apr_file_mktemp() adds the cleanup implicitely (unless the user specifies
 APR_FOPEN_NOCLEANUP explicitely), it needs to clear APR_FOPEN_NOCLEANUP for
 the resulting file.
+
+Note: Without this fix, a file created with apr_file_mktemp() and later
+      passed to apr_file_setaside(), or within a file bucket passed to
+      apr_bucket_setaside(), will leak both the fd and inode because
+      the cleanup gets dropped (e.g. httpd's BZ 64452).