You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/12/26 22:08:52 UTC

[PR] Revert "Remove remaining Airflow 2.5 backcompat code from Google Prov… [airflow]

potiuk opened a new pull request, #36440:
URL: https://github.com/apache/airflow/pull/36440

   …ider (#36366)"
   
   This reverts commit 2c2763f806517ae514d5614d519966da02ff4371.
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from Google Prov… [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #36440:
URL: https://github.com/apache/airflow/pull/36440#issuecomment-1870046719

   Added https://github.com/apache/airflow/pull/36442 to test the hypothesis


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from Google Prov… [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #36440:
URL: https://github.com/apache/airflow/pull/36440#issuecomment-1869803703

   Yep. Looks like reverting this change brings bavck "green" status.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from Google Prov… [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #36440:
URL: https://github.com/apache/airflow/pull/36440#issuecomment-1870046410

   I believe this error is manifestation of this pytest-asyncIo issue: https://github.com/pytest-dev/pytest-asyncio/issues/200 
   
   It looks like the way how pytest-asyncio implements their pytest fixtures is that it (sometimes) creates a new event loop to handle tests and when there are some pending tasks those tests are not cleaned immediately when the fixture event loop is leaving the test scope. So seems that the change in airflow/providers/google/cloud/log/stackdriver_task_handler.py (this is where asyncio code is used) is triggering a condition where stackdriver's test is leaving an asyncio task behind and that task only gets cancelled much later - and accidentally it produces a log entry in the same logger that is then verified in `test_disable_logging` . 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from Google Prov… [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #36440:
URL: https://github.com/apache/airflow/pull/36440#issuecomment-1869798531

   It's a very strange one -- very consistently happening for Postgres 14 + Pyhon 3.10 (and only for that combination (!??!)... If that one will fail, I plan to merge it and then we can try to start looking for the reason.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from Google Prov… [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #36440:
URL: https://github.com/apache/airflow/pull/36440#issuecomment-1869796981

   I think (though I have no idea how) this one triggered the (pretty repeatable) failure: https://github.com/apache/airflow/actions/runs/7331844040/job/19966037471
   
   I don't think this is a direct cause - the error looks like a side-effect of some asyncio test - i just want to see if reverting it will bring the green status again (seems that it started to happen after this one was merged).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from Google Prov… [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #36440:
URL: https://github.com/apache/airflow/pull/36440


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org