You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streampipes.apache.org by bo...@apache.org on 2022/12/12 17:16:48 UTC
[streampipes] 02/04: add checkstyle to streampipes-serializers-json
This is an automated email from the ASF dual-hosted git repository.
bossenti pushed a commit to branch checkstyl-enablements
in repository https://gitbox.apache.org/repos/asf/streampipes.git
commit cbd8a9c0667c150066b249710d9bd743608c4a57
Author: bossenti <bo...@posteo.de>
AuthorDate: Mon Dec 12 18:11:27 2022 +0100
add checkstyle to streampipes-serializers-json
---
streampipes-serializers-json/pom.xml | 12 ++++++++--
.../serializers/json/JacksonSerializer.java | 3 ++-
.../serializers/json/TestJacksonSerializer.java | 28 ++++++++++++----------
3 files changed, 27 insertions(+), 16 deletions(-)
diff --git a/streampipes-serializers-json/pom.xml b/streampipes-serializers-json/pom.xml
index 95e850c28..eeb8de777 100644
--- a/streampipes-serializers-json/pom.xml
+++ b/streampipes-serializers-json/pom.xml
@@ -16,7 +16,8 @@
~ limitations under the License.
~
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<parent>
<artifactId>streampipes-parent</artifactId>
<groupId>org.apache.streampipes</groupId>
@@ -58,5 +59,12 @@
<scope>test</scope>
</dependency>
</dependencies>
-
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ </plugin>
+ </plugins>
+ </build>
</project>
diff --git a/streampipes-serializers-json/src/main/java/org/apache/streampipes/serializers/json/JacksonSerializer.java b/streampipes-serializers-json/src/main/java/org/apache/streampipes/serializers/json/JacksonSerializer.java
index fe75a4f35..aaa26a91a 100644
--- a/streampipes-serializers-json/src/main/java/org/apache/streampipes/serializers/json/JacksonSerializer.java
+++ b/streampipes-serializers-json/src/main/java/org/apache/streampipes/serializers/json/JacksonSerializer.java
@@ -26,7 +26,8 @@ public class JacksonSerializer {
public static ObjectMapper getObjectMapper() {
ObjectMapper mapper = new ObjectMapper();
mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
- mapper.activateDefaultTypingAsProperty(mapper.getPolymorphicTypeValidator(), ObjectMapper.DefaultTyping.JAVA_LANG_OBJECT, "@class");
+ mapper.activateDefaultTypingAsProperty(mapper.getPolymorphicTypeValidator(),
+ ObjectMapper.DefaultTyping.JAVA_LANG_OBJECT, "@class");
mapper.enable(SerializationFeature.INDENT_OUTPUT);
return mapper;
diff --git a/streampipes-serializers-json/src/test/java/org/apache/streampipes/serializers/json/TestJacksonSerializer.java b/streampipes-serializers-json/src/test/java/org/apache/streampipes/serializers/json/TestJacksonSerializer.java
index 3c89ac9f3..9fafa8fac 100644
--- a/streampipes-serializers-json/src/test/java/org/apache/streampipes/serializers/json/TestJacksonSerializer.java
+++ b/streampipes-serializers-json/src/test/java/org/apache/streampipes/serializers/json/TestJacksonSerializer.java
@@ -17,9 +17,10 @@
*/
package org.apache.streampipes.serializers.json;
-import com.fasterxml.jackson.core.JsonProcessingException;
import org.apache.streampipes.model.template.PipelineElementTemplate;
import org.apache.streampipes.test.generator.template.PipelineElementTemplateHelpers;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
import org.junit.Assert;
import org.junit.Test;
@@ -27,28 +28,29 @@ import static org.junit.Assert.assertEquals;
public class TestJacksonSerializer {
+ public static void assertions(PipelineElementTemplate template) {
+ Assert.assertEquals("name", template.getTemplateName());
+ Assert.assertEquals("description", template.getTemplateDescription());
+ Assert.assertEquals(2, template.getTemplateConfigs().size());
+ Assert.assertEquals("test-string", template.getTemplateConfigs().get("test-key").getValue());
+ Assert.assertTrue(template.getTemplateConfigs().get("test-key").isEditable());
+ Assert.assertTrue(template.getTemplateConfigs().get("test-key").isDisplayed());
+ Assert.assertTrue(template.getTemplateConfigs().get("test-key-2").isEditable());
+ Assert.assertFalse(template.getTemplateConfigs().get("test-key-2").isDisplayed());
+ }
+
@Test
public void testPipelineElementTemplateSerialization() {
PipelineElementTemplate template = PipelineElementTemplateHelpers.makePipelineElementTemplate();
try {
String json = JacksonSerializer.getObjectMapper().writeValueAsString(template);
- PipelineElementTemplate template2 = JacksonSerializer.getObjectMapper().readValue(json, PipelineElementTemplate.class);
+ PipelineElementTemplate template2 =
+ JacksonSerializer.getObjectMapper().readValue(json, PipelineElementTemplate.class);
assertions(template2);
assertEquals(2, template2.getTemplateConfigs().get("test-key-2").getValue());
} catch (JsonProcessingException e) {
e.printStackTrace();
}
}
-
- public static void assertions(PipelineElementTemplate template) {
- Assert.assertEquals("name", template.getTemplateName());
- Assert.assertEquals("description", template.getTemplateDescription());
- Assert.assertEquals(2, template.getTemplateConfigs().size());
- Assert.assertEquals("test-string", template.getTemplateConfigs().get("test-key").getValue());
- Assert.assertTrue(template.getTemplateConfigs().get("test-key").isEditable());
- Assert.assertTrue(template.getTemplateConfigs().get("test-key").isDisplayed());
- Assert.assertTrue(template.getTemplateConfigs().get("test-key-2").isEditable());
- Assert.assertFalse(template.getTemplateConfigs().get("test-key-2").isDisplayed());
- }
}