You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gobblin.apache.org by zi...@apache.org on 2021/10/27 17:56:34 UTC

[gobblin] branch master updated: [GOBBLIN-1567] do not set a custom maxConnLifetime for sql connection (#3418)

This is an automated email from the ASF dual-hosted git repository.

zihanli58 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 94a777a  [GOBBLIN-1567] do not set a custom maxConnLifetime for sql connection (#3418)
94a777a is described below

commit 94a777a574e95d96225dbfcd6647a4eb74a995cd
Author: Arjun Singh Bora <ab...@linkedin.com>
AuthorDate: Wed Oct 27 10:56:29 2021 -0700

    [GOBBLIN-1567] do not set a custom maxConnLifetime for sql connection (#3418)
    
    * do not set a custom maxConnLifetime for sql connection
    
    * address review comment
---
 .../apache/gobblin/service/modules/db/ServiceDatabaseProviderImpl.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gobblin-service/src/main/java/org/apache/gobblin/service/modules/db/ServiceDatabaseProviderImpl.java b/gobblin-service/src/main/java/org/apache/gobblin/service/modules/db/ServiceDatabaseProviderImpl.java
index bb05ba6..d36a81e 100644
--- a/gobblin-service/src/main/java/org/apache/gobblin/service/modules/db/ServiceDatabaseProviderImpl.java
+++ b/gobblin-service/src/main/java/org/apache/gobblin/service/modules/db/ServiceDatabaseProviderImpl.java
@@ -87,7 +87,7 @@ public class ServiceDatabaseProviderImpl implements ServiceDatabaseProvider {
     private String password;
 
     @Builder.Default
-    private Duration maxConnectionLifetime = Duration.ofMinutes(1);
+    private Duration maxConnectionLifetime = Duration.ofMillis(-1);
 
     @Builder.Default
     private int maxConnections = 100;