You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Amol Deshmukh <am...@apache.org> on 2016/03/21 19:32:38 UTC
Review Request 45115: AURORA-1642: Thermos runner finalization broken.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Repository: aurora
Description
-------
AURORA-1642: Fix for broken finalization in Thermos runner.
Diffs
-----
src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
Diff: https://reviews.apache.org/r/45115/diff/
Testing
-------
# End to end tests
```
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
```
# Python unit tests
```
$ ./pants test src/test/python::
...
663 passed, 5 skipped, 1 warnings in 180.34 seconds
```
# Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
https://gist.github.com/adeshmukh/697d013dec64498a3942
Thanks,
Amol Deshmukh
Re: Review Request 45115: Ensure final processes are executed when
ephemeral daemon processes exist.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/#review124883
-----------------------------------------------------------
Ship it!
Master (b5c9e1b) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 22, 2016, 8:23 p.m., Amol Deshmukh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45115/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 8:23 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1642
> https://issues.apache.org/jira/browse/AURORA-1642
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ensure final processes are executed when ephemeral daemon processes exist.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
> src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
> src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc
>
> Diff: https://reviews.apache.org/r/45115/diff/
>
>
> Testing
> -------
>
> # End to end tests
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> ```
>
> # Python unit tests
> ```
> $ ./pants test src/test/python::
> ...
> 663 passed, 5 skipped, 1 warnings in 180.34 seconds
>
> ```
>
> # Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
> https://gist.github.com/adeshmukh/697d013dec64498a3942
>
>
> Thanks,
>
> Amol Deshmukh
>
>
Re: Review Request 45115: Ensure final processes are executed when
ephemeral daemon processes exist.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/#review124922
-----------------------------------------------------------
@ReviewBot retry
- Maxim Khutornenko
On March 22, 2016, 10:35 p.m., Amol Deshmukh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45115/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 10:35 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1642
> https://issues.apache.org/jira/browse/AURORA-1642
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ensure final processes are executed when ephemeral daemon processes exist.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
> src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
> src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc
>
> Diff: https://reviews.apache.org/r/45115/diff/
>
>
> Testing
> -------
>
> # End to end tests
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> ```
>
> # Python unit tests
> ```
> $ ./pants test src/test/python::
> ...
> 663 passed, 5 skipped, 1 warnings in 180.34 seconds
>
> ```
>
> # Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
> https://gist.github.com/adeshmukh/697d013dec64498a3942
>
>
> Thanks,
>
> Amol Deshmukh
>
>
Re: Review Request 45115: Ensure final processes are executed when
ephemeral daemon processes exist.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/#review124929
-----------------------------------------------------------
Ship it!
Master (b5c9e1b) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 22, 2016, 10:35 p.m., Amol Deshmukh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45115/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 10:35 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1642
> https://issues.apache.org/jira/browse/AURORA-1642
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ensure final processes are executed when ephemeral daemon processes exist.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
> src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
> src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc
>
> Diff: https://reviews.apache.org/r/45115/diff/
>
>
> Testing
> -------
>
> # End to end tests
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> ```
>
> # Python unit tests
> ```
> $ ./pants test src/test/python::
> ...
> 663 passed, 5 skipped, 1 warnings in 180.34 seconds
>
> ```
>
> # Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
> https://gist.github.com/adeshmukh/697d013dec64498a3942
>
>
> Thanks,
>
> Amol Deshmukh
>
>
Re: Review Request 45115: Ensure final processes are executed when
ephemeral daemon processes exist.
Posted by Amol Deshmukh <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/
-----------------------------------------------------------
(Updated March 22, 2016, 3:35 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
Updated ``test_resolver_console_output``.
@ReviewBot retry
Bugs: AURORA-1642
https://issues.apache.org/jira/browse/AURORA-1642
Repository: aurora
Description
-------
Ensure final processes are executed when ephemeral daemon processes exist.
Diffs (updated)
-----
src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc
Diff: https://reviews.apache.org/r/45115/diff/
Testing
-------
# End to end tests
```
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
```
# Python unit tests
```
$ ./pants test src/test/python::
...
663 passed, 5 skipped, 1 warnings in 180.34 seconds
```
# Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
https://gist.github.com/adeshmukh/697d013dec64498a3942
Thanks,
Amol Deshmukh
Re: Review Request 45115: Ensure final processes are executed when
ephemeral daemon processes exist.
Posted by Amol Deshmukh <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/
-----------------------------------------------------------
(Updated March 22, 2016, 3:04 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
- Also applied the fix in case LoggerDestination is CONSOLE (since sys.stdout/sys.stderr are file objects).
- Implemented maxim's review comments.
Bugs: AURORA-1642
https://issues.apache.org/jira/browse/AURORA-1642
Repository: aurora
Description
-------
Ensure final processes are executed when ephemeral daemon processes exist.
Diffs (updated)
-----
src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc
Diff: https://reviews.apache.org/r/45115/diff/
Testing
-------
# End to end tests
```
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
```
# Python unit tests
```
$ ./pants test src/test/python::
...
663 passed, 5 skipped, 1 warnings in 180.34 seconds
```
# Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
https://gist.github.com/adeshmukh/697d013dec64498a3942
Thanks,
Amol Deshmukh
Re: Review Request 45115: Ensure final processes are executed when
ephemeral daemon processes exist.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/#review124899
-----------------------------------------------------------
Master (b5c9e1b) is red with this patch.
./build-support/jenkins/build.sh
[1m proxy_driver = ProxyDriver()[0m
[1m with temporary_dir() as checkpoint_root:[0m
[1m te = AuroraExecutor([0m
[1m> runner_provider=make_provider(checkpoint_root),[0m
[1m sandbox_provider=DefaultTestSandboxProvider())[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:580:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider
[1m pex_location=thermos_runner_path(),[0m
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
build = True
[1m def thermos_runner_path(build=True):[0m
[1m if not build:[0m
[1m return getattr(thermos_runner_path, 'value', None)[0m
[1m [0m
[1m if not hasattr(thermos_runner_path, 'value'):[0m
[1m pex_dir = safe_mkdtemp()[0m
[1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m
[1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m
[1m[31mE assert 1 == 0[0m
[1m[31mE + where 1 = <function call at 0x7fb45014a938>(['./pants', '--pants-distdir=/tmp/user/2396/tmpe7EGxb', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m
[1m[31mE + where <function call at 0x7fb45014a938> = subprocess.call[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError
-------------- Captured stderr call --------------
Traceback (most recent call last):
File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", line 7, in <module>
from pants.bin.pants_exe import main
ImportError: No module named pants.bin.pants_exe
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 16 failed, 640 passed, 5 skipped, 1 warnings, 8 error in 178.00 seconds [0m
FAILURE
21:50:31 04:00 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 22, 2016, 9:04 p.m., Amol Deshmukh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45115/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 9:04 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1642
> https://issues.apache.org/jira/browse/AURORA-1642
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ensure final processes are executed when ephemeral daemon processes exist.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
> src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
> src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc
>
> Diff: https://reviews.apache.org/r/45115/diff/
>
>
> Testing
> -------
>
> # End to end tests
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> ```
>
> # Python unit tests
> ```
> $ ./pants test src/test/python::
> ...
> 663 passed, 5 skipped, 1 warnings in 180.34 seconds
>
> ```
>
> # Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
> https://gist.github.com/adeshmukh/697d013dec64498a3942
>
>
> Thanks,
>
> Amol Deshmukh
>
>
Re: Review Request 45115: Ensure final processes are executed when
ephemeral daemon processes exist.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/#review124886
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On March 22, 2016, 2:04 p.m., Amol Deshmukh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45115/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 2:04 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1642
> https://issues.apache.org/jira/browse/AURORA-1642
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ensure final processes are executed when ephemeral daemon processes exist.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
> src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
> src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc
>
> Diff: https://reviews.apache.org/r/45115/diff/
>
>
> Testing
> -------
>
> # End to end tests
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> ```
>
> # Python unit tests
> ```
> $ ./pants test src/test/python::
> ...
> 663 passed, 5 skipped, 1 warnings in 180.34 seconds
>
> ```
>
> # Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
> https://gist.github.com/adeshmukh/697d013dec64498a3942
>
>
> Thanks,
>
> Amol Deshmukh
>
>
Re: Review Request 45115: Ensure final processes are executed when
ephemeral daemon processes exist.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/#review124891
-----------------------------------------------------------
Ship it!
src/main/python/apache/thermos/core/process.py (line 521)
<https://reviews.apache.org/r/45115/#comment187587>
drop extra "the"
src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora (line 39)
<https://reviews.apache.org/r/45115/#comment187590>
you can drop this line as default `instances` is already set to 1
- Maxim Khutornenko
On March 22, 2016, 9:04 p.m., Amol Deshmukh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45115/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 9:04 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1642
> https://issues.apache.org/jira/browse/AURORA-1642
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ensure final processes are executed when ephemeral daemon processes exist.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
> src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
> src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc
>
> Diff: https://reviews.apache.org/r/45115/diff/
>
>
> Testing
> -------
>
> # End to end tests
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> ```
>
> # Python unit tests
> ```
> $ ./pants test src/test/python::
> ...
> 663 passed, 5 skipped, 1 warnings in 180.34 seconds
>
> ```
>
> # Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
> https://gist.github.com/adeshmukh/697d013dec64498a3942
>
>
> Thanks,
>
> Amol Deshmukh
>
>
Re: Review Request 45115: Ensure final processes are executed when
ephemeral daemon processes exist.
Posted by Amol Deshmukh <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/
-----------------------------------------------------------
(Updated March 22, 2016, 2:04 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
Refactored based on Maxim's offline feedback.
Bugs: AURORA-1642
https://issues.apache.org/jira/browse/AURORA-1642
Repository: aurora
Description
-------
Ensure final processes are executed when ephemeral daemon processes exist.
Diffs (updated)
-----
src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc
Diff: https://reviews.apache.org/r/45115/diff/
Testing
-------
# End to end tests
```
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
```
# Python unit tests
```
$ ./pants test src/test/python::
...
663 passed, 5 skipped, 1 warnings in 180.34 seconds
```
# Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
https://gist.github.com/adeshmukh/697d013dec64498a3942
Thanks,
Amol Deshmukh
Re: Review Request 45115: Ensure final processes are executed when
ephemeral daemon processes exist.
Posted by Amol Deshmukh <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/
-----------------------------------------------------------
(Updated March 22, 2016, 1:23 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
Updated commit title.
Summary (updated)
-----------------
Ensure final processes are executed when ephemeral daemon processes exist.
Bugs: AURORA-1642
https://issues.apache.org/jira/browse/AURORA-1642
Repository: aurora
Description (updated)
-------
Ensure final processes are executed when ephemeral daemon processes exist.
Diffs
-----
src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc
Diff: https://reviews.apache.org/r/45115/diff/
Testing
-------
# End to end tests
```
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
```
# Python unit tests
```
$ ./pants test src/test/python::
...
663 passed, 5 skipped, 1 warnings in 180.34 seconds
```
# Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
https://gist.github.com/adeshmukh/697d013dec64498a3942
Thanks,
Amol Deshmukh
Re: Review Request 45115: AURORA-1642: Thermos runner finalization
broken.
Posted by Amol Deshmukh <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/
-----------------------------------------------------------
(Updated March 22, 2016, 1:06 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
Added e2e test to ensure that final processes are executed on completion of regular processes in the presence of long-running ephemeral_daemon processes.
Bugs: AURORA-1642
https://issues.apache.org/jira/browse/AURORA-1642
Repository: aurora
Description
-------
AURORA-1642: Fix for broken finalization in Thermos runner.
Diffs (updated)
-----
src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc
Diff: https://reviews.apache.org/r/45115/diff/
Testing
-------
# End to end tests
```
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
```
# Python unit tests
```
$ ./pants test src/test/python::
...
663 passed, 5 skipped, 1 warnings in 180.34 seconds
```
# Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
https://gist.github.com/adeshmukh/697d013dec64498a3942
Thanks,
Amol Deshmukh
Re: Review Request 45115: AURORA-1642: Thermos runner finalization
broken.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/#review124625
-----------------------------------------------------------
Ship it!
Master (b24619b) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 21, 2016, 6:36 p.m., Amol Deshmukh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45115/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 6:36 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1642
> https://issues.apache.org/jira/browse/AURORA-1642
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1642: Fix for broken finalization in Thermos runner.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
> src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
>
> Diff: https://reviews.apache.org/r/45115/diff/
>
>
> Testing
> -------
>
> # End to end tests
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> ```
>
> # Python unit tests
> ```
> $ ./pants test src/test/python::
> ...
> 663 passed, 5 skipped, 1 warnings in 180.34 seconds
>
> ```
>
> # Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
> https://gist.github.com/adeshmukh/697d013dec64498a3942
>
>
> Thanks,
>
> Amol Deshmukh
>
>
Re: Review Request 45115: AURORA-1642: Thermos runner finalization
broken.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On March 21, 2016, 7:28 p.m., Joshua Cohen wrote:
> > Does anyone think it would make sense to add a task w/ a final process to the e2e suite to avoid future breakages like this in the future?
+1. Given how much time it took us to investigate, it would be imprudent to ship it without a good test in place. One possibility could be crafting a finalizing task into our test job. That task could just print "OK" into stderr and the test would just curl it from http://localhost:1338/logs/<task_id>/finalizing_task/0/stderr. You can get task_id from aurora_admin (see test_observer_ui for example).
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/#review124628
-----------------------------------------------------------
On March 21, 2016, 6:36 p.m., Amol Deshmukh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45115/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 6:36 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1642
> https://issues.apache.org/jira/browse/AURORA-1642
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1642: Fix for broken finalization in Thermos runner.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
> src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
>
> Diff: https://reviews.apache.org/r/45115/diff/
>
>
> Testing
> -------
>
> # End to end tests
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> ```
>
> # Python unit tests
> ```
> $ ./pants test src/test/python::
> ...
> 663 passed, 5 skipped, 1 warnings in 180.34 seconds
>
> ```
>
> # Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
> https://gist.github.com/adeshmukh/697d013dec64498a3942
>
>
> Thanks,
>
> Amol Deshmukh
>
>
Re: Review Request 45115: AURORA-1642: Thermos runner finalization
broken.
Posted by Amol Deshmukh <am...@apache.org>.
> On March 21, 2016, 12:28 p.m., Joshua Cohen wrote:
> > Does anyone think it would make sense to add a task w/ a final process to the e2e suite to avoid future breakages like this in the future?
>
> Maxim Khutornenko wrote:
> +1. Given how much time it took us to investigate, it would be imprudent to ship it without a good test in place. One possibility could be crafting a finalizing task into our test job. That task could just print "OK" into stderr and the test would just curl it from http://localhost:1338/logs/<task_id>/finalizing_task/0/stderr. You can get task_id from aurora_admin (see test_observer_ui for example).
Thanks for the suggestion. I will add the test and repost for review.
- Amol
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/#review124628
-----------------------------------------------------------
On March 21, 2016, 11:36 a.m., Amol Deshmukh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45115/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 11:36 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1642
> https://issues.apache.org/jira/browse/AURORA-1642
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1642: Fix for broken finalization in Thermos runner.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
> src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
>
> Diff: https://reviews.apache.org/r/45115/diff/
>
>
> Testing
> -------
>
> # End to end tests
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> ```
>
> # Python unit tests
> ```
> $ ./pants test src/test/python::
> ...
> 663 passed, 5 skipped, 1 warnings in 180.34 seconds
>
> ```
>
> # Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
> https://gist.github.com/adeshmukh/697d013dec64498a3942
>
>
> Thanks,
>
> Amol Deshmukh
>
>
Re: Review Request 45115: AURORA-1642: Thermos runner finalization
broken.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/#review124628
-----------------------------------------------------------
Does anyone think it would make sense to add a task w/ a final process to the e2e suite to avoid future breakages like this in the future?
- Joshua Cohen
On March 21, 2016, 6:36 p.m., Amol Deshmukh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45115/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 6:36 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1642
> https://issues.apache.org/jira/browse/AURORA-1642
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1642: Fix for broken finalization in Thermos runner.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
> src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
>
> Diff: https://reviews.apache.org/r/45115/diff/
>
>
> Testing
> -------
>
> # End to end tests
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> ```
>
> # Python unit tests
> ```
> $ ./pants test src/test/python::
> ...
> 663 passed, 5 skipped, 1 warnings in 180.34 seconds
>
> ```
>
> # Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
> https://gist.github.com/adeshmukh/697d013dec64498a3942
>
>
> Thanks,
>
> Amol Deshmukh
>
>
Re: Review Request 45115: AURORA-1642: Thermos runner finalization
broken.
Posted by Amol Deshmukh <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/
-----------------------------------------------------------
(Updated March 21, 2016, 11:36 a.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
Linked to AURORA-1642
Bugs: AURORA-1642
https://issues.apache.org/jira/browse/AURORA-1642
Repository: aurora
Description
-------
AURORA-1642: Fix for broken finalization in Thermos runner.
Diffs
-----
src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7
src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5
Diff: https://reviews.apache.org/r/45115/diff/
Testing
-------
# End to end tests
```
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
```
# Python unit tests
```
$ ./pants test src/test/python::
...
663 passed, 5 skipped, 1 warnings in 180.34 seconds
```
# Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
https://gist.github.com/adeshmukh/697d013dec64498a3942
Thanks,
Amol Deshmukh