You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2018/08/08 10:38:54 UTC

tinkerpop git commit: TINKERPOP-1976 Can't assert order() for pageRank()

Repository: tinkerpop
Updated Branches:
  refs/heads/TINKERPOP-1976 1414adc76 -> 3e432d0ff


TINKERPOP-1976 Can't assert order() for pageRank()


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/3e432d0f
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/3e432d0f
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/3e432d0f

Branch: refs/heads/TINKERPOP-1976
Commit: 3e432d0ffae919e4460af19301c6f8ca7ff6c61a
Parents: 1414adc
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Wed Aug 8 06:38:21 2018 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Wed Aug 8 06:38:21 2018 -0400

----------------------------------------------------------------------
 gremlin-test/features/map/PageRank.feature | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/3e432d0f/gremlin-test/features/map/PageRank.feature
----------------------------------------------------------------------
diff --git a/gremlin-test/features/map/PageRank.feature b/gremlin-test/features/map/PageRank.feature
index 76af1ed..049b8c2 100644
--- a/gremlin-test/features/map/PageRank.feature
+++ b/gremlin-test/features/map/PageRank.feature
@@ -48,6 +48,8 @@ Feature: Step - pageRank()
       | m[{"name": ["lop"], "projectRank": [3.0]}] |
       | m[{"name": ["ripple"], "projectRank": [1.0]}] |
 
+  # can't fully assert order here because some ranks are equivalent. the java test does an "or" type assert to deal
+  # with this, which we can't express here in these tests. should probably change the test or
   Scenario: g_V_pageRank_order_byXpageRank_decrX_name
     Given the modern graph
     And the traversal of
@@ -55,7 +57,7 @@ Feature: Step - pageRank()
       g.withComputer().V().pageRank().order().by("gremlin.pageRankVertexProgram.pageRank", Order.decr).values("name")
       """
     When iterated to list
-    Then the result should be ordered
+    Then the result should be unordered
       | result |
       | lop    |
       | ripple |