You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Uma Maheswara Rao G (Created) (JIRA)" <ji...@apache.org> on 2011/12/19 20:39:30 UTC
[jira] [Created] (HADOOP-7932) HA : Make client connection retries
on socket time outs configurable.
HA : Make client connection retries on socket time outs configurable.
---------------------------------------------------------------------
Key: HADOOP-7932
URL: https://issues.apache.org/jira/browse/HADOOP-7932
Project: Hadoop Common
Issue Type: Sub-task
Components: ha, ipc
Affects Versions: HA Branch (HDFS-1623)
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7932) HA : Make client connection
retries on socket time outs configurable.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172632#comment-13172632 ]
Uma Maheswara Rao G commented on HADOOP-7932:
---------------------------------------------
Thanks a lot, Todd for the review!
Attached the patch by addressing your comments.
> HA : Make client connection retries on socket time outs configurable.
> ---------------------------------------------------------------------
>
> Key: HADOOP-7932
> URL: https://issues.apache.org/jira/browse/HADOOP-7932
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha, ipc
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7932.patch, HADOOP-7932.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7932) HA : Make client connection retries
on socket time outs configurable.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7932:
----------------------------------------
Attachment: HADOOP-7932.patch
> HA : Make client connection retries on socket time outs configurable.
> ---------------------------------------------------------------------
>
> Key: HADOOP-7932
> URL: https://issues.apache.org/jira/browse/HADOOP-7932
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha, ipc
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7932.patch, HADOOP-7932.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7932) HA : Make client connection
retries on socket time outs configurable.
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172631#comment-13172631 ]
Todd Lipcon commented on HADOOP-7932:
-------------------------------------
+1. I'll commit this momentarily
> HA : Make client connection retries on socket time outs configurable.
> ---------------------------------------------------------------------
>
> Key: HADOOP-7932
> URL: https://issues.apache.org/jira/browse/HADOOP-7932
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha, ipc
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7932.patch, HADOOP-7932.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7932) HA : Make client connection
retries on socket time outs configurable.
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172606#comment-13172606 ]
Todd Lipcon commented on HADOOP-7932:
-------------------------------------
Small nits:
{code}
+ // set max retries to 1
+ conf.setInt(IPC_CLIENT_CONNECT_MAX_RETRIES_ON_TIMEOUTS, 0);
{code}
I think you mean "set max retries to 0" :)
----
- Can you add the new conf as a constant in CommonConfigurationKeysPublic?
- In the test, no need for the "FAILURE_MSG" constant since it's only used once
> HA : Make client connection retries on socket time outs configurable.
> ---------------------------------------------------------------------
>
> Key: HADOOP-7932
> URL: https://issues.apache.org/jira/browse/HADOOP-7932
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha, ipc
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7932.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7932) HA : Make client connection
retries on socket time outs configurable.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173154#comment-13173154 ]
Hudson commented on HADOOP-7932:
--------------------------------
Integrated in Hadoop-Hdfs-HAbranch-build #22 (See [https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/22/])
HADOOP-7932. Make client connection retries on socket time outs configurable. Contributed by Uma Maheswara Rao G.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1220957
Files :
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
> HA : Make client connection retries on socket time outs configurable.
> ---------------------------------------------------------------------
>
> Key: HADOOP-7932
> URL: https://issues.apache.org/jira/browse/HADOOP-7932
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha, ipc
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: HA Branch (HDFS-1623)
>
> Attachments: HADOOP-7932.patch, HADOOP-7932.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-7932) HA : Make client connection retries
on socket time outs configurable.
Posted by "Todd Lipcon (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HADOOP-7932.
---------------------------------
Resolution: Fixed
Fix Version/s: HA Branch (HDFS-1623)
Hadoop Flags: Reviewed
Committed to branch. Thanks, Uma!
> HA : Make client connection retries on socket time outs configurable.
> ---------------------------------------------------------------------
>
> Key: HADOOP-7932
> URL: https://issues.apache.org/jira/browse/HADOOP-7932
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha, ipc
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: HA Branch (HDFS-1623)
>
> Attachments: HADOOP-7932.patch, HADOOP-7932.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7932) HA : Make client connection retries
on socket time outs configurable.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7932:
----------------------------------------
Attachment: HADOOP-7932.patch
> HA : Make client connection retries on socket time outs configurable.
> ---------------------------------------------------------------------
>
> Key: HADOOP-7932
> URL: https://issues.apache.org/jira/browse/HADOOP-7932
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha, ipc
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7932.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira