[GitHub] [flink] azagrebin commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

[GitBox <gi...@apache.org>]

azagrebin commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes
URL: https://github.com/apache/flink/pull/8181#issuecomment-483988809
 
 
   @zhijiangW
   The idea looks good to me. Only one thing to clarify: `during creating SingleInputGate we could pass ProxyMetricGroup for the input channel to create numBytesInLocal and numBytesInRemote`. At the moment, we have only one `numBytesInLocal/Remote` per task, so they have to be created only once per task. But I think we could already introduce the totals here for `IOMetrics` (also one per task) as you wrote and increment them in `SingleInputGate` before we introduce `InputGateWithMetrics` and think about `NetworkEnvironment#registerMetrics`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services