You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/09/06 00:53:20 UTC
[kudu-CR](branch-1.4.x) KUDU-2083. Decrement running maintenance ops on failed prepare
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7968
Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare
......................................................................
KUDU-2083. Decrement running maintenance ops on failed prepare
There is currently a bug where we don't decrement the number of
running ops when an op->Prepare() fails. Although rare, when this
bug is hit, it will decrease the number of simultaneous mm ops
that can run until none can, causing the tserver to run OOM.
Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291
Reviewed-on: http://gerrit.cloudera.org:8080/7610
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit b365ad0bd6372d459f547da0f1cb82e36148c541)
---
M src/kudu/util/maintenance_manager.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/7968/1
--
To view, visit http://gerrit.cloudera.org:8080/7968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.4.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
[kudu-CR](branch-1.4.x) KUDU-2083. Decrement running maintenance ops on failed prepare
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare
......................................................................
KUDU-2083. Decrement running maintenance ops on failed prepare
There is currently a bug where we don't decrement the number of
running ops when an op->Prepare() fails. Although rare, when this
bug is hit, it will decrease the number of simultaneous mm ops
that can run until none can, causing the tserver to run OOM.
Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291
Reviewed-on: http://gerrit.cloudera.org:8080/7610
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit b365ad0bd6372d459f547da0f1cb82e36148c541)
Reviewed-on: http://gerrit.cloudera.org:8080/7968
---
M src/kudu/util/maintenance_manager.cc
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.4.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.4.x) KUDU-2083. Decrement running maintenance ops on failed prepare
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.4.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No