You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/09/25 08:56:59 UTC
[GitHub] sijie commented on a change in pull request #1695:
autorecovery-use-metadata-driver (part 3) : remove zookeeper from Auditor
class
sijie commented on a change in pull request #1695: autorecovery-use-metadata-driver (part 3) : remove zookeeper from Auditor class
URL: https://github.com/apache/bookkeeper/pull/1695#discussion_r220109796
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -104,8 +102,50 @@
private Set<String> bookiesToBeAudited = Sets.newHashSet();
private volatile int lostBookieRecoveryDelayBeforeChange;
- public Auditor(final String bookieIdentifier, ServerConfiguration conf,
- ZooKeeper zkc, StatsLogger statsLogger) throws UnavailableException {
+ static BookKeeper createBookKeeperClient(ServerConfiguration conf)
+ throws InterruptedException, IOException {
+ ClientConfiguration clientConfiguration = new ClientConfiguration(conf);
+ clientConfiguration.setClientRole(ClientConfiguration.CLIENT_ROLE_SYSTEM);
+ LOG.info("AuthProvider used by the Auditor is {}",
Review comment:
I think this logging doesn't belong to this method. it should be kept at `initialize` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services