You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/02/22 12:01:07 UTC
[GitHub] [echarts] equicy opened a new pull request #16561: fix: the histogram cannot be displayed normally due to the problem of NaN data
equicy opened a new pull request #16561:
URL: https://github.com/apache/echarts/pull/16561
In the bar example, the histogram cannot be displayed normally due to the problem of Nan data
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Due to the data like '-' in the test code, it becomes NaN when converted to numerical value, so that the histogram cannot be displayed
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
<img width="411" alt="截屏2022-02-22 下午7 38 38" src="https://user-images.githubusercontent.com/36806217/155127929-eca9d39f-9700-4fbb-a5e0-fa61ce43a026.png">
<img width="623" alt="截屏2022-02-22 下午7 54 23" src="https://user-images.githubusercontent.com/36806217/155127990-e76730a1-1990-4d74-8cc6-065d21a4be16.png">
### After: How is it fixed in this PR?
modify code 'data1.push(i === 0 ? '-' : (Math.random() * 5).toFixed(2));' to data1.push((Math.random() * 5).toFixed(2));
<img width="608" alt="截屏2022-02-22 下午7 53 58" src="https://user-images.githubusercontent.com/36806217/155128017-bacf84df-b94a-439a-a03f-b1fa32dc8acb.png">
### Fixed issues
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] equicy closed pull request #16561: fix: the histogram cannot be displayed normally due to the problem of NaN data
Posted by GitBox <gi...@apache.org>.
equicy closed pull request #16561:
URL: https://github.com/apache/echarts/pull/16561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16561: fix: the histogram cannot be displayed normally due to the problem of NaN data
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16561:
URL: https://github.com/apache/echarts/pull/16561#issuecomment-1047724943
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org