You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/12/11 05:13:10 UTC

[jira] [Commented] (AMBARI-14315) Config properties does not appear in right order

    [ https://issues.apache.org/jira/browse/AMBARI-14315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052137#comment-15052137 ] 

Hadoop QA commented on AMBARI-14315:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12776880/AMBARI-14315.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-web.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/4563//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/4563//console

This message is automatically generated.

> Config properties does not appear in right order
> ------------------------------------------------
>
>                 Key: AMBARI-14315
>                 URL: https://issues.apache.org/jira/browse/AMBARI-14315
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-web
>    Affects Versions: trunk
>            Reporter: Matt
>            Assignee: Matt
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: AMBARI-14315.patch
>
>
> Any property with index 0 in site_properties.js ends up at the bottom of the config section. Property with index 0 should ideally be at the top.
> Reason why this happens:
> https://github.com/apache/ambari/blob/trunk/ambari-web/app/mappers/configs/stack_config_properties_mapper.js#L172
> config.index = uiConfigProperty.index || Infinity;
> When uiConfigProperty.index = 0, config.index = Infinity



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)