[jira] [Commented] (TAJO-2130) Remove inet4 data type

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284092#comment-15284092 ] 

Hudson commented on TAJO-2130:
------------------------------

FAILURE: Integrated in Tajo-master-CODEGEN-build #728 (See [https://builds.apache.org/job/Tajo-master-CODEGEN-build/728/])
TAJO-2130: Remove inet4 data type. (jihoonson: rev f995e303b5a82121fbf2ecc16e06541937a17fa1)
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileScanner.java
* tajo-common/src/main/java/org/apache/tajo/datum/Inet4Datum.java
* tajo-storage/tajo-storage-hdfs/src/test/resources/dataset/testVariousTypes.avsc
* tajo-core/src/main/java/org/apache/tajo/engine/planner/UniformRangePartition.java
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java
* tajo-client/src/main/java/org/apache/tajo/storage/RowStoreUtil.java
* tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SchemaUtil.java
* tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLLexer.g4
* tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RadixSort.java
* tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/json/TestJsonSerDe.java
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/TextFieldSerializerDeserializer.java
* tajo-core-tests/src/test/resources/queries/TestNetTypes/testJoin.sql
* tajo-storage/tajo-storage-common/src/test/java/org/apache/tajo/storage/TestFrameTuple.java
* tajo-plan/src/main/java/org/apache/tajo/plan/function/stream/TextFieldSerializerDeserializer.java
* tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java
* tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/raw/TestDirectRawFile.java
* tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/DataTypeUtil.java
* tajo-common/src/main/java/org/apache/tajo/tuple/memory/CompactRowBlockWriter.java
* tajo-common/src/main/java/org/apache/tajo/tuple/memory/OffHeapRowBlockUtils.java
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/orc/OrcUtils.java
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/RawFile.java
* tajo-common/src/main/java/org/apache/tajo/tuple/memory/RowWriter.java
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoSchemaConverter.java
* tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/BinarySerializerDeserializer.java
* tajo-common/src/test/java/org/apache/tajo/datum/TestInet4Datum.java
* tajo-plan/src/main/java/org/apache/tajo/plan/function/stream/CSVLineSerializer.java
* tajo-core-tests/src/test/java/org/apache/tajo/engine/util/BenchmarkSort.java
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/orc/WriterImpl.java
* CHANGES
* tajo-common/src/main/java/org/apache/tajo/tuple/memory/OffHeapRowWriter.java
* tajo-core/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPCountryInet4.java
* tajo-core-tests/src/test/resources/queries/TestNetTypes/testSort.sql
* tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestRadixSort.java
* tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java
* tajo-core-tests/src/test/resources/queries/TestNetTypes/testSelect.sql
* tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java
* tajo-plan/src/test/java/org/apache/tajo/plan/util/TestWritableTypeConverter.java
* tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
* tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/orc/TreeReaderFactory.java
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/RowFile.java
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileAppender.java
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/package-info.java
* tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/parquet/TestSchemaConverter.java
* tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLParser.g4
* tajo-common/src/main/java/org/apache/tajo/type/TypeFactory.java
* tajo-core-tests/src/test/java/org/apache/tajo/engine/codegen/TestEvalCodeGenerator.java
* tajo-common/src/main/java/org/apache/tajo/type/Inet4.java
* tajo-core-tests/src/test/java/org/apache/tajo/engine/util/TestTupleUtil.java
* tajo-core/src/main/java/org/apache/tajo/engine/codegen/TajoGeneratorAdapter.java
* tajo-common/src/test/java/org/apache/tajo/type/TestTypeEncoder.java
* tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java
* tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/TextSerializerDeserializer.java
* tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/package-info.java
* tajo-core-tests/src/test/resources/queries/TestNetTypes/table1_ddl.sql
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/avro/AvroScanner.java
* tajo-core-tests/src/test/resources/queries/TestNetTypes/testGroupby.sql
* tajo-storage/tajo-storage-common/src/test/java/org/apache/tajo/storage/TestLazyTuple.java
* tajo-common/src/main/java/org/apache/tajo/tuple/memory/HeapTuple.java
* tajo-core-tests/src/test/resources/queries/TestNetTypes/testGroupby2.sql
* tajo-common/src/main/proto/DataTypes.proto
* tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/RowStoreUtil.java
* tajo-common/src/main/java/org/apache/tajo/type/Type.java
* tajo-common/src/main/java/org/apache/tajo/common/type/TajoTypeUtil.java
* tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestDelimitedTextFile.java
* tajo-core/src/main/java/org/apache/tajo/engine/codegen/EvalCodeGenerator.java
* tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ComparableVector.java
* tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestUniformRangePartition.java
* tajo-core-tests/src/test/resources/queries/TestNetTypes/table2_ddl.sql
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoWriteSupport.java
* tajo-common/src/main/java/org/apache/tajo/tuple/memory/UnSafeTuple.java
* tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java
* tajo-core/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPInCountryInet4.java
* tajo-core-tests/src/test/resources/queries/TestNetTypes/testSort2.sql
* tajo-plan/src/main/java/org/apache/tajo/plan/verifier/ExprsVerifier.java
* tajo-common/src/test/java/org/apache/tajo/tuple/memory/TestMemoryRowBlock.java
* tajo-core/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java
* tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordConverter.java


> Remove inet4 data type
> ----------------------
>
>                 Key: TAJO-2130
>                 URL: https://issues.apache.org/jira/browse/TAJO-2130
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Data Type
>    Affects Versions: 0.11.0, 0.11.1, 0.11.2, 0.11.3
>            Reporter: Hyunsik Choi
>            Assignee: Jongyoung Park
>             Fix For: 0.12.0
>
>
> Inet4 data type is not necessary and is not used. It can be easily replaced by INT4 data type with some UDFs. Also, inet4 is overlapped with binary data types. Instead of keeping inet4, it would be better to improve binary data types.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)