[GitHub] [arrow-adbc] WillAyd commented on pull request #668: feat(c/driver/postgresql): Implement Postgres Get table types

["WillAyd (via GitHub)" <gi...@apache.org>]

WillAyd commented on PR #668:
URL: https://github.com/apache/arrow-adbc/pull/668#issuecomment-1541018849

   I was hoping to add some more explicit testing in the base `adbc_validation.cc` implementation of the GetTableTypes test. Something like this:
   
   ```cc
     ...
   
     bool seen_table = false;
     bool seen_view = false;
     for (auto row = 0; row < reader.array->length; row++) {
       ArrowStringView val =
           ArrowArrayViewGetStringUnsafe(reader.array_view->children[0], row);
       auto str_val = std::string(val.data, val.size_bytes);
       if (str_val == "table")
         seen_table = true;
       else if (str_val == "view")
         seen_view = true;
     }
     ASSERT_TRUE(seen_table);
     ASSERT_TRUE(seen_view);
   ```
   
   However it looks like Dremio might not provide back these values(?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org