[GitHub] [pulsar] eolivelli commented on a change in pull request #14630: [owasp] Suppress ZooKeeper 3.8.0 vulnerabilities

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #14630:
URL: https://github.com/apache/pulsar/pull/14630#discussion_r823453812



##########
File path: src/owasp-dependency-check-false-positives.xml
##########
@@ -59,4 +59,68 @@
     <packageUrl regex="true">^pkg:maven/io\.netty/netty\-tcnative\-classes@.*$</packageUrl>
     <cpe>cpe:/a:netty:netty</cpe>
   </suppress>
+  <suppress>
+    <notes><![CDATA[
+   file name: zookeeper-3.8.0.jar

Review comment:
       please add a meaningful explanation.
   Some thing like "This is a false positive, the CVE is not about Apache ZooKeeper"

##########
File path: src/owasp-dependency-check-false-positives.xml
##########
@@ -59,4 +59,68 @@
     <packageUrl regex="true">^pkg:maven/io\.netty/netty\-tcnative\-classes@.*$</packageUrl>
     <cpe>cpe:/a:netty:netty</cpe>
   </suppress>
+  <suppress>
+    <notes><![CDATA[
+   file name: zookeeper-3.8.0.jar

Review comment:
       you can create a single entry with multiple CVEs
   this way it is simpler to maintain the list, as all those exclusions are due to the same false positive
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org