You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by spyrdzy <gi...@git.apache.org> on 2017/12/15 05:51:46 UTC

[GitHub] libcloud pull request #1155: Fixes Apache LIBCLOUD-809

GitHub user spyrdzy opened a pull request:

    https://github.com/apache/libcloud/pull/1155

    Fixes Apache LIBCLOUD-809

    ## Changes 
    Fixes Apache LIBCLOUD-809
    
    ### Description
    Merged variables and docstrings for deploy_node to meet features added to create_node.
    
    Reference link: https://issues.apache.org/jira/browse/LIBCLOUD-809
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [X] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/spyrdzy/libcloud 809

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1155
    
----
commit 69d76ec9ea5da2abdf973f2540cea4c3a3688a53
Author: Alexander Spyrdz <al...@alxndr-ubi.syd.corp.google.com>
Date:   2017-12-15T05:35:24Z

    deploy_node has variable parity with create_node.

commit addd61e56afdd8e7edb505813d6e353c2da49715
Author: Alexander Spyrdz <al...@google.com>
Date:   2017-12-15T05:48:40Z

    Docstring update

commit d00f90dee920517dfe84e975832e3002e696a6eb
Author: Alexander Spyrdz <al...@google.com>
Date:   2017-12-15T05:50:55Z

    Refix docstring

----


---

[GitHub] libcloud pull request #1155: Fixes Apache LIBCLOUD-809

Posted by spyrdzy <gi...@git.apache.org>.

Github user spyrdzy closed the pull request at:

    https://github.com/apache/libcloud/pull/1155


---

[GitHub] libcloud pull request #1155: Fixes Apache LIBCLOUD-809

Posted by spyrdzy <gi...@git.apache.org>.

GitHub user spyrdzy reopened a pull request:

    https://github.com/apache/libcloud/pull/1155

    Fixes Apache LIBCLOUD-809

    ## Changes 
    Fixes Apache LIBCLOUD-809
    
    ### Description
    Merged variables and docstrings for deploy_node to meet features added to create_node.
    
    Reference link: https://issues.apache.org/jira/browse/LIBCLOUD-809
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [X] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/spyrdzy/libcloud 809

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1155
    
----
commit ce3d727fd7661546e4cc49a9481f0f9cde432b16
Author: Alexander Spyrdz <al...@...>
Date:   2017-12-15T05:35:24Z

    deploy_node has variable parity with create_node.

commit 0e6bd6c61754bda04906e92b1c9b4bd26b2e5fa9
Author: Alexander Spyrdz <al...@...>
Date:   2018-01-05T02:42:09Z

    Merge branch 'trunk' into 809

----


---

[GitHub] libcloud pull request #1155: Fixes Apache LIBCLOUD-809

Posted by spyrdzy <gi...@git.apache.org>.

Github user spyrdzy closed the pull request at:

    https://github.com/apache/libcloud/pull/1155


---

[GitHub] libcloud pull request #1155: Fixes Apache LIBCLOUD-809

Posted by spyrdzy <gi...@git.apache.org>.

GitHub user spyrdzy reopened a pull request:

    https://github.com/apache/libcloud/pull/1155

    Fixes Apache LIBCLOUD-809

    ## Changes 
    Fixes Apache LIBCLOUD-809
    
    ### Description
    Merged variables and docstrings for deploy_node to meet features added to create_node.
    
    Reference link: https://issues.apache.org/jira/browse/LIBCLOUD-809
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [X] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/spyrdzy/libcloud 809

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1155
    
----
commit ce3d727fd7661546e4cc49a9481f0f9cde432b16
Author: Alexander Spyrdz <al...@...>
Date:   2017-12-15T05:35:24Z

    deploy_node has variable parity with create_node.

commit 0e6bd6c61754bda04906e92b1c9b4bd26b2e5fa9
Author: Alexander Spyrdz <al...@...>
Date:   2018-01-05T02:42:09Z

    Merge branch 'trunk' into 809

----


---