You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Jens Peters <jp...@gmx.de> on 2009/05/04 20:46:28 UTC

[PATCH] Fix python testsuite issues ("Can't remove re-cache.db")

Hello there,

I looked somewhat further into the "Cannot remove <repository>" issue 
(http://svn.haxx.se/dev/archive-2009-04/0943.shtml and following) when 
running the python testsuite on my Windows box. The following patch 
fixes all "Can't remove <repos>" exceptions for me. I have still 2 other 
failures, but these have to wait for now...


Regards,
jens

[[[
Fixes some python testsuite failures
("Can't remove <path>\rep-cache.db")on Windows.

* subversion/bindings/swig/python/tests/mergeinfo.py
   (tearDown):
* subversion/bindings/swig/python/tests/wc.py
   (tearDown):
Close references to the test repository so that it can be
deleted nicely.

* subversion/bindings/swig/python/tests/ra.py
   (tearDown):
* subversion/bindings/swig/python/tests/repository.py
   (tearDown):
Override tearDown to close references to the test repository
so that it can be deleted nicely.

Patch by: jpeters7677 { at } gmx.de
]]]

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2059997

Re: [PATCH] Fix python testsuite issues ("Can't remove re-cache.db")

Posted by Jens Peters <jp...@gmx.de>.
> ======================================================================
> ERROR: test_status_editor (wc.SubversionWorkingCopyTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>     File
> "D:\develop\svn\subversion-1.6\subversion\bindings\swig\python\tests\wc.p
> y", line 162, in test_status_editor
>       editor.close_edit(edit_baton)
>     File "d:\opt\Subversion\python\libsvn\delta.py", line 458, in close_edit
>       return svn_delta_editor_invoke_close_edit(self, *args)
>     File "d:\opt\Subversion\python\libsvn\delta.py", line 677, in
> svn_delta_editor
> _invoke_close_edit
>       return apply(_delta.svn_delta_editor_invoke_close_edit, args)
> SubversionException: ("Can't check path
> 'd:\\tmp\\tmpgz7_dk\\d:\\tmp\\tmpgz7_dk'
> : The filename, directory name, or volume label syntax is incorrect.  ",
> 720123)
>
>
> ----------------------------------------------------------------------
> Ran 106 tests in 27.660s
>
> FAILED (errors=1)

Hi David,

any idea in which direction I should look to get a grip on that last 
failure?

Regards,
jens

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2195118

Re: [PATCH] Fix python testsuite issues ("Can't remove re-cache.db")

Posted by Jens Peters <jp...@gmx.de>.
On 5-5-2009 19:38, David James wrote:
> Thanks Jens. I've committed your patch in 37586.
>
> On my machine, the SWIG Python tests currently hang halfway through,
> but I can confirm that this isn't related to the patch -- Greg, could
> you take a look? The SWIG Python tests hang during the
> test_diff_editor4 test in wc.py.
>
> Cheers,
>
> David

Hi David,

Thank you for committing my patch.

Om my machine the testsuite runs now nice until the end. I switched back 
to swig 1.3.36 which resolved the earlier mentioned differences in the 
baton adresses, but I have still one failure. It looks like a path is 
added twice somwhere.



======================================================================
ERROR: test_status_editor (wc.SubversionWorkingCopyTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
   File 
"D:\develop\svn\subversion-1.6\subversion\bindings\swig\python\tests\wc.p
y", line 162, in test_status_editor
     editor.close_edit(edit_baton)
   File "d:\opt\Subversion\python\libsvn\delta.py", line 458, in close_edit
     return svn_delta_editor_invoke_close_edit(self, *args)
   File "d:\opt\Subversion\python\libsvn\delta.py", line 677, in 
svn_delta_editor
_invoke_close_edit
     return apply(_delta.svn_delta_editor_invoke_close_edit, args)
SubversionException: ("Can't check path 
'd:\\tmp\\tmpgz7_dk\\d:\\tmp\\tmpgz7_dk'
: The filename, directory name, or volume label syntax is incorrect.  ", 
720123)


----------------------------------------------------------------------
Ran 106 tests in 27.660s

FAILED (errors=1)

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2071691

Re: [PATCH] Fix python testsuite issues ("Can't remove re-cache.db")

Posted by David James <ja...@gmail.com>.
Thanks Jens. I've committed your patch in 37586.

On my machine, the SWIG Python tests currently hang halfway through,
but I can confirm that this isn't related to the patch -- Greg, could
you take a look? The SWIG Python tests hang during the
test_diff_editor4 test in wc.py.

Cheers,

David


On Mon, May 4, 2009 at 1:53 PM, Jens Peters <jp...@gmx.de> wrote:
> Uh, forgot to mention David James, sorry ..
> here is the fixed log messages:
>
> [[[
> Fixes some python testsuite failures
> ("Can't remove <path>\rep-cache.db")on Windows.
>
> * subversion/bindings/swig/python/tests/mergeinfo.py
>    (tearDown):
> * subversion/bindings/swig/python/tests/wc.py
>    (tearDown):
> Close references to the test repository so that it can be
> deleted nicely.
>
> * subversion/bindings/swig/python/tests/ra.py
>    (tearDown):
> * subversion/bindings/swig/python/tests/repository.py
>    (tearDown):
> Override tearDown to close references to the test repository
> so that it can be deleted nicely.
>
> Patch by: David James <james82 { at } gmail.com>
>           Jens Peters <jpeters7677 { at } gmx.de>
> ]]]
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2060031

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2071288


Re: [PATCH] Fix python testsuite issues ("Can't remove re-cache.db")

Posted by Jens Peters <jp...@gmx.de>.
Uh, forgot to mention David James, sorry ..
here is the fixed log messages:

[[[
Fixes some python testsuite failures
("Can't remove <path>\rep-cache.db")on Windows.

* subversion/bindings/swig/python/tests/mergeinfo.py
    (tearDown):
* subversion/bindings/swig/python/tests/wc.py
    (tearDown):
Close references to the test repository so that it can be
deleted nicely.

* subversion/bindings/swig/python/tests/ra.py
    (tearDown):
* subversion/bindings/swig/python/tests/repository.py
    (tearDown):
Override tearDown to close references to the test repository
so that it can be deleted nicely.

Patch by: David James <james82 { at } gmail.com>
           Jens Peters <jpeters7677 { at } gmx.de>
]]]

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2060031