You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2024/12/02 20:16:35 UTC
[PR] Add fallback during `[core] dag_bundle_storage_path` retrieval [airflow]
jedcunningham opened a new pull request, #44580:
URL: https://github.com/apache/airflow/pull/44580
Turns out a default of `None` doesn't actually work. And we want people to be able to use the default!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add fallback during `[core] dag_bundle_storage_path` retrieval [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #44580:
URL: https://github.com/apache/airflow/pull/44580#discussion_r1866598106
##########
airflow/dag_processing/bundles/base.py:
##########
@@ -56,7 +56,7 @@ def _dag_bundle_root_storage_path(self) -> Path:
This is the root path, shared by various bundles. Each bundle should have its own subdirectory.
"""
- if configured_location := conf.get("core", "dag_bundle_storage_path"):
+ if configured_location := conf.get("core", "dag_bundle_storage_path", fallback=None):
Review Comment:
It would work, but it feels "less right" to me. I think the right answer is to fix it so None is valid default, but that's a problem for another day I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add fallback during `[core] dag_bundle_storage_path` retrieval [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #44580:
URL: https://github.com/apache/airflow/pull/44580#discussion_r1866564648
##########
airflow/dag_processing/bundles/base.py:
##########
@@ -56,7 +56,7 @@ def _dag_bundle_root_storage_path(self) -> Path:
This is the root path, shared by various bundles. Each bundle should have its own subdirectory.
"""
- if configured_location := conf.get("core", "dag_bundle_storage_path"):
+ if configured_location := conf.get("core", "dag_bundle_storage_path", fallback=None):
Review Comment:
Do you instead want to change the following default to `""`
https://github.com/apache/airflow/blob/33bf3ede9e7d7495b68dbdeef687ca4c53b1a2e2/airflow/config_templates/config.yml#L31-L38
##########
airflow/dag_processing/bundles/base.py:
##########
@@ -56,7 +56,7 @@ def _dag_bundle_root_storage_path(self) -> Path:
This is the root path, shared by various bundles. Each bundle should have its own subdirectory.
"""
- if configured_location := conf.get("core", "dag_bundle_storage_path"):
+ if configured_location := conf.get("core", "dag_bundle_storage_path", fallback=None):
Review Comment:
```py
In [1]: from airflow.configuration import conf
In [2]: conf.get("core", "dag_bundle_storage_path")
Out[2]: ''
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add fallback during `[core] dag_bundle_storage_path` retrieval [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham merged PR #44580:
URL: https://github.com/apache/airflow/pull/44580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org