You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/22 23:58:26 UTC
[GitHub] [solr] risdenk opened a new pull request #691: SOLR-16047: Upgrade owasp dependency check plugin to 6.5.3
risdenk opened a new pull request #691:
URL: https://github.com/apache/solr/pull/691
https://issues.apache.org/jira/browse/SOLR-16047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk closed pull request #691: SOLR-16047: Upgrade owasp dependency check plugin to 6.5.3
Posted by GitBox <gi...@apache.org>.
risdenk closed pull request #691:
URL: https://github.com/apache/solr/pull/691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #691: SOLR-16047: Upgrade owasp dependency check plugin to 6.5.3
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #691:
URL: https://github.com/apache/solr/pull/691#discussion_r812502226
##########
File path: gradle/validation/owasp-dependency-check/exclusions.xml
##########
@@ -23,43 +23,32 @@
<suppressions xmlns="https://jeremylong.github.io/DependencyCheck/dependency-suppression.1.3.xsd">
<suppress>
- <notes><![CDATA[
- file name: simple-xml-safe-2.7.1.jar
- We use a safe fork that fixes this
- ]]></notes>
+ <notes><![CDATA[simple-xml-safe is a safe xml-safe fork]]></notes>
<packageUrl regex="true">^pkg:maven/com\.carrotsearch\.thirdparty/simple\-xml\-safe@.*$</packageUrl>
<cve>CVE-2017-1000190</cve>
</suppress>
<suppress>
- <notes><![CDATA[
- file name: netty-transport-native-epoll-4.1.29.Final.jar
- We only use netty as a client towards Zookeeper
- ]]></notes>
- <packageUrl regex="true">^pkg:maven/io\.netty/netty\-.*@.*$</packageUrl>
- <cpe>cpe:/a:netty:netty</cpe>
Review comment:
FWIW this was really wrong - since this is basically saying netty isn't identified as netty - which is untrue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #691: SOLR-16047: Upgrade owasp dependency check plugin to 6.5.3
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #691:
URL: https://github.com/apache/solr/pull/691#discussion_r812503186
##########
File path: gradle/validation/owasp-dependency-check/exclusions.xml
##########
@@ -23,43 +23,32 @@
<suppressions xmlns="https://jeremylong.github.io/DependencyCheck/dependency-suppression.1.3.xsd">
<suppress>
- <notes><![CDATA[
- file name: simple-xml-safe-2.7.1.jar
- We use a safe fork that fixes this
- ]]></notes>
+ <notes><![CDATA[simple-xml-safe is a safe xml-safe fork]]></notes>
<packageUrl regex="true">^pkg:maven/com\.carrotsearch\.thirdparty/simple\-xml\-safe@.*$</packageUrl>
<cve>CVE-2017-1000190</cve>
</suppress>
<suppress>
- <notes><![CDATA[
- file name: netty-transport-native-epoll-4.1.29.Final.jar
- We only use netty as a client towards Zookeeper
- ]]></notes>
- <packageUrl regex="true">^pkg:maven/io\.netty/netty\-.*@.*$</packageUrl>
- <cpe>cpe:/a:netty:netty</cpe>
+ <notes><![CDATA[apache-mime4j has different releases than apache james]]></notes>
+ <packageUrl regex="true">^pkg:maven/org\.apache\.james/apache\-mime4j.*@.*$</packageUrl>
+ <cve>CVE-2021-38542</cve>
+ <cve>CVE-2021-40110</cve>
+ <cve>CVE-2021-40111</cve>
+ <cve>CVE-2021-40525</cve>
</suppress>
<suppress>
- <notes><![CDATA[
- file name: dirgra-0.3.jar
- We will sandbox JRuby
- ]]></notes>
- <packageUrl regex="true">^pkg:maven/org\.jruby/dirgra@.*$</packageUrl>
- <cpe>cpe:/a:jruby:jruby</cpe>
+ <notes><![CDATA[apache-rat-tasks is not tasks]]></notes>
+ <packageUrl regex="true">^pkg:maven/org\.apache\.rat/apache\-rat\-tasks@.*$</packageUrl>
+ <cpe>cpe:/a:tasks:tasks</cpe>
</suppress>
<suppress>
- <notes><![CDATA[
- file name: carrot2-guava-18.0.jar
- Only used with clustering engine, and the risk is DOS attack
- ]]></notes>
- <packageUrl regex="true">^pkg:maven/org\.carrot2\.shaded/carrot2\-guava@.*$</packageUrl>
- <cpe>cpe:/a:google:guava</cpe>
+ <notes><![CDATA[zookeeper is not Jetty]]></notes>
+ <packageUrl regex="true">^pkg:maven/org\.apache\.zookeeper/zookeeper.*@.*$</packageUrl>
+ <cve>CVE-2021-28164</cve>
+ <cve>CVE-2021-34429</cve>
Review comment:
Zookeeper is being flagged for these CVEs for no good reason. We upgrade Jetty and these are Jetty CVEs - they can't be fixed from Zookeeper itself. So suppress these misflagged CVEs specifically - its impossible to do via a cpe suppression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #691: SOLR-16047: Upgrade owasp dependency check plugin to 6.5.3
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #691:
URL: https://github.com/apache/solr/pull/691#discussion_r812502366
##########
File path: gradle/validation/owasp-dependency-check/exclusions.xml
##########
@@ -23,43 +23,32 @@
<suppressions xmlns="https://jeremylong.github.io/DependencyCheck/dependency-suppression.1.3.xsd">
<suppress>
- <notes><![CDATA[
- file name: simple-xml-safe-2.7.1.jar
- We use a safe fork that fixes this
- ]]></notes>
+ <notes><![CDATA[simple-xml-safe is a safe xml-safe fork]]></notes>
<packageUrl regex="true">^pkg:maven/com\.carrotsearch\.thirdparty/simple\-xml\-safe@.*$</packageUrl>
<cve>CVE-2017-1000190</cve>
</suppress>
<suppress>
- <notes><![CDATA[
- file name: netty-transport-native-epoll-4.1.29.Final.jar
- We only use netty as a client towards Zookeeper
- ]]></notes>
- <packageUrl regex="true">^pkg:maven/io\.netty/netty\-.*@.*$</packageUrl>
- <cpe>cpe:/a:netty:netty</cpe>
+ <notes><![CDATA[apache-mime4j has different releases than apache james]]></notes>
+ <packageUrl regex="true">^pkg:maven/org\.apache\.james/apache\-mime4j.*@.*$</packageUrl>
+ <cve>CVE-2021-38542</cve>
+ <cve>CVE-2021-40110</cve>
+ <cve>CVE-2021-40111</cve>
+ <cve>CVE-2021-40525</cve>
</suppress>
<suppress>
- <notes><![CDATA[
- file name: dirgra-0.3.jar
- We will sandbox JRuby
- ]]></notes>
- <packageUrl regex="true">^pkg:maven/org\.jruby/dirgra@.*$</packageUrl>
- <cpe>cpe:/a:jruby:jruby</cpe>
Review comment:
`jruby` is no longer included so don't need this exclusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #691: SOLR-16047: Upgrade owasp dependency check plugin to 6.5.3
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #691:
URL: https://github.com/apache/solr/pull/691#issuecomment-1048324374
A ton of the Hadoop CVEs are going to be addressed in Hadoop 3.3.2 with SOLR-16039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #691: SOLR-16047: Upgrade owasp dependency check plugin to 6.5.3
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #691:
URL: https://github.com/apache/solr/pull/691#discussion_r812502749
##########
File path: gradle/validation/owasp-dependency-check/exclusions.xml
##########
@@ -23,43 +23,32 @@
<suppressions xmlns="https://jeremylong.github.io/DependencyCheck/dependency-suppression.1.3.xsd">
<suppress>
- <notes><![CDATA[
- file name: simple-xml-safe-2.7.1.jar
- We use a safe fork that fixes this
- ]]></notes>
+ <notes><![CDATA[simple-xml-safe is a safe xml-safe fork]]></notes>
<packageUrl regex="true">^pkg:maven/com\.carrotsearch\.thirdparty/simple\-xml\-safe@.*$</packageUrl>
<cve>CVE-2017-1000190</cve>
</suppress>
<suppress>
- <notes><![CDATA[
- file name: netty-transport-native-epoll-4.1.29.Final.jar
- We only use netty as a client towards Zookeeper
- ]]></notes>
- <packageUrl regex="true">^pkg:maven/io\.netty/netty\-.*@.*$</packageUrl>
- <cpe>cpe:/a:netty:netty</cpe>
+ <notes><![CDATA[apache-mime4j has different releases than apache james]]></notes>
+ <packageUrl regex="true">^pkg:maven/org\.apache\.james/apache\-mime4j.*@.*$</packageUrl>
+ <cve>CVE-2021-38542</cve>
+ <cve>CVE-2021-40110</cve>
+ <cve>CVE-2021-40111</cve>
+ <cve>CVE-2021-40525</cve>
Review comment:
There isn't an easy way to say that apache-mime4j only has certain versions. Since it is still part of Apache James, can't easily add the `cpe` suppression here. This specifically means ignore these CVEs since it is 100% clear these don't affect `apache-mime4j*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org