You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefania (JIRA)" <ji...@apache.org> on 2017/04/13 07:49:41 UTC
[jira] [Commented] (CASSANDRA-13443) V5 protocol flags decoding
broken
[ https://issues.apache.org/jira/browse/CASSANDRA-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967251#comment-15967251 ]
Stefania commented on CASSANDRA-13443:
--------------------------------------
Nice catch, +1, provided tests pass.
> V5 protocol flags decoding broken
> ---------------------------------
>
> Key: CASSANDRA-13443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13443
> Project: Cassandra
> Issue Type: Bug
> Reporter: Robert Stupp
> Assignee: Robert Stupp
> Priority: Minor
> Fix For: 3.11.0, 4.0
>
>
> Since native protocol version 5 we deserialize the flags in {{org.apache.cassandra.cql3.QueryOptions.Codec#decode}} as follows:
> {code}
> EnumSet<Flag> flags = Flag.deserialize(version.isGreaterOrEqualTo(ProtocolVersion.V5)
> ? (int)body.readUnsignedInt()
> : (int)body.readByte());
> {code}
> This works until the highest bit (0x80) is not used. {{readByte}} must be changed to {{readUnsignedByte}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)