You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Alex Newman (Created) (JIRA)" <ji...@apache.org> on 2012/01/20 21:18:40 UTC

[jira] [Created] (HBASE-5240) HBase internalscanner.next javadoc doesn't imply whether or not results are appended or not

HBase internalscanner.next javadoc doesn't imply whether or not results are appended or not
-------------------------------------------------------------------------------------------

                 Key: HBASE-5240
                 URL: https://issues.apache.org/jira/browse/HBASE-5240
             Project: HBase
          Issue Type: Bug
            Reporter: Alex Newman
            Assignee: Alex Newman


Just looking at http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/regionserver/InternalScanner.html. We don't know whether or not the results are appended to results list, or if we always clear it first.


boolean 	next(List<KeyValue> results)
          Grab the next row's worth of values.
 boolean 	next(List<KeyValue> result, int limit)
          Grab the next row's worth of values with a limit on the number of values to return.
 

Method Detail
next

boolean next(List<KeyValue> results)
             throws IOException

    Grab the next row's worth of values.

    Parameters:
        results - return output array 
    Returns:
        true if more rows exist after this one, false if scanner is done 
    Throws:
        IOException - e

next

boolean next(List<KeyValue> result,
             int limit)
             throws IOException

    Grab the next row's worth of values with a limit on the number of values to return.

    Parameters:
        result - return output array
        limit - limit on row count to get 
    Returns:
        true if more rows exist after this one, false if scanner is done 
    Throws:
        IOException - e



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5240) HBase internalscanner.next javadoc doesn't imply whether or not results are appended or not

Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Newman updated HBASE-5240:
-------------------------------

    Attachment: 0001-HBASE-5240.-HBase-internalscanner.next-javadoc-doesn.patch
    
> HBase internalscanner.next javadoc doesn't imply whether or not results are appended or not
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5240
>                 URL: https://issues.apache.org/jira/browse/HBASE-5240
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Alex Newman
>            Assignee: Alex Newman
>         Attachments: 0001-HBASE-5240.-HBase-internalscanner.next-javadoc-doesn.patch
>
>
> Just looking at http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/regionserver/InternalScanner.html. We don't know whether or not the results are appended to results list, or if we always clear it first.
> boolean 	next(List<KeyValue> results)
>           Grab the next row's worth of values.
>  boolean 	next(List<KeyValue> result, int limit)
>           Grab the next row's worth of values with a limit on the number of values to return.
>  
> Method Detail
> next
> boolean next(List<KeyValue> results)
>              throws IOException
>     Grab the next row's worth of values.
>     Parameters:
>         results - return output array 
>     Returns:
>         true if more rows exist after this one, false if scanner is done 
>     Throws:
>         IOException - e
> next
> boolean next(List<KeyValue> result,
>              int limit)
>              throws IOException
>     Grab the next row's worth of values with a limit on the number of values to return.
>     Parameters:
>         result - return output array
>         limit - limit on row count to get 
>     Returns:
>         true if more rows exist after this one, false if scanner is done 
>     Throws:
>         IOException - e

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5240) HBase internalscanner.next javadoc doesn't imply whether or not results are appended or not

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191341#comment-13191341 ] 

Hadoop QA commented on HBASE-5240:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12511522/0001-HBASE-5240.-HBase-internalscanner.next-javadoc-doesn.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -145 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestAtomicOperation
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/838//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/838//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/838//console

This message is automatically generated.
                
> HBase internalscanner.next javadoc doesn't imply whether or not results are appended or not
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5240
>                 URL: https://issues.apache.org/jira/browse/HBASE-5240
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Alex Newman
>            Assignee: Alex Newman
>         Attachments: 0001-HBASE-5240.-HBase-internalscanner.next-javadoc-doesn.patch
>
>
> Just looking at http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/regionserver/InternalScanner.html. We don't know whether or not the results are appended to results list, or if we always clear it first.
> boolean 	next(List<KeyValue> results)
>           Grab the next row's worth of values.
>  boolean 	next(List<KeyValue> result, int limit)
>           Grab the next row's worth of values with a limit on the number of values to return.
>  
> Method Detail
> next
> boolean next(List<KeyValue> results)
>              throws IOException
>     Grab the next row's worth of values.
>     Parameters:
>         results - return output array 
>     Returns:
>         true if more rows exist after this one, false if scanner is done 
>     Throws:
>         IOException - e
> next
> boolean next(List<KeyValue> result,
>              int limit)
>              throws IOException
>     Grab the next row's worth of values with a limit on the number of values to return.
>     Parameters:
>         result - return output array
>         limit - limit on row count to get 
>     Returns:
>         true if more rows exist after this one, false if scanner is done 
>     Throws:
>         IOException - e

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5240) HBase internalscanner.next javadoc doesn't imply whether or not results are appended or not

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191328#comment-13191328 ] 

jiraposter@reviews.apache.org commented on HBASE-5240:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3594/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

Just looking at http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/regionserver/InternalScanner.html. We don't know whether or not the results are appended to results list, or if we always clear it first.

boolean next(List<KeyValue> results)
Grab the next row's worth of values.
boolean next(List<KeyValue> result, int limit)
Grab the next row's worth of values with a limit on the number of values to return.

Method Detail
next

boolean next(List<KeyValue> results)
throws IOException

Grab the next row's worth of values.

Parameters:
results - return output array 
Returns:
true if more rows exist after this one, false if scanner is done 
Throws:
IOException - e

next

boolean next(List<KeyValue> result,
int limit)
throws IOException

Grab the next row's worth of values with a limit on the number of values to return.

Parameters:
result - return output array
limit - limit on row count to get 
Returns:
true if more rows exist after this one, false if scanner is done 
Throws:
IOException - e


This addresses bug HBASE-5240.
    https://issues.apache.org/jira/browse/HBASE-5240


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/regionserver/InternalScanner.java 0f5f36c 

Diff: https://reviews.apache.org/r/3594/diff


Testing
-------


Thanks,

Alex


                
> HBase internalscanner.next javadoc doesn't imply whether or not results are appended or not
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5240
>                 URL: https://issues.apache.org/jira/browse/HBASE-5240
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Alex Newman
>            Assignee: Alex Newman
>         Attachments: 0001-HBASE-5240.-HBase-internalscanner.next-javadoc-doesn.patch
>
>
> Just looking at http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/regionserver/InternalScanner.html. We don't know whether or not the results are appended to results list, or if we always clear it first.
> boolean 	next(List<KeyValue> results)
>           Grab the next row's worth of values.
>  boolean 	next(List<KeyValue> result, int limit)
>           Grab the next row's worth of values with a limit on the number of values to return.
>  
> Method Detail
> next
> boolean next(List<KeyValue> results)
>              throws IOException
>     Grab the next row's worth of values.
>     Parameters:
>         results - return output array 
>     Returns:
>         true if more rows exist after this one, false if scanner is done 
>     Throws:
>         IOException - e
> next
> boolean next(List<KeyValue> result,
>              int limit)
>              throws IOException
>     Grab the next row's worth of values with a limit on the number of values to return.
>     Parameters:
>         result - return output array
>         limit - limit on row count to get 
>     Returns:
>         true if more rows exist after this one, false if scanner is done 
>     Throws:
>         IOException - e

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5240) HBase internalscanner.next javadoc doesn't imply whether or not results are appended or not

Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Newman updated HBASE-5240:
-------------------------------

    Status: Patch Available  (was: Open)
    
> HBase internalscanner.next javadoc doesn't imply whether or not results are appended or not
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5240
>                 URL: https://issues.apache.org/jira/browse/HBASE-5240
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Alex Newman
>            Assignee: Alex Newman
>         Attachments: 0001-HBASE-5240.-HBase-internalscanner.next-javadoc-doesn.patch
>
>
> Just looking at http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/regionserver/InternalScanner.html. We don't know whether or not the results are appended to results list, or if we always clear it first.
> boolean 	next(List<KeyValue> results)
>           Grab the next row's worth of values.
>  boolean 	next(List<KeyValue> result, int limit)
>           Grab the next row's worth of values with a limit on the number of values to return.
>  
> Method Detail
> next
> boolean next(List<KeyValue> results)
>              throws IOException
>     Grab the next row's worth of values.
>     Parameters:
>         results - return output array 
>     Returns:
>         true if more rows exist after this one, false if scanner is done 
>     Throws:
>         IOException - e
> next
> boolean next(List<KeyValue> result,
>              int limit)
>              throws IOException
>     Grab the next row's worth of values with a limit on the number of values to return.
>     Parameters:
>         result - return output array
>         limit - limit on row count to get 
>     Returns:
>         true if more rows exist after this one, false if scanner is done 
>     Throws:
>         IOException - e

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira