You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by mb...@apache.org on 2016/09/18 15:00:55 UTC
svn commit: r1761332 -
/ofbiz/trunk/applications/commonext/widget/SystemInfoForms.xml
Author: mbrohl
Date: Sun Sep 18 15:00:55 2016
New Revision: 1761332
URL: http://svn.apache.org/viewvc?rev=1761332&view=rev
Log:
Improved: Maximise the utilisation of common labels in various commonext forms.
(OFBIZ-8121)
I've slightly modified the patch to only change the button titles.
Thanks: Pierre Smits for reporting and providing the patch.
Modified:
ofbiz/trunk/applications/commonext/widget/SystemInfoForms.xml
Modified: ofbiz/trunk/applications/commonext/widget/SystemInfoForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/commonext/widget/SystemInfoForms.xml?rev=1761332&r1=1761331&r2=1761332&view=diff
==============================================================================
--- ofbiz/trunk/applications/commonext/widget/SystemInfoForms.xml (original)
+++ ofbiz/trunk/applications/commonext/widget/SystemInfoForms.xml Sun Sep 18 15:00:55 2016
@@ -40,7 +40,7 @@ under the License.
<field name="internalNotes"><check/></field>
<field name="telephoneForwards"><check/></field>
<field name="taskAssignment"><check/></field>
- <field name="updateButton"><submit/></field>
+ <field name="updateButton" title="${uiLabelMap.CommonUpdate}"><submit/></field>
</form>
<form name="SystemInfoStatus" type="list" list-name="systemInfoStatus"
@@ -53,6 +53,6 @@ under the License.
<field name="noteParty"><text/></field>
<field name="moreInfoUrl"><text size="50"/></field>
<field name="noteInfo"><text size="50"/></field>
- <field name="createButton"><submit/></field>
+ <field name="createButton" title="${uiLabelMap.CommonCreate}"><submit/></field>
</form>
</forms>
Re: svn commit: r1761332 -
/ofbiz/trunk/applications/commonext/widget/SystemInfoForms.xml
Posted by Nicolas Malin <ni...@nereide.fr>.
No worries Michael, thanks for your reactivity
Nicolas
Le 18/09/2016 � 17:36, Michael Brohl a �crit :
> Hi Nicolas,
>
> you are right, that change is also not necessary. Seems I was confused
> while reviewing the other changes in the referenced Jira and the
> related subtasks.
>
> I will revert the commit.
>
> Thanks for taking care,
>
> Michael
>
>
> Am 18.09.16 um 17:21 schrieb Nicolas Malin:
>> Hi Michael
>>> <field name="taskAssignment"><check/></field>
>>> - <field name="updateButton"><submit/></field>
>>> + <field name="updateButton"
>>> title="${uiLabelMap.CommonUpdate}"><submit/></field>
>>> </form>
>> I didn't understand why you added this title. Normally the title
>> resolution need came from
>> <property key="FormFieldTitle_updateButton">. For me it's a
>> regression and after checked the Jira OFBIZ-8121 I didn't see a valid
>> reason
>>
>> Can you explain me more why ?
>>> <field name="noteInfo"><text size="50"/></field>
>>> - <field name="createButton"><submit/></field>
>>> + <field name="createButton"
>>> title="${uiLabelMap.CommonCreate}"><submit/></field>
>>> </form>
>>> </forms>
>>>
>> seem here
>>
>> Nicoals
>
>
Re: svn commit: r1761332 -
/ofbiz/trunk/applications/commonext/widget/SystemInfoForms.xml
Posted by Michael Brohl <mi...@ecomify.de>.
Hi Nicolas,
you are right, that change is also not necessary. Seems I was confused
while reviewing the other changes in the referenced Jira and the related
subtasks.
I will revert the commit.
Thanks for taking care,
Michael
Am 18.09.16 um 17:21 schrieb Nicolas Malin:
> Hi Michael
>> <field name="taskAssignment"><check/></field>
>> - <field name="updateButton"><submit/></field>
>> + <field name="updateButton"
>> title="${uiLabelMap.CommonUpdate}"><submit/></field>
>> </form>
> I didn't understand why you added this title. Normally the title
> resolution need came from
> <property key="FormFieldTitle_updateButton">. For me it's a
> regression and after checked the Jira OFBIZ-8121 I didn't see a valid
> reason
>
> Can you explain me more why ?
>> <field name="noteInfo"><text size="50"/></field>
>> - <field name="createButton"><submit/></field>
>> + <field name="createButton"
>> title="${uiLabelMap.CommonCreate}"><submit/></field>
>> </form>
>> </forms>
>>
> seem here
>
> Nicoals
Re: svn commit: r1761332 -
/ofbiz/trunk/applications/commonext/widget/SystemInfoForms.xml
Posted by Nicolas Malin <ni...@nereide.fr>.
Hi Michael
> <field name="taskAssignment"><check/></field>
> - <field name="updateButton"><submit/></field>
> + <field name="updateButton" title="${uiLabelMap.CommonUpdate}"><submit/></field>
> </form>
I didn't understand why you added this title. Normally the title
resolution need came from
<property key="FormFieldTitle_updateButton">. For me it's a
regression and after checked the Jira OFBIZ-8121 I didn't see a valid reason
Can you explain me more why ?
> <field name="noteInfo"><text size="50"/></field>
> - <field name="createButton"><submit/></field>
> + <field name="createButton" title="${uiLabelMap.CommonCreate}"><submit/></field>
> </form>
> </forms>
>
seem here
Nicoals