You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/10/19 12:01:38 UTC
[GitHub] [ignite] timoninmaxim opened a new pull request #8367: WIP: check tests are not in suites
timoninmaxim opened a new pull request #8367:
URL: https://github.com/apache/ignite/pull/8367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r530375323
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreIgniteSpringTestSuite.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtMultiBackupTest;
+import org.apache.ignite.startup.cmdline.GridCommandLineLoaderTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Spring tests.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCommandLineLoaderTest.class,
+
+ GridCacheDhtMultiBackupTest.class
+})
+public class CoreIgniteSpringTestSuite {
Review comment:
You may just move these tests' invocation to IgniteCacheQuerySelfTestSuiteN/IgniteSpringTestSuite and avoid problems. Can you do that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on pull request #8367: IGNITE-13512 Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#issuecomment-770700414
Hi @alamar , could you please review PR? I've changed logic of check, now it collects info about tests and suites from all modules, then start a check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r531236299
##########
File path: modules/cassandra/serializers/src/test/java/org/apache/ignite/tests/SerializerSuite.java
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.tests;
+
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+@RunWith(Suite.class)
Review comment:
Added javadocs for all test suites.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r526167448
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreIgniteSpringTestSuite.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtMultiBackupTest;
+import org.apache.ignite.startup.cmdline.GridCommandLineLoaderTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Spring tests.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCommandLineLoaderTest.class,
+
+ GridCacheDhtMultiBackupTest.class
+})
+public class CoreIgniteSpringTestSuite {
Review comment:
> Then we can update TC
I'll prepare suites that can be easily moved to original (related to tests) module. After this discuss what to do with others.
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreIgniteSpringTestSuite.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtMultiBackupTest;
+import org.apache.ignite.startup.cmdline.GridCommandLineLoaderTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Spring tests.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCommandLineLoaderTest.class,
+
+ GridCacheDhtMultiBackupTest.class
+})
+public class CoreIgniteSpringTestSuite {
Review comment:
> Then we can update TC
I'll prepare suites that can be easily moved to original (related to tests) module. After this discuss what to do with others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r526157435
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteBinaryMetadataUpdateNodeRestartTest.java
##########
@@ -47,6 +48,7 @@
/**
*
*/
+@Ignore("IGNITE-4768, IGNITE-9214")
Review comment:
Added csv jira urls for all tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r517884373
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteBinaryMetadataUpdateNodeRestartTest.java
##########
@@ -47,6 +48,7 @@
/**
*
*/
+@Ignore("IGNITE-4768, IGNITE-9214")
Review comment:
@alamar,
> please choose a single most relevant ticket
disagree here, more hints = more chances to have this done in future
> put the complete JIRA URL
+1 here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: IGNITE-13512 Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r563713671
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreIgniteSpringTestSuite.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtMultiBackupTest;
+import org.apache.ignite.startup.cmdline.GridCommandLineLoaderTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Spring tests.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCommandLineLoaderTest.class,
+
+ GridCacheDhtMultiBackupTest.class
+})
+public class CoreIgniteSpringTestSuite {
Review comment:
Now there is no need to moving test and suites. Now check aggregates test and suites info over all modules and then checks aggregation result.
##########
File path: modules/indexing/src/test/java/org/apache/ignite/testsuites/IgniteCacheQuerySelfTestSuite3.java
##########
@@ -48,34 +26,7 @@
*/
@RunWith(Suite.class)
@Suite.SuiteClasses({
- CacheContinuousQueryBufferLimitTest.class,
-
- GridCacheContinuousQueryNodesFilteringTest.class,
- GridCacheContinuousQueryPartitionTxOneNodeTest.class,
- CacheContinuousWithTransformerReplicatedSelfTest.class,
- CacheContinuousWithTransformerClientSelfTest.class,
- CacheContinuousQueryExecuteInPrimaryTest.class,
- IgniteCacheContinuousQueryNoUnsubscribeTest.class,
-
- ClientReconnectContinuousQueryTest.class,
- IgniteCacheContinuousQueryReconnectTest.class,
- IgniteCacheContinuousQueryClientTxReconnectTest.class,
- IgniteCacheContinuousQueryClientReconnectTest.class,
-
- GridCacheContinuousQueryAtomicSelfTest.class,
- GridCacheContinuousQueryAtomicNearEnabledSelfTest.class,
- GridCacheContinuousQueryPartitionedSelfTest.class,
- GridCacheContinuousQueryReplicatedSelfTest.class,
-
- CacheContinuousQueryFactoryAsyncFilterRandomOperationTest.class,
- CacheContinuousBatchForceServerModeAckTest.class,
- ContinuousQueryReassignmentTest.class,
- CacheContinuousQueryConcurrentPartitionUpdateTest.class,
-
- CacheContinuousQueryCounterPartitionedAtomicTest.class,
- CacheContinuousQueryCounterPartitionedTxTest.class,
- CacheContinuousQueryCounterReplicatedAtomicTest.class,
- CacheContinuousQueryCounterReplicatedTxTest.class
+ CoreIgniteCacheQuerySelfTestSuite3.class
Review comment:
Back test suite to original state.
##########
File path: modules/core/src/test/java/org/apache/ignite/client/CoreClientTestSuite.java
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+import org.apache.ignite.internal.IgniteClientFailuresTest;
+import org.apache.ignite.internal.client.thin.CacheAsyncTest;
+import org.apache.ignite.internal.client.thin.ClusterApiTest;
+import org.apache.ignite.internal.client.thin.ClusterGroupTest;
+import org.apache.ignite.internal.client.thin.ComputeTaskTest;
+import org.apache.ignite.internal.client.thin.ReliableChannelTest;
+import org.apache.ignite.internal.client.thin.ServicesTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessDiscoveryTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessResourceReleaseTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessStableTopologyTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessUnstableTopologyTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Tests for Java thin client.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ ClientConfigurationTest.class,
+ ClientCacheConfigurationTest.class,
+ FunctionalTest.class,
+ IgniteBinaryTest.class,
+ LoadTest.class,
+ ReliabilityTest.class,
+ ReliabilityTestAsync.class,
+ ReliabilityTestPartitionAware.class,
+ ReliabilityTestPartitionAwareAsync.class,
+ SslParametersTest.class,
+ ConnectionTest.class,
+ ConnectToStartingNodeTest.class,
+ AsyncChannelTest.class,
+ ComputeTaskTest.class,
+ ClusterApiTest.class,
+ ClusterGroupTest.class,
+ ServicesTest.class,
+ ThinClientPartitionAwarenessStableTopologyTest.class,
+ ThinClientPartitionAwarenessUnstableTopologyTest.class,
+ ThinClientPartitionAwarenessResourceReleaseTest.class,
+ ThinClientPartitionAwarenessDiscoveryTest.class,
+ CacheAsyncTest.class,
+ ReliableChannelTest.class,
+ IgniteClientFailuresTest.class
+})
+public class CoreClientTestSuite {
Review comment:
Removed. ClientTestSuite is restored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r526157901
##########
File path: modules/core/src/test/java/org/apache/ignite/loadtests/communication/GridIoManagerBenchmark0.java
##########
@@ -44,13 +44,15 @@
import org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Ignore;
import org.junit.Test;
import static org.apache.ignite.internal.managers.communication.GridIoPolicy.PUBLIC_POOL;
/**
*
*/
+@Ignore("Benchmark")
Review comment:
Added jira url and comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r526058327
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreIgniteSpringTestSuite.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtMultiBackupTest;
+import org.apache.ignite.startup.cmdline.GridCommandLineLoaderTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Spring tests.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCommandLineLoaderTest.class,
+
+ GridCacheDhtMultiBackupTest.class
+})
+public class CoreIgniteSpringTestSuite {
Review comment:
There is an issue. Those tests are not lost. But they are implemented in core module, but suite is in spring module. The check I've developed can't understand it. So this is a reason. Then I create suites with Core prefix, and put tests to them, then replaced tests in a suite in spring module with link to the new CoreSuite.
I don't know what is a right way to do with such tests. But moving them to the LostAndFound suite is incorrect way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r526158073
##########
File path: modules/tools/src/main/java/org/apache/ignite/tools/surefire/testsuites/CheckAllTestsInSuites.java
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.tools.surefire.testsuites;
+
+import java.lang.reflect.Modifier;
+import java.util.HashSet;
+import java.util.Set;
+import org.junit.Ignore;
+import org.junit.Test;
+import org.junit.runner.Description;
+import org.junit.runner.Request;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Suite;
+
+/** Checks that all test classes are part of any suite. */
+public class CheckAllTestsInSuites {
+ /** List of test classes. Input of the test. */
+ static Iterable<Class<?>> testClasses;
+
+ /** */
+ @Test
+ public void check() {
+ Set<Class<?>> suitedTestClasses = new HashSet<>();
+ Set<Class<?>> allTestClasses = new HashSet<>();
+ Set<Class<?>> suites = new HashSet<>();
+
+ // Workaround to handle cases when a class has descenders and it's OK to skip the base class.
+ // Also it works for DynamicSuite that can use a base class to create new test classes with reflection.
+ Set<Class<?>> superClasses = new HashSet<>();
+
+ for (Class<?> clazz: testClasses) {
Review comment:
fixed
##########
File path: modules/tools/src/main/java/org/apache/ignite/tools/surefire/testsuites/CheckAllTestsInSuites.java
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.tools.surefire.testsuites;
+
+import java.lang.reflect.Modifier;
+import java.util.HashSet;
+import java.util.Set;
+import org.junit.Ignore;
+import org.junit.Test;
+import org.junit.runner.Description;
+import org.junit.runner.Request;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Suite;
+
+/** Checks that all test classes are part of any suite. */
+public class CheckAllTestsInSuites {
+ /** List of test classes. Input of the test. */
+ static Iterable<Class<?>> testClasses;
+
+ /** */
+ @Test
+ public void check() {
+ Set<Class<?>> suitedTestClasses = new HashSet<>();
+ Set<Class<?>> allTestClasses = new HashSet<>();
+ Set<Class<?>> suites = new HashSet<>();
+
+ // Workaround to handle cases when a class has descenders and it's OK to skip the base class.
+ // Also it works for DynamicSuite that can use a base class to create new test classes with reflection.
+ Set<Class<?>> superClasses = new HashSet<>();
+
+ for (Class<?> clazz: testClasses) {
+ if (Modifier.isAbstract(clazz.getModifiers()))
+ continue;
+
+ if (clazz.getAnnotation(Ignore.class) != null)
+ continue;
+
+ Description desc = Request.aClass(clazz).getRunner().getDescription();
+
+ if (isTestClass(desc)) {
+ allTestClasses.add(clazz);
+ superClasses.add(clazz.getSuperclass());
+ }
+ else
+ processSuite(desc, suitedTestClasses, suites, superClasses);
+ }
+
+ allTestClasses.removeAll(suitedTestClasses);
+ allTestClasses.removeAll(superClasses);
+
+ if (!allTestClasses.isEmpty()) {
+ StringBuilder builder = new StringBuilder("All test classes must be include in any test suite.")
+ .append("\nList of non-suited classes (")
+ .append(allTestClasses.size())
+ .append(" items):\n");
+
+ for (Class<?> c: allTestClasses)
+ builder.append("\t").append(c.getName()).append("\n");
+
+ throw new AssertionError(builder.toString());
+ }
+ }
+
+ /**
+ * Recursively hadnle suites - mark all test classes as suited.
+ */
+ private void processSuite(Description suite, Set<Class<?>> suitedClasses,
+ Set<Class<?>> suites, Set<Class<?>> superClasses) {
+ suites.add(suite.getTestClass());
+
+ for (Description desc: suite.getChildren()) {
+ if (!isTestClass(desc))
+ processSuite(desc, suitedClasses, suites, superClasses);
+ else {
+ suitedClasses.add(desc.getTestClass());
+ superClasses.add(desc.getTestClass().getSuperclass());
+ }
+ }
+ }
+
+ /**
+ * Check whether class is a test class or a suite.
+ *
+ * Suite classes are marked with RunWith annotation and value of it is a descender of Suite.class.
+ * For scala tests suite must be inherited from {@link org.scalatest.Suites} class.
+ * Exclusion of the rule is Parameterized.class, so classes are marked with it are test classes.
+ */
+ private boolean isTestClass(Description desc) {
+ RunWith runWith = desc.getAnnotation(RunWith.class);
+
+ return runWith == null
+ || runWith.value().equals(Parameterized.class)
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on pull request #8367: IGNITE-13512 Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#issuecomment-773328926
Hi @alamar! I fixed comments, travis passed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r526157435
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteBinaryMetadataUpdateNodeRestartTest.java
##########
@@ -47,6 +48,7 @@
/**
*
*/
+@Ignore("IGNITE-4768, IGNITE-9214")
Review comment:
Added csv jira urls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r526157901
##########
File path: modules/core/src/test/java/org/apache/ignite/loadtests/communication/GridIoManagerBenchmark0.java
##########
@@ -44,13 +44,15 @@
import org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Ignore;
import org.junit.Test;
import static org.apache.ignite.internal.managers.communication.GridIoPolicy.PUBLIC_POOL;
/**
*
*/
+@Ignore("Benchmark")
Review comment:
Added jira url and comment for all such tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: IGNITE-13512 Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r565335865
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreZookeeperDiscoverySpiTestSuite3.java
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.datastructures.IgniteClientDataStructuresTest;
+import org.apache.ignite.internal.processors.cache.datastructures.partitioned.GridCachePartitionedNodeRestartTxSelfTest;
+import org.apache.ignite.internal.processors.cache.datastructures.partitioned.GridCachePartitionedSequenceApiSelfTest;
+import org.apache.ignite.internal.processors.cache.datastructures.replicated.GridCacheReplicatedSequenceApiSelfTest;
+import org.apache.ignite.internal.processors.cache.distributed.replicated.GridCacheReplicatedNodeRestartSelfTest;
+import org.apache.ignite.internal.processors.cache.multijvm.GridCacheAtomicMultiJvmFullApiSelfTest;
+import org.apache.ignite.internal.processors.cache.multijvm.GridCachePartitionedMultiJvmFullApiSelfTest;
+import org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryLongP2PTest;
+import org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryOperationP2PTest;
+import org.apache.ignite.internal.processors.continuous.GridEventConsumeSelfTest;
+import org.apache.ignite.p2p.GridP2PContinuousDeploymentSelfTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCacheReplicatedNodeRestartSelfTest.class,
+ GridEventConsumeSelfTest.class,
+ GridCachePartitionedNodeRestartTxSelfTest.class,
+ IgniteClientDataStructuresTest.class,
+ GridCacheReplicatedSequenceApiSelfTest.class,
+ GridCachePartitionedSequenceApiSelfTest.class,
+ GridCacheAtomicMultiJvmFullApiSelfTest.class,
+ GridCachePartitionedMultiJvmFullApiSelfTest.class,
+ GridP2PContinuousDeploymentSelfTest.class,
+ CacheContinuousQueryOperationP2PTest.class,
+ CacheContinuousQueryLongP2PTest.class,
+})
+public class CoreZookeeperDiscoverySpiTestSuite3 {
Review comment:
Revert all changes to ZK suites.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r525148153
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteBinaryMetadataUpdateNodeRestartTest.java
##########
@@ -47,6 +48,7 @@
/**
*
*/
+@Ignore("IGNITE-4768, IGNITE-9214")
Review comment:
Do we support more than one JIRA URL in our TC/MTCGA tooling?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r517888542
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreIgniteSpringTestSuite.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtMultiBackupTest;
+import org.apache.ignite.startup.cmdline.GridCommandLineLoaderTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Spring tests.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCommandLineLoaderTest.class,
+
+ GridCacheDhtMultiBackupTest.class
+})
+public class CoreIgniteSpringTestSuite {
Review comment:
@alamar,
My proposal is to have a single "LostAndFound" suite for such tests.
And we may (should) relocate them (from this suite) at separate issues.
For sure, we should create a special TC task for this suite and remove it on work done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r531231540
##########
File path: modules/core/src/test/java/org/apache/ignite/suites/CoreIgniteBinaryCacheQueryTestSuite.java
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.suites;
+
+import org.apache.ignite.internal.metric.SystemViewSelfTest;
+import org.apache.ignite.internal.processors.cache.GridCacheQueryIndexingDisabledSelfTest;
+import org.apache.ignite.internal.processors.cache.GridCacheQueryInternalKeysSelfTest;
+import org.apache.ignite.internal.processors.cache.GridCacheQuerySqlFieldInlineSizeSelfTest;
+import org.apache.ignite.internal.processors.cache.IgniteCacheBinaryObjectsScanSelfTest;
+import org.apache.ignite.internal.processors.cache.IgniteCacheBinaryObjectsScanWithEventsSelfTest;
+import org.apache.ignite.internal.processors.cache.query.CacheDataPageScanQueryTest;
+import org.apache.ignite.internal.processors.cache.query.CacheScanQueryFailoverTest;
+import org.apache.ignite.internal.processors.cache.query.GridCacheQueryTransformerSelfTest;
+import org.apache.ignite.internal.processors.cache.query.GridCircularQueueTest;
+import org.apache.ignite.internal.processors.cache.query.IgniteCacheQueryCacheDestroySelfTest;
+import org.apache.ignite.internal.processors.cache.query.IndexingSpiQuerySelfTest;
+import org.apache.ignite.internal.processors.cache.query.IndexingSpiQueryTxSelfTest;
+import org.apache.ignite.internal.processors.cache.query.IndexingSpiQueryWithH2IndexingSelfTest;
+import org.apache.ignite.internal.sql.SqlParserBulkLoadSelfTest;
+import org.apache.ignite.internal.sql.SqlParserCreateIndexSelfTest;
+import org.apache.ignite.internal.sql.SqlParserDropIndexSelfTest;
+import org.apache.ignite.internal.sql.SqlParserKillQuerySelfTest;
+import org.apache.ignite.internal.sql.SqlParserMultiStatementSelfTest;
+import org.apache.ignite.internal.sql.SqlParserSetStreamingSelfTest;
+import org.apache.ignite.internal.sql.SqlParserTransactionalKeywordsSelfTest;
+import org.apache.ignite.internal.sql.SqlParserUserSelfTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Test suite for cache queries.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ SqlParserCreateIndexSelfTest.class,
+ SqlParserDropIndexSelfTest.class,
+ SqlParserTransactionalKeywordsSelfTest.class,
+ SqlParserBulkLoadSelfTest.class,
+ SqlParserSetStreamingSelfTest.class,
+ SqlParserKillQuerySelfTest.class,
+ SqlParserMultiStatementSelfTest.class,
+
+ GridCacheQueryInternalKeysSelfTest.class,
+ GridCacheQueryTransformerSelfTest.class,
+ CacheScanQueryFailoverTest.class,
+ CacheDataPageScanQueryTest.class,
+ IndexingSpiQuerySelfTest.class,
+ IndexingSpiQueryTxSelfTest.class,
+
+ GridCircularQueueTest.class,
+ IndexingSpiQueryWithH2IndexingSelfTest.class,
+
+ GridCacheQueryIndexingDisabledSelfTest.class,
+ IgniteCacheQueryCacheDestroySelfTest.class,
+ GridCacheQuerySqlFieldInlineSizeSelfTest.class,
+ SqlParserUserSelfTest.class,
+ IgniteCacheBinaryObjectsScanSelfTest.class,
+ IgniteCacheBinaryObjectsScanWithEventsSelfTest.class,
+ SystemViewSelfTest.class
+})
+public class CoreIgniteBinaryCacheQueryTestSuite {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r530460154
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteBinaryMetadataUpdateNodeRestartTest.java
##########
@@ -47,6 +48,7 @@
/**
*
*/
+@Ignore("IGNITE-4768, IGNITE-9214")
Review comment:
Create a jira ticket for the display: https://issues.apache.org/jira/browse/IGNITE-13762
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r517889158
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreZookeeperDiscoverySpiTestSuite3.java
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.datastructures.IgniteClientDataStructuresTest;
+import org.apache.ignite.internal.processors.cache.datastructures.partitioned.GridCachePartitionedNodeRestartTxSelfTest;
+import org.apache.ignite.internal.processors.cache.datastructures.partitioned.GridCachePartitionedSequenceApiSelfTest;
+import org.apache.ignite.internal.processors.cache.datastructures.replicated.GridCacheReplicatedSequenceApiSelfTest;
+import org.apache.ignite.internal.processors.cache.distributed.replicated.GridCacheReplicatedNodeRestartSelfTest;
+import org.apache.ignite.internal.processors.cache.multijvm.GridCacheAtomicMultiJvmFullApiSelfTest;
+import org.apache.ignite.internal.processors.cache.multijvm.GridCachePartitionedMultiJvmFullApiSelfTest;
+import org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryLongP2PTest;
+import org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryOperationP2PTest;
+import org.apache.ignite.internal.processors.continuous.GridEventConsumeSelfTest;
+import org.apache.ignite.p2p.GridP2PContinuousDeploymentSelfTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCacheReplicatedNodeRestartSelfTest.class,
+ GridEventConsumeSelfTest.class,
+ GridCachePartitionedNodeRestartTxSelfTest.class,
+ IgniteClientDataStructuresTest.class,
+ GridCacheReplicatedSequenceApiSelfTest.class,
+ GridCachePartitionedSequenceApiSelfTest.class,
+ GridCacheAtomicMultiJvmFullApiSelfTest.class,
+ GridCachePartitionedMultiJvmFullApiSelfTest.class,
+ GridP2PContinuousDeploymentSelfTest.class,
+ CacheContinuousQueryOperationP2PTest.class,
+ CacheContinuousQueryLongP2PTest.class,
+})
+public class CoreZookeeperDiscoverySpiTestSuite3 {
Review comment:
@alamar,
The same proposal here (to have the "LostAndFound" suite).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r526055434
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteBinaryMetadataUpdateNodeRestartTest.java
##########
@@ -47,6 +48,7 @@
/**
*
*/
+@Ignore("IGNITE-4768, IGNITE-9214")
Review comment:
I found that there are cases with comma separated list of links. For example `PageEvictionTouchOrderTest.testTouchOrderWithFairFifoEvictionMvccTxReplicated`. But MTCGA shows only first ticket. Also I tried to find some tests with double @Ignore annotation, but there are no such cases.
Looks like we should continue the practice, use csv for such things. Also MTCGA should display them correctly, I can create a ticket for that.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on pull request #8367: IGNITE-13512 Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#issuecomment-773328926
Hi @alamar! I fixed comments, travis passed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r517886143
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheMultithreadedFailoverAbstractTest.java
##########
@@ -69,6 +70,7 @@
/**
* Base test for all multithreaded cache scenarios w/ and w/o failover.
*/
+@Ignore("FAILED! Abstract")
Review comment:
@alamar,
As @timoninmaxim mentioned in the email such classes have no inheritors.
I've rechecked for this class and may confirm this is true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8367: IGNITE-13512 Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r569522714
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheOnCopyFlagLocalSelfTest.java
##########
@@ -19,13 +19,16 @@
import org.apache.ignite.cache.CacheAtomicityMode;
import org.apache.ignite.cache.CacheMode;
+import org.junit.Ignore;
import static org.apache.ignite.cache.CacheAtomicityMode.ATOMIC;
import static org.apache.ignite.cache.CacheMode.LOCAL;
/**
* Tests {@link org.apache.ignite.cache.CacheInterceptor}.
*/
+// GG-11141.
Review comment:
Here in the next 4 files: we do not need this comment since we do not have such ticket in Apache Ignite trackers. IGNITE-9214 is enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r517884373
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteBinaryMetadataUpdateNodeRestartTest.java
##########
@@ -47,6 +48,7 @@
/**
*
*/
+@Ignore("IGNITE-4768, IGNITE-9214")
Review comment:
@alamar,
``` please choose a single most relevant ticket```
disagree here, more hints = more chances to have this done in future
```put the complete JIRA URL```
+1 here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r525147640
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheMultithreadedFailoverAbstractTest.java
##########
@@ -69,6 +70,7 @@
/**
* Base test for all multithreaded cache scenarios w/ and w/o failover.
*/
+@Ignore("FAILED! Abstract")
Review comment:
Let's un-abstract it if it does not have inheritors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
ivandasch commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r525314384
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreZookeeperDiscoverySpiTestSuite3.java
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.datastructures.IgniteClientDataStructuresTest;
+import org.apache.ignite.internal.processors.cache.datastructures.partitioned.GridCachePartitionedNodeRestartTxSelfTest;
+import org.apache.ignite.internal.processors.cache.datastructures.partitioned.GridCachePartitionedSequenceApiSelfTest;
+import org.apache.ignite.internal.processors.cache.datastructures.replicated.GridCacheReplicatedSequenceApiSelfTest;
+import org.apache.ignite.internal.processors.cache.distributed.replicated.GridCacheReplicatedNodeRestartSelfTest;
+import org.apache.ignite.internal.processors.cache.multijvm.GridCacheAtomicMultiJvmFullApiSelfTest;
+import org.apache.ignite.internal.processors.cache.multijvm.GridCachePartitionedMultiJvmFullApiSelfTest;
+import org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryLongP2PTest;
+import org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryOperationP2PTest;
+import org.apache.ignite.internal.processors.continuous.GridEventConsumeSelfTest;
+import org.apache.ignite.p2p.GridP2PContinuousDeploymentSelfTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCacheReplicatedNodeRestartSelfTest.class,
+ GridEventConsumeSelfTest.class,
+ GridCachePartitionedNodeRestartTxSelfTest.class,
+ IgniteClientDataStructuresTest.class,
+ GridCacheReplicatedSequenceApiSelfTest.class,
+ GridCachePartitionedSequenceApiSelfTest.class,
+ GridCacheAtomicMultiJvmFullApiSelfTest.class,
+ GridCachePartitionedMultiJvmFullApiSelfTest.class,
+ GridP2PContinuousDeploymentSelfTest.class,
+ CacheContinuousQueryOperationP2PTest.class,
+ CacheContinuousQueryLongP2PTest.class,
+})
+public class CoreZookeeperDiscoverySpiTestSuite3 {
Review comment:
BTW, We have 3 zk suites, that have non-zk tests and only 1 specific zk suite. Why just suite number 3 is affected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r525149795
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreIgniteSpringTestSuite.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtMultiBackupTest;
+import org.apache.ignite.startup.cmdline.GridCommandLineLoaderTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Spring tests.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCommandLineLoaderTest.class,
+
+ GridCacheDhtMultiBackupTest.class
+})
+public class CoreIgniteSpringTestSuite {
Review comment:
We already have LostAndFound suites, let's just use it.
It's called IgniteLostAndFoundTestSuite
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r516483599
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheMultithreadedFailoverAbstractTest.java
##########
@@ -69,6 +70,7 @@
/**
* Base test for all multithreaded cache scenarios w/ and w/o failover.
*/
+@Ignore("FAILED! Abstract")
Review comment:
Does it have any running subclasses? If so, it does not need to be included in suites itself. If it doesn't, let's make it not abstrace?
##########
File path: modules/core/src/test/java/org/apache/ignite/loadtests/communication/GridIoManagerBenchmark0.java
##########
@@ -44,13 +44,15 @@
import org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Ignore;
import org.junit.Test;
import static org.apache.ignite.internal.managers.communication.GridIoPolicy.PUBLIC_POOL;
/**
*
*/
+@Ignore("Benchmark")
Review comment:
please file an additional ticket to deal with all benchmark/load tests, link to it here.
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteBinaryMetadataUpdateNodeRestartTest.java
##########
@@ -47,6 +48,7 @@
/**
*
*/
+@Ignore("IGNITE-4768, IGNITE-9214")
Review comment:
Here and elsewhere: please choose a single most relevant ticket and put the complete JIRA URL in @Ignore message. TC/MTCGA wll recognize and link it.
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreZookeeperDiscoverySpiTestSuite3.java
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.datastructures.IgniteClientDataStructuresTest;
+import org.apache.ignite.internal.processors.cache.datastructures.partitioned.GridCachePartitionedNodeRestartTxSelfTest;
+import org.apache.ignite.internal.processors.cache.datastructures.partitioned.GridCachePartitionedSequenceApiSelfTest;
+import org.apache.ignite.internal.processors.cache.datastructures.replicated.GridCacheReplicatedSequenceApiSelfTest;
+import org.apache.ignite.internal.processors.cache.distributed.replicated.GridCacheReplicatedNodeRestartSelfTest;
+import org.apache.ignite.internal.processors.cache.multijvm.GridCacheAtomicMultiJvmFullApiSelfTest;
+import org.apache.ignite.internal.processors.cache.multijvm.GridCachePartitionedMultiJvmFullApiSelfTest;
+import org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryLongP2PTest;
+import org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryOperationP2PTest;
+import org.apache.ignite.internal.processors.continuous.GridEventConsumeSelfTest;
+import org.apache.ignite.p2p.GridP2PContinuousDeploymentSelfTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCacheReplicatedNodeRestartSelfTest.class,
+ GridEventConsumeSelfTest.class,
+ GridCachePartitionedNodeRestartTxSelfTest.class,
+ IgniteClientDataStructuresTest.class,
+ GridCacheReplicatedSequenceApiSelfTest.class,
+ GridCachePartitionedSequenceApiSelfTest.class,
+ GridCacheAtomicMultiJvmFullApiSelfTest.class,
+ GridCachePartitionedMultiJvmFullApiSelfTest.class,
+ GridP2PContinuousDeploymentSelfTest.class,
+ CacheContinuousQueryOperationP2PTest.class,
+ CacheContinuousQueryLongP2PTest.class,
+})
+public class CoreZookeeperDiscoverySpiTestSuite3 {
Review comment:
Why do you call all suites Core*? We do not have such conventions, please rename them like the existing ones. Then we can update TC. Did you try to run them on TC, by the way?
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreIgniteSpringTestSuite.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtMultiBackupTest;
+import org.apache.ignite.startup.cmdline.GridCommandLineLoaderTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Spring tests.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCommandLineLoaderTest.class,
+
+ GridCacheDhtMultiBackupTest.class
+})
+public class CoreIgniteSpringTestSuite {
Review comment:
Can we perhaps get rid of these tiny suites, move these tests to already existing suites?
##########
File path: modules/indexing/src/test/java/org/apache/ignite/testsuites/IgniteCacheQuerySelfTestSuite3.java
##########
@@ -48,34 +26,7 @@
*/
@RunWith(Suite.class)
@Suite.SuiteClasses({
- CacheContinuousQueryBufferLimitTest.class,
-
- GridCacheContinuousQueryNodesFilteringTest.class,
- GridCacheContinuousQueryPartitionTxOneNodeTest.class,
- CacheContinuousWithTransformerReplicatedSelfTest.class,
- CacheContinuousWithTransformerClientSelfTest.class,
- CacheContinuousQueryExecuteInPrimaryTest.class,
- IgniteCacheContinuousQueryNoUnsubscribeTest.class,
-
- ClientReconnectContinuousQueryTest.class,
- IgniteCacheContinuousQueryReconnectTest.class,
- IgniteCacheContinuousQueryClientTxReconnectTest.class,
- IgniteCacheContinuousQueryClientReconnectTest.class,
-
- GridCacheContinuousQueryAtomicSelfTest.class,
- GridCacheContinuousQueryAtomicNearEnabledSelfTest.class,
- GridCacheContinuousQueryPartitionedSelfTest.class,
- GridCacheContinuousQueryReplicatedSelfTest.class,
-
- CacheContinuousQueryFactoryAsyncFilterRandomOperationTest.class,
- CacheContinuousBatchForceServerModeAckTest.class,
- ContinuousQueryReassignmentTest.class,
- CacheContinuousQueryConcurrentPartitionUpdateTest.class,
-
- CacheContinuousQueryCounterPartitionedAtomicTest.class,
- CacheContinuousQueryCounterPartitionedTxTest.class,
- CacheContinuousQueryCounterReplicatedAtomicTest.class,
- CacheContinuousQueryCounterReplicatedTxTest.class
+ CoreIgniteCacheQuerySelfTestSuite3.class
Review comment:
Why? What's the point?
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/db/wal/WalCompactionAfterRestartTest.java
##########
@@ -40,11 +40,13 @@
import org.apache.ignite.lang.IgniteBiTuple;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Ignore;
import org.junit.Test;
import static org.apache.ignite.events.EventType.EVT_WAL_SEGMENT_COMPACTED;
/** */
+@Ignore("FAILED!")
Review comment:
Please file a separate ticket to deal with all failed tests, link it here
##########
File path: modules/tools/src/main/java/org/apache/ignite/tools/surefire/testsuites/CheckAllTestsInSuites.java
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.tools.surefire.testsuites;
+
+import java.lang.reflect.Modifier;
+import java.util.HashSet;
+import java.util.Set;
+import org.junit.Ignore;
+import org.junit.Test;
+import org.junit.runner.Description;
+import org.junit.runner.Request;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Suite;
+
+/** Checks that all test classes are part of any suite. */
+public class CheckAllTestsInSuites {
+ /** List of test classes. Input of the test. */
+ static Iterable<Class<?>> testClasses;
+
+ /** */
+ @Test
+ public void check() {
+ Set<Class<?>> suitedTestClasses = new HashSet<>();
+ Set<Class<?>> allTestClasses = new HashSet<>();
+ Set<Class<?>> suites = new HashSet<>();
+
+ // Workaround to handle cases when a class has descenders and it's OK to skip the base class.
+ // Also it works for DynamicSuite that can use a base class to create new test classes with reflection.
+ Set<Class<?>> superClasses = new HashSet<>();
+
+ for (Class<?> clazz: testClasses) {
Review comment:
white space is needed before :
##########
File path: modules/tools/src/main/java/org/apache/ignite/tools/surefire/testsuites/CheckAllTestsInSuites.java
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.tools.surefire.testsuites;
+
+import java.lang.reflect.Modifier;
+import java.util.HashSet;
+import java.util.Set;
+import org.junit.Ignore;
+import org.junit.Test;
+import org.junit.runner.Description;
+import org.junit.runner.Request;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Suite;
+
+/** Checks that all test classes are part of any suite. */
+public class CheckAllTestsInSuites {
+ /** List of test classes. Input of the test. */
+ static Iterable<Class<?>> testClasses;
+
+ /** */
+ @Test
+ public void check() {
+ Set<Class<?>> suitedTestClasses = new HashSet<>();
+ Set<Class<?>> allTestClasses = new HashSet<>();
+ Set<Class<?>> suites = new HashSet<>();
+
+ // Workaround to handle cases when a class has descenders and it's OK to skip the base class.
+ // Also it works for DynamicSuite that can use a base class to create new test classes with reflection.
+ Set<Class<?>> superClasses = new HashSet<>();
+
+ for (Class<?> clazz: testClasses) {
+ if (Modifier.isAbstract(clazz.getModifiers()))
+ continue;
+
+ if (clazz.getAnnotation(Ignore.class) != null)
+ continue;
+
+ Description desc = Request.aClass(clazz).getRunner().getDescription();
+
+ if (isTestClass(desc)) {
+ allTestClasses.add(clazz);
+ superClasses.add(clazz.getSuperclass());
+ }
+ else
+ processSuite(desc, suitedTestClasses, suites, superClasses);
+ }
+
+ allTestClasses.removeAll(suitedTestClasses);
+ allTestClasses.removeAll(superClasses);
+
+ if (!allTestClasses.isEmpty()) {
+ StringBuilder builder = new StringBuilder("All test classes must be include in any test suite.")
+ .append("\nList of non-suited classes (")
+ .append(allTestClasses.size())
+ .append(" items):\n");
+
+ for (Class<?> c: allTestClasses)
+ builder.append("\t").append(c.getName()).append("\n");
+
+ throw new AssertionError(builder.toString());
+ }
+ }
+
+ /**
+ * Recursively hadnle suites - mark all test classes as suited.
+ */
+ private void processSuite(Description suite, Set<Class<?>> suitedClasses,
+ Set<Class<?>> suites, Set<Class<?>> superClasses) {
+ suites.add(suite.getTestClass());
+
+ for (Description desc: suite.getChildren()) {
+ if (!isTestClass(desc))
+ processSuite(desc, suitedClasses, suites, superClasses);
+ else {
+ suitedClasses.add(desc.getTestClass());
+ superClasses.add(desc.getTestClass().getSuperclass());
+ }
+ }
+ }
+
+ /**
+ * Check whether class is a test class or a suite.
+ *
+ * Suite classes are marked with RunWith annotation and value of it is a descender of Suite.class.
+ * For scala tests suite must be inherited from {@link org.scalatest.Suites} class.
+ * Exclusion of the rule is Parameterized.class, so classes are marked with it are test classes.
+ */
+ private boolean isTestClass(Description desc) {
+ RunWith runWith = desc.getAnnotation(RunWith.class);
+
+ return runWith == null
+ || runWith.value().equals(Parameterized.class)
Review comment:
Please use just 4 whitespaces as indentation level, as per coding guidelines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r531230821
##########
File path: modules/indexing/src/test/java/org/apache/ignite/testsuites/IgniteCacheQuerySelfTestSuite3.java
##########
@@ -48,34 +26,7 @@
*/
@RunWith(Suite.class)
@Suite.SuiteClasses({
- CacheContinuousQueryBufferLimitTest.class,
-
- GridCacheContinuousQueryNodesFilteringTest.class,
- GridCacheContinuousQueryPartitionTxOneNodeTest.class,
- CacheContinuousWithTransformerReplicatedSelfTest.class,
- CacheContinuousWithTransformerClientSelfTest.class,
- CacheContinuousQueryExecuteInPrimaryTest.class,
- IgniteCacheContinuousQueryNoUnsubscribeTest.class,
-
- ClientReconnectContinuousQueryTest.class,
- IgniteCacheContinuousQueryReconnectTest.class,
- IgniteCacheContinuousQueryClientTxReconnectTest.class,
- IgniteCacheContinuousQueryClientReconnectTest.class,
-
- GridCacheContinuousQueryAtomicSelfTest.class,
- GridCacheContinuousQueryAtomicNearEnabledSelfTest.class,
- GridCacheContinuousQueryPartitionedSelfTest.class,
- GridCacheContinuousQueryReplicatedSelfTest.class,
-
- CacheContinuousQueryFactoryAsyncFilterRandomOperationTest.class,
- CacheContinuousBatchForceServerModeAckTest.class,
- ContinuousQueryReassignmentTest.class,
- CacheContinuousQueryConcurrentPartitionUpdateTest.class,
-
- CacheContinuousQueryCounterPartitionedAtomicTest.class,
- CacheContinuousQueryCounterPartitionedTxTest.class,
- CacheContinuousQueryCounterReplicatedAtomicTest.class,
- CacheContinuousQueryCounterReplicatedTxTest.class
+ CoreIgniteCacheQuerySelfTestSuite3.class
Review comment:
Delete this suite at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r525933899
##########
File path: modules/core/src/test/java/org/apache/ignite/loadtests/communication/GridIoManagerBenchmark0.java
##########
@@ -44,13 +44,15 @@
import org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Ignore;
import org.junit.Test;
import static org.apache.ignite.internal.managers.communication.GridIoPolicy.PUBLIC_POOL;
/**
*
*/
+@Ignore("Benchmark")
Review comment:
It's better, but this can be a mandatory requirement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8367: IGNITE-13512 Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r569524476
##########
File path: modules/tools/src/main/java/org/apache/ignite/tools/surefire/testsuites/OrphanedTestCollection.java
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.tools.surefire.testsuites;
+
+import java.io.BufferedReader;
+import java.io.BufferedWriter;
+import java.io.FileReader;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Collection;
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * Represents a persisted list of orphaned tests.
+ */
+public class OrphanedTestCollection {
+ /** File to persist orphaned tests. */
+ private final Path path = initPath();
+
+ /** */
+ public Set<String> getOrphanedTests() throws Exception {
+ if (Files.notExists(path))
+ return new HashSet<>();
+
+ try (
+ BufferedReader testReader = new BufferedReader(new FileReader(path.toFile()))
+ ) {
+ String testClsName = testReader.readLine();
+
+ Set<String> testClasses = new HashSet<>();
+
+ while (testClsName != null) {
+ testClasses.add(testClsName);
+
+ testClsName = testReader.readLine();
+ }
+
+ return testClasses;
+ }
+ }
+
+ /** */
+ public void persistOrphanedTests(Collection<String> testClasses) throws Exception {
+ try (
+ BufferedWriter testWriter = new BufferedWriter(new FileWriter(path.toFile()))
+ ) {
+ for (String cls: testClasses) {
+ testWriter.write(cls);
+ testWriter.newLine();
+ }
+ }
+ }
+
+ /** */
+ public Path getPath() {
+ return path;
+ }
+
+ /**
+ * Structure of Ignite modules is flat but there are some exceptions. Unfortunately it's impossible to
+ * get access to root directory of repository so use this hack to find it.
+ */
+ private static Path initPath() {
+ Path curPath = Paths.get("").toAbsolutePath();
+
+ while (!curPath.equals(curPath.getRoot())) {
+ if (curPath.resolve("modules").toFile().exists()) {
+ Path targetPath = curPath.resolve("target");
+
+ if (!targetPath.toFile().exists())
Review comment:
Multiline if() requires squirly bracket body even if it contains single statement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: IGNITE-13512 Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r563713978
##########
File path: modules/indexing/src/test/java/org/apache/ignite/testsuites/IgniteCacheQuerySelfTestSuite3.java
##########
@@ -48,34 +26,7 @@
*/
@RunWith(Suite.class)
@Suite.SuiteClasses({
- CacheContinuousQueryBufferLimitTest.class,
-
- GridCacheContinuousQueryNodesFilteringTest.class,
- GridCacheContinuousQueryPartitionTxOneNodeTest.class,
- CacheContinuousWithTransformerReplicatedSelfTest.class,
- CacheContinuousWithTransformerClientSelfTest.class,
- CacheContinuousQueryExecuteInPrimaryTest.class,
- IgniteCacheContinuousQueryNoUnsubscribeTest.class,
-
- ClientReconnectContinuousQueryTest.class,
- IgniteCacheContinuousQueryReconnectTest.class,
- IgniteCacheContinuousQueryClientTxReconnectTest.class,
- IgniteCacheContinuousQueryClientReconnectTest.class,
-
- GridCacheContinuousQueryAtomicSelfTest.class,
- GridCacheContinuousQueryAtomicNearEnabledSelfTest.class,
- GridCacheContinuousQueryPartitionedSelfTest.class,
- GridCacheContinuousQueryReplicatedSelfTest.class,
-
- CacheContinuousQueryFactoryAsyncFilterRandomOperationTest.class,
- CacheContinuousBatchForceServerModeAckTest.class,
- ContinuousQueryReassignmentTest.class,
- CacheContinuousQueryConcurrentPartitionUpdateTest.class,
-
- CacheContinuousQueryCounterPartitionedAtomicTest.class,
- CacheContinuousQueryCounterPartitionedTxTest.class,
- CacheContinuousQueryCounterReplicatedAtomicTest.class,
- CacheContinuousQueryCounterReplicatedTxTest.class
+ CoreIgniteCacheQuerySelfTestSuite3.class
Review comment:
Back test suite to original state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r525148872
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/db/wal/WalCompactionAfterRestartTest.java
##########
@@ -40,11 +40,13 @@
import org.apache.ignite.lang.IgniteBiTuple;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Ignore;
import org.junit.Test;
import static org.apache.ignite.events.EventType.EVT_WAL_SEGMENT_COMPACTED;
/** */
+@Ignore("FAILED!")
Review comment:
It was a compromise that was explicitly discussed, which included creation of separate tickets, so I think we should have tickets here as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r526055434
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteBinaryMetadataUpdateNodeRestartTest.java
##########
@@ -47,6 +48,7 @@
/**
*
*/
+@Ignore("IGNITE-4768, IGNITE-9214")
Review comment:
I found that there are cases with comma separated list of links. For example `PageEvictionTouchOrderTest.testTouchOrderWithFairFifoEvictionMvccTxReplicated`. But MTCGA shows only first ticket. Also I try find some tests with double @Ignore annotation, but there are no such cases.
Looks like we should continue the practice, use csv for such things. Also MTCGA should display them correctly, I can create a ticket for that.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r526059275
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreIgniteSpringTestSuite.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtMultiBackupTest;
+import org.apache.ignite.startup.cmdline.GridCommandLineLoaderTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Spring tests.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCommandLineLoaderTest.class,
+
+ GridCacheDhtMultiBackupTest.class
+})
+public class CoreIgniteSpringTestSuite {
Review comment:
Moving suites to core module may be not enough. ClientTestSuite consist of tests that are depends on IgniteH2Indexing, but written in core module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r517883253
##########
File path: modules/core/src/test/java/org/apache/ignite/loadtests/communication/GridIoManagerBenchmark0.java
##########
@@ -44,13 +44,15 @@
import org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Ignore;
import org.junit.Test;
import static org.apache.ignite.internal.managers.communication.GridIoPolicy.PUBLIC_POOL;
/**
*
*/
+@Ignore("Benchmark")
Review comment:
@alamar, Same proposal here.
Let it be @Ignore("TBD XXX") where XXX is some hint, if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r531205174
##########
File path: modules/core/src/test/java/org/apache/ignite/client/CoreClientTestSuite.java
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+import org.apache.ignite.internal.IgniteClientFailuresTest;
+import org.apache.ignite.internal.client.thin.CacheAsyncTest;
+import org.apache.ignite.internal.client.thin.ClusterApiTest;
+import org.apache.ignite.internal.client.thin.ClusterGroupTest;
+import org.apache.ignite.internal.client.thin.ComputeTaskTest;
+import org.apache.ignite.internal.client.thin.ReliableChannelTest;
+import org.apache.ignite.internal.client.thin.ServicesTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessDiscoveryTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessResourceReleaseTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessStableTopologyTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessUnstableTopologyTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Tests for Java thin client.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ ClientConfigurationTest.class,
+ ClientCacheConfigurationTest.class,
+ FunctionalTest.class,
+ IgniteBinaryTest.class,
+ LoadTest.class,
+ ReliabilityTest.class,
+ ReliabilityTestAsync.class,
+ ReliabilityTestPartitionAware.class,
+ ReliabilityTestPartitionAwareAsync.class,
+ SslParametersTest.class,
+ ConnectionTest.class,
+ ConnectToStartingNodeTest.class,
+ AsyncChannelTest.class,
+ ComputeTaskTest.class,
+ ClusterApiTest.class,
+ ClusterGroupTest.class,
+ ServicesTest.class,
+ ThinClientPartitionAwarenessStableTopologyTest.class,
+ ThinClientPartitionAwarenessUnstableTopologyTest.class,
+ ThinClientPartitionAwarenessResourceReleaseTest.class,
+ ThinClientPartitionAwarenessDiscoveryTest.class,
+ CacheAsyncTest.class,
+ ReliableChannelTest.class,
+ IgniteClientFailuresTest.class
+})
+public class CoreClientTestSuite {
Review comment:
IgniteClientTestSuite is located in different module ignite-clients. Renamed from CoreClientTestSuite to IgniteClientTestSuite, to make naming more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r517878152
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/db/wal/WalCompactionAfterRestartTest.java
##########
@@ -40,11 +40,13 @@
import org.apache.ignite.lang.IgniteBiTuple;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Ignore;
import org.junit.Test;
import static org.apache.ignite.events.EventType.EVT_WAL_SEGMENT_COMPACTED;
/** */
+@Ignore("FAILED!")
Review comment:
@alamar, I do remember you just commented tests at suites at your similar cleanup work.
Let's define some markers like @Ignore("TBD") to make this fix possible in 2020.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r526157663
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/db/wal/WalCompactionAfterRestartTest.java
##########
@@ -40,11 +40,13 @@
import org.apache.ignite.lang.IgniteBiTuple;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Ignore;
import org.junit.Test;
import static org.apache.ignite.events.EventType.EVT_WAL_SEGMENT_COMPACTED;
/** */
+@Ignore("FAILED!")
Review comment:
Added jira url.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r531230821
##########
File path: modules/indexing/src/test/java/org/apache/ignite/testsuites/IgniteCacheQuerySelfTestSuite3.java
##########
@@ -48,34 +26,7 @@
*/
@RunWith(Suite.class)
@Suite.SuiteClasses({
- CacheContinuousQueryBufferLimitTest.class,
-
- GridCacheContinuousQueryNodesFilteringTest.class,
- GridCacheContinuousQueryPartitionTxOneNodeTest.class,
- CacheContinuousWithTransformerReplicatedSelfTest.class,
- CacheContinuousWithTransformerClientSelfTest.class,
- CacheContinuousQueryExecuteInPrimaryTest.class,
- IgniteCacheContinuousQueryNoUnsubscribeTest.class,
-
- ClientReconnectContinuousQueryTest.class,
- IgniteCacheContinuousQueryReconnectTest.class,
- IgniteCacheContinuousQueryClientTxReconnectTest.class,
- IgniteCacheContinuousQueryClientReconnectTest.class,
-
- GridCacheContinuousQueryAtomicSelfTest.class,
- GridCacheContinuousQueryAtomicNearEnabledSelfTest.class,
- GridCacheContinuousQueryPartitionedSelfTest.class,
- GridCacheContinuousQueryReplicatedSelfTest.class,
-
- CacheContinuousQueryFactoryAsyncFilterRandomOperationTest.class,
- CacheContinuousBatchForceServerModeAckTest.class,
- ContinuousQueryReassignmentTest.class,
- CacheContinuousQueryConcurrentPartitionUpdateTest.class,
-
- CacheContinuousQueryCounterPartitionedAtomicTest.class,
- CacheContinuousQueryCounterPartitionedTxTest.class,
- CacheContinuousQueryCounterReplicatedAtomicTest.class,
- CacheContinuousQueryCounterReplicatedTxTest.class
+ CoreIgniteCacheQuerySelfTestSuite3.class
Review comment:
Completely move this test suite to core module, TC will run in indexing scope as discussed on devlist
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r526059275
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreIgniteSpringTestSuite.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtMultiBackupTest;
+import org.apache.ignite.startup.cmdline.GridCommandLineLoaderTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Spring tests.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCommandLineLoaderTest.class,
+
+ GridCacheDhtMultiBackupTest.class
+})
+public class CoreIgniteSpringTestSuite {
Review comment:
Moving suites to core module may be not enough. ClientTestSuite contains tests that are depends on IgniteH2Indexing, but written in the core module. So, we need investigate all such tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r525149397
##########
File path: modules/core/src/test/java/org/apache/ignite/loadtests/communication/GridIoManagerBenchmark0.java
##########
@@ -44,13 +44,15 @@
import org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Ignore;
import org.junit.Test;
import static org.apache.ignite.internal.managers.communication.GridIoPolicy.PUBLIC_POOL;
/**
*
*/
+@Ignore("Benchmark")
Review comment:
It's better to always have machine-readable JIRA URL as Ignore message. All the details may be also added in the form of Java comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: IGNITE-13512 Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r563714159
##########
File path: modules/core/src/test/java/org/apache/ignite/client/CoreClientTestSuite.java
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+import org.apache.ignite.internal.IgniteClientFailuresTest;
+import org.apache.ignite.internal.client.thin.CacheAsyncTest;
+import org.apache.ignite.internal.client.thin.ClusterApiTest;
+import org.apache.ignite.internal.client.thin.ClusterGroupTest;
+import org.apache.ignite.internal.client.thin.ComputeTaskTest;
+import org.apache.ignite.internal.client.thin.ReliableChannelTest;
+import org.apache.ignite.internal.client.thin.ServicesTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessDiscoveryTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessResourceReleaseTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessStableTopologyTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessUnstableTopologyTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Tests for Java thin client.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ ClientConfigurationTest.class,
+ ClientCacheConfigurationTest.class,
+ FunctionalTest.class,
+ IgniteBinaryTest.class,
+ LoadTest.class,
+ ReliabilityTest.class,
+ ReliabilityTestAsync.class,
+ ReliabilityTestPartitionAware.class,
+ ReliabilityTestPartitionAwareAsync.class,
+ SslParametersTest.class,
+ ConnectionTest.class,
+ ConnectToStartingNodeTest.class,
+ AsyncChannelTest.class,
+ ComputeTaskTest.class,
+ ClusterApiTest.class,
+ ClusterGroupTest.class,
+ ServicesTest.class,
+ ThinClientPartitionAwarenessStableTopologyTest.class,
+ ThinClientPartitionAwarenessUnstableTopologyTest.class,
+ ThinClientPartitionAwarenessResourceReleaseTest.class,
+ ThinClientPartitionAwarenessDiscoveryTest.class,
+ CacheAsyncTest.class,
+ ReliableChannelTest.class,
+ IgniteClientFailuresTest.class
+})
+public class CoreClientTestSuite {
Review comment:
Removed. ClientTestSuite is restored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r525932732
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/db/wal/WalCompactionAfterRestartTest.java
##########
@@ -40,11 +40,13 @@
import org.apache.ignite.lang.IgniteBiTuple;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Ignore;
import org.junit.Test;
import static org.apache.ignite.events.EventType.EVT_WAL_SEGMENT_COMPACTED;
/** */
+@Ignore("FAILED!")
Review comment:
Same problem here, issue creation is an optional requirement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #8367: IGNITE-13512 Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #8367:
URL: https://github.com/apache/ignite/pull/8367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: IGNITE-13512 Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r563713671
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreIgniteSpringTestSuite.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtMultiBackupTest;
+import org.apache.ignite.startup.cmdline.GridCommandLineLoaderTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Spring tests.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCommandLineLoaderTest.class,
+
+ GridCacheDhtMultiBackupTest.class
+})
+public class CoreIgniteSpringTestSuite {
Review comment:
Now there is no need to moving test and suites. Now check aggregates test and suites info over all modules and then checks aggregation result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r530377703
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/expiry/IgniteCacheAtomicLocalOnheapExpiryPolicyTest.java
##########
@@ -18,6 +18,9 @@
package org.apache.ignite.internal.processors.cache.expiry;
+import org.junit.Ignore;
+
+@Ignore("https://issues.apache.org/jira/browse/IGNITE-9214")
Review comment:
Class needs javadoc, also below
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/binary/distributed/dht/GridCacheBinaryObjectsAtomicNearDisabledOnheapSelfTest.java
##########
@@ -17,6 +17,9 @@
package org.apache.ignite.internal.processors.cache.binary.distributed.dht;
+import org.junit.Ignore;
+
+@Ignore("https://issues.apache.org/jira/browse/IGNITE-9214")
Review comment:
This class also needs javadoc (also see several classes below)
##########
File path: modules/cassandra/serializers/src/test/java/org/apache/ignite/tests/SerializerSuite.java
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.tests;
+
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+@RunWith(Suite.class)
Review comment:
This is a new class, it requires javadoc comment as per coding guidelines
##########
File path: modules/core/src/test/java/org/apache/ignite/suites/CoreIgniteBinaryCacheQueryTestSuite.java
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.suites;
+
+import org.apache.ignite.internal.metric.SystemViewSelfTest;
+import org.apache.ignite.internal.processors.cache.GridCacheQueryIndexingDisabledSelfTest;
+import org.apache.ignite.internal.processors.cache.GridCacheQueryInternalKeysSelfTest;
+import org.apache.ignite.internal.processors.cache.GridCacheQuerySqlFieldInlineSizeSelfTest;
+import org.apache.ignite.internal.processors.cache.IgniteCacheBinaryObjectsScanSelfTest;
+import org.apache.ignite.internal.processors.cache.IgniteCacheBinaryObjectsScanWithEventsSelfTest;
+import org.apache.ignite.internal.processors.cache.query.CacheDataPageScanQueryTest;
+import org.apache.ignite.internal.processors.cache.query.CacheScanQueryFailoverTest;
+import org.apache.ignite.internal.processors.cache.query.GridCacheQueryTransformerSelfTest;
+import org.apache.ignite.internal.processors.cache.query.GridCircularQueueTest;
+import org.apache.ignite.internal.processors.cache.query.IgniteCacheQueryCacheDestroySelfTest;
+import org.apache.ignite.internal.processors.cache.query.IndexingSpiQuerySelfTest;
+import org.apache.ignite.internal.processors.cache.query.IndexingSpiQueryTxSelfTest;
+import org.apache.ignite.internal.processors.cache.query.IndexingSpiQueryWithH2IndexingSelfTest;
+import org.apache.ignite.internal.sql.SqlParserBulkLoadSelfTest;
+import org.apache.ignite.internal.sql.SqlParserCreateIndexSelfTest;
+import org.apache.ignite.internal.sql.SqlParserDropIndexSelfTest;
+import org.apache.ignite.internal.sql.SqlParserKillQuerySelfTest;
+import org.apache.ignite.internal.sql.SqlParserMultiStatementSelfTest;
+import org.apache.ignite.internal.sql.SqlParserSetStreamingSelfTest;
+import org.apache.ignite.internal.sql.SqlParserTransactionalKeywordsSelfTest;
+import org.apache.ignite.internal.sql.SqlParserUserSelfTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Test suite for cache queries.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ SqlParserCreateIndexSelfTest.class,
+ SqlParserDropIndexSelfTest.class,
+ SqlParserTransactionalKeywordsSelfTest.class,
+ SqlParserBulkLoadSelfTest.class,
+ SqlParserSetStreamingSelfTest.class,
+ SqlParserKillQuerySelfTest.class,
+ SqlParserMultiStatementSelfTest.class,
+
+ GridCacheQueryInternalKeysSelfTest.class,
+ GridCacheQueryTransformerSelfTest.class,
+ CacheScanQueryFailoverTest.class,
+ CacheDataPageScanQueryTest.class,
+ IndexingSpiQuerySelfTest.class,
+ IndexingSpiQueryTxSelfTest.class,
+
+ GridCircularQueueTest.class,
+ IndexingSpiQueryWithH2IndexingSelfTest.class,
+
+ GridCacheQueryIndexingDisabledSelfTest.class,
+ IgniteCacheQueryCacheDestroySelfTest.class,
+ GridCacheQuerySqlFieldInlineSizeSelfTest.class,
+ SqlParserUserSelfTest.class,
+ IgniteCacheBinaryObjectsScanSelfTest.class,
+ IgniteCacheBinaryObjectsScanWithEventsSelfTest.class,
+ SystemViewSelfTest.class
+})
+public class CoreIgniteBinaryCacheQueryTestSuite {
Review comment:
Why not add to IgniteBinaryCacheQueryTestSuite
##########
File path: modules/core/src/test/java/org/apache/ignite/client/CoreClientTestSuite.java
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+import org.apache.ignite.internal.IgniteClientFailuresTest;
+import org.apache.ignite.internal.client.thin.CacheAsyncTest;
+import org.apache.ignite.internal.client.thin.ClusterApiTest;
+import org.apache.ignite.internal.client.thin.ClusterGroupTest;
+import org.apache.ignite.internal.client.thin.ComputeTaskTest;
+import org.apache.ignite.internal.client.thin.ReliableChannelTest;
+import org.apache.ignite.internal.client.thin.ServicesTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessDiscoveryTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessResourceReleaseTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessStableTopologyTest;
+import org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessUnstableTopologyTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Tests for Java thin client.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ ClientConfigurationTest.class,
+ ClientCacheConfigurationTest.class,
+ FunctionalTest.class,
+ IgniteBinaryTest.class,
+ LoadTest.class,
+ ReliabilityTest.class,
+ ReliabilityTestAsync.class,
+ ReliabilityTestPartitionAware.class,
+ ReliabilityTestPartitionAwareAsync.class,
+ SslParametersTest.class,
+ ConnectionTest.class,
+ ConnectToStartingNodeTest.class,
+ AsyncChannelTest.class,
+ ComputeTaskTest.class,
+ ClusterApiTest.class,
+ ClusterGroupTest.class,
+ ServicesTest.class,
+ ThinClientPartitionAwarenessStableTopologyTest.class,
+ ThinClientPartitionAwarenessUnstableTopologyTest.class,
+ ThinClientPartitionAwarenessResourceReleaseTest.class,
+ ThinClientPartitionAwarenessDiscoveryTest.class,
+ CacheAsyncTest.class,
+ ReliableChannelTest.class,
+ IgniteClientFailuresTest.class
+})
+public class CoreClientTestSuite {
Review comment:
Why not add them to e.g. IgniteClientTestSuite?
##########
File path: modules/core/src/test/java/org/apache/ignite/suites/CoreIgnitePdsWithIndexingCoreTestSuite.java
##########
@@ -0,0 +1,95 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+package org.apache.ignite.suites;
+
+import org.apache.ignite.internal.processors.cache.persistence.IgnitePdsAtomicCacheHistoricalRebalancingTest;
+import org.apache.ignite.internal.processors.cache.persistence.IgnitePdsAtomicCacheRebalancingTest;
+import org.apache.ignite.internal.processors.cache.persistence.IgnitePdsBinaryMetadataAsyncWritingTest;
+import org.apache.ignite.internal.processors.cache.persistence.IgnitePdsBinaryMetadataOnClusterRestartTest;
+import org.apache.ignite.internal.processors.cache.persistence.IgnitePdsBinarySortObjectFieldsTest;
+import org.apache.ignite.internal.processors.cache.persistence.IgnitePdsCorruptedIndexTest;
+import org.apache.ignite.internal.processors.cache.persistence.IgnitePdsMarshallerMappingRestoreOnNodeStartTest;
+import org.apache.ignite.internal.processors.cache.persistence.IgnitePdsTxCacheRebalancingTest;
+import org.apache.ignite.internal.processors.cache.persistence.IgnitePdsTxHistoricalRebalancingTest;
+import org.apache.ignite.internal.processors.cache.persistence.IgnitePersistenceSequentialCheckpointTest;
+import org.apache.ignite.internal.processors.cache.persistence.IgnitePersistentStoreCacheGroupsTest;
+import org.apache.ignite.internal.processors.cache.persistence.PersistenceDirectoryWarningLoggingTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.IgniteLogicalRecoveryTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.IgnitePdsMultiNodePutGetRestartTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.IgnitePdsPageEvictionTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.IgniteSequentialNodeCrashRecoveryTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.file.IgnitePdsCacheDestroyDuringCheckpointTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.file.IgnitePdsCacheIntegrationTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.file.IgnitePdsDiskErrorsRecoveringTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.file.IgnitePdsNoActualWalHistoryTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.file.IgnitePdsThreadInterruptionTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.wal.IgniteWalRebalanceTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.wal.IgniteWalRecoveryPPCTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.wal.WalOnNodeStartTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.wal.WalPathsTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.wal.WalRecoveryTxLogicalRecordsTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.wal.WalRolloverRecordLoggingFsyncTest;
+import org.apache.ignite.internal.processors.cache.persistence.db.wal.WalRolloverRecordLoggingLogOnlyTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Test suite for tests that cover core PDS features and depend on indexing module.
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ IgnitePdsCacheIntegrationTest.class,
+ IgnitePdsPageEvictionTest.class,
+ IgnitePdsMultiNodePutGetRestartTest.class,
+ IgnitePersistentStoreCacheGroupsTest.class,
+ IgnitePersistenceSequentialCheckpointTest.class,
+ PersistenceDirectoryWarningLoggingTest.class,
+ WalPathsTest.class,
+ WalRecoveryTxLogicalRecordsTest.class,
+ WalRolloverRecordLoggingFsyncTest.class,
+ WalRolloverRecordLoggingLogOnlyTest.class,
+ WalOnNodeStartTest.class,
+
+ IgnitePdsNoActualWalHistoryTest.class,
+ IgniteWalRebalanceTest.class,
+
+ IgnitePdsAtomicCacheRebalancingTest.class,
+ IgnitePdsAtomicCacheHistoricalRebalancingTest.class,
+
+ IgnitePdsTxCacheRebalancingTest.class,
+ IgnitePdsTxHistoricalRebalancingTest.class,
+
+ IgniteWalRecoveryPPCTest.class,
+
+ IgnitePdsDiskErrorsRecoveringTest.class,
+
+ IgnitePdsCacheDestroyDuringCheckpointTest.class,
+
+ IgnitePdsBinaryMetadataOnClusterRestartTest.class,
+ IgnitePdsBinaryMetadataAsyncWritingTest.class,
+ IgnitePdsMarshallerMappingRestoreOnNodeStartTest.class,
+ IgnitePdsThreadInterruptionTest.class,
+ IgnitePdsBinarySortObjectFieldsTest.class,
+
+ IgnitePdsCorruptedIndexTest.class,
+
+ IgniteLogicalRecoveryTest.class,
+
+ IgniteSequentialNodeCrashRecoveryTest.class
+})
+public class CoreIgnitePdsWithIndexingCoreTestSuite {
Review comment:
Let's postpone this great suite renaming. It's even more confusing now than it was before.
##########
File path: modules/indexing/src/test/java/org/apache/ignite/testsuites/IgniteCacheQuerySelfTestSuite3.java
##########
@@ -48,34 +26,7 @@
*/
@RunWith(Suite.class)
@Suite.SuiteClasses({
- CacheContinuousQueryBufferLimitTest.class,
-
- GridCacheContinuousQueryNodesFilteringTest.class,
- GridCacheContinuousQueryPartitionTxOneNodeTest.class,
- CacheContinuousWithTransformerReplicatedSelfTest.class,
- CacheContinuousWithTransformerClientSelfTest.class,
- CacheContinuousQueryExecuteInPrimaryTest.class,
- IgniteCacheContinuousQueryNoUnsubscribeTest.class,
-
- ClientReconnectContinuousQueryTest.class,
- IgniteCacheContinuousQueryReconnectTest.class,
- IgniteCacheContinuousQueryClientTxReconnectTest.class,
- IgniteCacheContinuousQueryClientReconnectTest.class,
-
- GridCacheContinuousQueryAtomicSelfTest.class,
- GridCacheContinuousQueryAtomicNearEnabledSelfTest.class,
- GridCacheContinuousQueryPartitionedSelfTest.class,
- GridCacheContinuousQueryReplicatedSelfTest.class,
-
- CacheContinuousQueryFactoryAsyncFilterRandomOperationTest.class,
- CacheContinuousBatchForceServerModeAckTest.class,
- ContinuousQueryReassignmentTest.class,
- CacheContinuousQueryConcurrentPartitionUpdateTest.class,
-
- CacheContinuousQueryCounterPartitionedAtomicTest.class,
- CacheContinuousQueryCounterPartitionedTxTest.class,
- CacheContinuousQueryCounterReplicatedAtomicTest.class,
- CacheContinuousQueryCounterReplicatedTxTest.class
+ CoreIgniteCacheQuerySelfTestSuite3.class
Review comment:
Unanswered
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r526155756
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheMultithreadedFailoverAbstractTest.java
##########
@@ -69,6 +70,7 @@
/**
* Base test for all multithreaded cache scenarios w/ and w/o failover.
*/
+@Ignore("FAILED! Abstract")
Review comment:
Un-abstarct it, add jira link.
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheMultithreadedFailoverAbstractTest.java
##########
@@ -69,6 +70,7 @@
/**
* Base test for all multithreaded cache scenarios w/ and w/o failover.
*/
+@Ignore("FAILED! Abstract")
Review comment:
Un-abstarcted it, added jira link.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch commented on a change in pull request #8367: Add travis check that tests are not in suites
Posted by GitBox <gi...@apache.org>.
ivandasch commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r525313372
##########
File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreZookeeperDiscoverySpiTestSuite3.java
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import org.apache.ignite.internal.processors.cache.datastructures.IgniteClientDataStructuresTest;
+import org.apache.ignite.internal.processors.cache.datastructures.partitioned.GridCachePartitionedNodeRestartTxSelfTest;
+import org.apache.ignite.internal.processors.cache.datastructures.partitioned.GridCachePartitionedSequenceApiSelfTest;
+import org.apache.ignite.internal.processors.cache.datastructures.replicated.GridCacheReplicatedSequenceApiSelfTest;
+import org.apache.ignite.internal.processors.cache.distributed.replicated.GridCacheReplicatedNodeRestartSelfTest;
+import org.apache.ignite.internal.processors.cache.multijvm.GridCacheAtomicMultiJvmFullApiSelfTest;
+import org.apache.ignite.internal.processors.cache.multijvm.GridCachePartitionedMultiJvmFullApiSelfTest;
+import org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryLongP2PTest;
+import org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryOperationP2PTest;
+import org.apache.ignite.internal.processors.continuous.GridEventConsumeSelfTest;
+import org.apache.ignite.p2p.GridP2PContinuousDeploymentSelfTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ */
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+ GridCacheReplicatedNodeRestartSelfTest.class,
+ GridEventConsumeSelfTest.class,
+ GridCachePartitionedNodeRestartTxSelfTest.class,
+ IgniteClientDataStructuresTest.class,
+ GridCacheReplicatedSequenceApiSelfTest.class,
+ GridCachePartitionedSequenceApiSelfTest.class,
+ GridCacheAtomicMultiJvmFullApiSelfTest.class,
+ GridCachePartitionedMultiJvmFullApiSelfTest.class,
+ GridP2PContinuousDeploymentSelfTest.class,
+ CacheContinuousQueryOperationP2PTest.class,
+ CacheContinuousQueryLongP2PTest.class,
+})
+public class CoreZookeeperDiscoverySpiTestSuite3 {
Review comment:
Khm, I'm sorry, but why we need to create this suite?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org