You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/09/14 18:29:34 UTC
[jira] Created: (HARMONY-6648) Character.codePointAt exception
differences
Character.codePointAt exception differences
-------------------------------------------
Key: HARMONY-6648
URL: https://issues.apache.org/jira/browse/HARMONY-6648
Project: Harmony
Issue Type: Bug
Components: Non-bug differences from RI
Affects Versions: 5.0M15
Reporter: Robert Muir
In the Lucene tests, we had a test that looked for expected exceptions from various Character.codePointAt methods.
The test was written to look for StringIndexOutOfBounds and ArrayIndexOutOfBounds, and passes because
people happen to be using an implementation that throws those.
but the javadocs contract states IndexOutOfBounds, which harmony throws.
Our test is wrong, but its a small difference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6648) Character.codePointAt exception
differences
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess updated HARMONY-6648:
----------------------------------
Attachment: luni.997116.jar
I've fixed the issue you mention and a couple of similar ones in commit r997116 and attached luni.997116.jar.
> Character.codePointAt exception differences
> -------------------------------------------
>
> Key: HARMONY-6648
> URL: https://issues.apache.org/jira/browse/HARMONY-6648
> Project: Harmony
> Issue Type: Bug
> Components: Non-bug differences from RI
> Affects Versions: 5.0M15
> Reporter: Robert Muir
> Assignee: Mark Hindess
> Fix For: 5.0M16
>
> Attachments: luni.997116.jar, luni.jar
>
>
> In the Lucene tests, we had a test that looked for expected exceptions from various Character.codePointAt methods.
> The test was written to look for StringIndexOutOfBounds and ArrayIndexOutOfBounds, and passes because
> people happen to be using an implementation that throws those.
> but the javadocs contract states IndexOutOfBounds, which harmony throws.
> Our test is wrong, but its a small difference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6648) Character.codePointAt exception
differences
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909818#action_12909818 ]
Hudson commented on HARMONY-6648:
---------------------------------
Integrated in Harmony-1.5-head-linux-x86_64 #944 (See [https://hudson.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/944/])
> Character.codePointAt exception differences
> -------------------------------------------
>
> Key: HARMONY-6648
> URL: https://issues.apache.org/jira/browse/HARMONY-6648
> Project: Harmony
> Issue Type: Bug
> Components: Non-bug differences from RI
> Affects Versions: 5.0M15
> Reporter: Robert Muir
> Assignee: Mark Hindess
> Fix For: 5.0M16
>
> Attachments: luni.997116.jar, luni.jar
>
>
> In the Lucene tests, we had a test that looked for expected exceptions from various Character.codePointAt methods.
> The test was written to look for StringIndexOutOfBounds and ArrayIndexOutOfBounds, and passes because
> people happen to be using an implementation that throws those.
> but the javadocs contract states IndexOutOfBounds, which harmony throws.
> Our test is wrong, but its a small difference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6648) Character.codePointAt exception
differences
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess updated HARMONY-6648:
----------------------------------
Attachment: luni.jar
Here's an updated luni.jar with the fix to aid with verifying the commit.
> Character.codePointAt exception differences
> -------------------------------------------
>
> Key: HARMONY-6648
> URL: https://issues.apache.org/jira/browse/HARMONY-6648
> Project: Harmony
> Issue Type: Bug
> Components: Non-bug differences from RI
> Affects Versions: 5.0M15
> Reporter: Robert Muir
> Assignee: Mark Hindess
> Fix For: 5.0M16
>
> Attachments: luni.jar
>
>
> In the Lucene tests, we had a test that looked for expected exceptions from various Character.codePointAt methods.
> The test was written to look for StringIndexOutOfBounds and ArrayIndexOutOfBounds, and passes because
> people happen to be using an implementation that throws those.
> but the javadocs contract states IndexOutOfBounds, which harmony throws.
> Our test is wrong, but its a small difference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6648) Character.codePointAt exception
differences
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess resolved HARMONY-6648.
-----------------------------------
Fix Version/s: 5.0M16
Resolution: Fixed
Thanks for the bug report. Fixed at r997081. As Tim says in the thread at:
http://markmail.org/message/7s6533mswansmnm3
we might as well match the RI behaviour since it is an explicit throw. Please verify (by closing this JIRA) that this change resolves this issue.
> Character.codePointAt exception differences
> -------------------------------------------
>
> Key: HARMONY-6648
> URL: https://issues.apache.org/jira/browse/HARMONY-6648
> Project: Harmony
> Issue Type: Bug
> Components: Non-bug differences from RI
> Affects Versions: 5.0M15
> Reporter: Robert Muir
> Assignee: Mark Hindess
> Fix For: 5.0M16
>
>
> In the Lucene tests, we had a test that looked for expected exceptions from various Character.codePointAt methods.
> The test was written to look for StringIndexOutOfBounds and ArrayIndexOutOfBounds, and passes because
> people happen to be using an implementation that throws those.
> but the javadocs contract states IndexOutOfBounds, which harmony throws.
> Our test is wrong, but its a small difference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-6648) Character.codePointAt exception
differences
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir closed HARMONY-6648.
--------------------------------
I verified r997116 with the provided jar, thank you!
> Character.codePointAt exception differences
> -------------------------------------------
>
> Key: HARMONY-6648
> URL: https://issues.apache.org/jira/browse/HARMONY-6648
> Project: Harmony
> Issue Type: Bug
> Components: Non-bug differences from RI
> Affects Versions: 5.0M15
> Reporter: Robert Muir
> Assignee: Mark Hindess
> Fix For: 5.0M16
>
> Attachments: luni.997116.jar, luni.jar
>
>
> In the Lucene tests, we had a test that looked for expected exceptions from various Character.codePointAt methods.
> The test was written to look for StringIndexOutOfBounds and ArrayIndexOutOfBounds, and passes because
> people happen to be using an implementation that throws those.
> but the javadocs contract states IndexOutOfBounds, which harmony throws.
> Our test is wrong, but its a small difference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6648) Character.codePointAt exception
differences
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess reassigned HARMONY-6648:
-------------------------------------
Assignee: Mark Hindess
> Character.codePointAt exception differences
> -------------------------------------------
>
> Key: HARMONY-6648
> URL: https://issues.apache.org/jira/browse/HARMONY-6648
> Project: Harmony
> Issue Type: Bug
> Components: Non-bug differences from RI
> Affects Versions: 5.0M15
> Reporter: Robert Muir
> Assignee: Mark Hindess
>
> In the Lucene tests, we had a test that looked for expected exceptions from various Character.codePointAt methods.
> The test was written to look for StringIndexOutOfBounds and ArrayIndexOutOfBounds, and passes because
> people happen to be using an implementation that throws those.
> but the javadocs contract states IndexOutOfBounds, which harmony throws.
> Our test is wrong, but its a small difference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6648) Character.codePointAt exception
differences
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909465#action_12909465 ]
Robert Muir commented on HARMONY-6648:
--------------------------------------
I applied the patch with our svn revision 996977 (I fixed the test in 996978), and it cleared up some test fails, but one remains
this is coming from the following method:
public static int codePointAt(char[] seq, int index) {
It seems this one still throws the generic IIOBE.
By the way, thanks again for uploading the jar files. It makes it trivial to test these things at the moment.
In the future hopefully I can get myself setup to compile harmony so I can do a better job with patches/tests here.
> Character.codePointAt exception differences
> -------------------------------------------
>
> Key: HARMONY-6648
> URL: https://issues.apache.org/jira/browse/HARMONY-6648
> Project: Harmony
> Issue Type: Bug
> Components: Non-bug differences from RI
> Affects Versions: 5.0M15
> Reporter: Robert Muir
> Assignee: Mark Hindess
> Fix For: 5.0M16
>
> Attachments: luni.jar
>
>
> In the Lucene tests, we had a test that looked for expected exceptions from various Character.codePointAt methods.
> The test was written to look for StringIndexOutOfBounds and ArrayIndexOutOfBounds, and passes because
> people happen to be using an implementation that throws those.
> but the javadocs contract states IndexOutOfBounds, which harmony throws.
> Our test is wrong, but its a small difference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6648) Character.codePointAt exception
differences
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909868#action_12909868 ]
Hudson commented on HARMONY-6648:
---------------------------------
Integrated in Harmony-select-1.5-head-linux-x86_64 #106 (See [https://hudson.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/106/])
> Character.codePointAt exception differences
> -------------------------------------------
>
> Key: HARMONY-6648
> URL: https://issues.apache.org/jira/browse/HARMONY-6648
> Project: Harmony
> Issue Type: Bug
> Components: Non-bug differences from RI
> Affects Versions: 5.0M15
> Reporter: Robert Muir
> Assignee: Mark Hindess
> Fix For: 5.0M16
>
> Attachments: luni.997116.jar, luni.jar
>
>
> In the Lucene tests, we had a test that looked for expected exceptions from various Character.codePointAt methods.
> The test was written to look for StringIndexOutOfBounds and ArrayIndexOutOfBounds, and passes because
> people happen to be using an implementation that throws those.
> but the javadocs contract states IndexOutOfBounds, which harmony throws.
> Our test is wrong, but its a small difference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.