You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "HuaHuaY (via GitHub)" <gi...@apache.org> on 2025/11/28 13:13:55 UTC
[PR] fix: clang-tidy in cpplint should compile header files in C++23 [iceberg-cpp]
HuaHuaY opened a new pull request, #367:
URL: https://github.com/apache/iceberg-cpp/pull/367
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: clang-tidy in cpplint should compile header files in C++23 [iceberg-cpp]
Posted by "HuaHuaY (via GitHub)" <gi...@apache.org>.
HuaHuaY commented on code in PR #367:
URL: https://github.com/apache/iceberg-cpp/pull/367#discussion_r2571841354
##########
.github/workflows/cpp-linter.yml:
##########
@@ -29,6 +29,9 @@ on:
jobs:
cpp-linter:
runs-on: ubuntu-24.04
+ permissions:
+ contents: read
+ pull-requests: write
Review Comment:
Or should we remove `thread-comments: true`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: clang-tidy in cpplint should compile header files in C++23 [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #367:
URL: https://github.com/apache/iceberg-cpp/pull/367#discussion_r2571833219
##########
.github/workflows/cpp-linter.yml:
##########
@@ -29,6 +29,9 @@ on:
jobs:
cpp-linter:
runs-on: ubuntu-24.04
+ permissions:
+ contents: read
+ pull-requests: write
Review Comment:
I've tried this but it does not work. See discussion in https://github.com/apache/iceberg-cpp/pull/20#issuecomment-2566081248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: clang-tidy in cpplint should compile header files in C++23 [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #367:
URL: https://github.com/apache/iceberg-cpp/pull/367#discussion_r2571809685
##########
.github/workflows/cpp-linter.yml:
##########
@@ -57,8 +60,9 @@ jobs:
thread-comments: true
ignore: 'build|cmake_modules|ci'
database: build
+ verbosity: 'debug'
Review Comment:
Do we need to remove this? Does it affect the run time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: clang-tidy in cpplint should compile header files in C++23 [iceberg-cpp]
Posted by "HuaHuaY (via GitHub)" <gi...@apache.org>.
HuaHuaY commented on code in PR #367:
URL: https://github.com/apache/iceberg-cpp/pull/367#discussion_r2571844109
##########
.github/workflows/cpp-linter.yml:
##########
@@ -57,8 +60,9 @@ jobs:
thread-comments: true
ignore: 'build|cmake_modules|ci'
database: build
+ verbosity: 'debug'
Review Comment:
It will display detailed output when clang-tidy errors. I think it doesn't affect the run time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: clang-tidy in cpplint should compile header files in C++23 [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #367:
URL: https://github.com/apache/iceberg-cpp/pull/367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org