[GitHub] [spark] wangyum commented on a change in pull request #30898: [SPARK-33884][SQL] Simplify conditional if all branches are foldable boolean type

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #30898:
URL: https://github.com/apache/spark/pull/30898#discussion_r549210042



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -475,6 +475,8 @@ object SimplifyConditionals extends Rule[LogicalPlan] with PredicateHelper {
       case If(TrueLiteral, trueValue, _) => trueValue
       case If(FalseLiteral, _, falseValue) => falseValue
       case If(Literal(null, _), _, falseValue) => falseValue
+      case If(_, TrueLiteral, TrueLiteral) => TrueLiteral
+      case If(_, FalseLiteral, FalseLiteral) => FalseLiteral
       case If(cond, TrueLiteral, FalseLiteral) => cond
       case If(cond, FalseLiteral, TrueLiteral) => Not(cond)
       case If(cond, trueValue, falseValue)

Review comment:
       This is only for deterministic expressions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org