You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "Yan Fang (JIRA)" <ji...@apache.org> on 2015/09/16 09:28:46 UTC

[jira] [Commented] (SAMZA-549) Rat shouldn't fail unlicensed files on build

    [ https://issues.apache.org/jira/browse/SAMZA-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14747083#comment-14747083 ] 

Yan Fang commented on SAMZA-549:
--------------------------------

The patch does not fail the build when there are unlicensed files, but at the same time, when we run ./gradlew check, the check will not fail either. 

The idea is only to fail the rat in ./gradlew check, not in ./gradlew build, when there are unlicensed files. Since the "build" always run "check and assembly", not sure if this issue is fixable.

> Rat shouldn't fail unlicensed files on build
> --------------------------------------------
>
>                 Key: SAMZA-549
>                 URL: https://issues.apache.org/jira/browse/SAMZA-549
>             Project: Samza
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.9.0
>            Reporter: Jakob Homan
>            Assignee: Aleksandar Bircakovic
>             Fix For: 0.10.0
>
>         Attachments: SAMZA-549.0.patch
>
>
> Post SAMZA-93, rat will fail unlicensed files not just on the check task, but also for the routine build task.  It should be possible to build without being in total compliance.  Rat should either not be run on the build task or just warn on unlicensed files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)