Re: [PR] FINERACT-2203: LoanTransactionsApi add getLoanTransactions with transactionType filtering [fineract]

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy commented on code in PR #4432:
URL: https://github.com/apache/fineract/pull/4432#discussion_r1991293225


##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanStepDef.java:
##########
@@ -3442,4 +3443,34 @@ private List<String> fetchValuesOfLoanChargeOffReasonOptions(final List<String>
         }
         return actualValues;
     }
+
+    @Then("Log out transaction list by loanId, filtered out the following transaction types: {string}")
+    public void transactionsExcluded(String excludedTypes) throws IOException {
+        Response<PostLoansResponse> loanCreateResponse = testContext().get(TestContextKey.LOAN_CREATE_RESPONSE);
+        long loanId = loanCreateResponse.body().getLoanId();
+        Response<GetLoansLoanIdTransactionsResponse> transactionsByLoanIdFiltered = getTransactionsByLoanIdFiltered(loanId, excludedTypes);
+        log.info("Transaction list without the following transaction types: {} \n{}", excludedTypes,
+                transactionsByLoanIdFiltered.body().toString());
+    }
+
+    @Then("Log out transaction list by loanExternalId, filtered out the following transaction types: {string}")
+    public void transactionsExcludedBzExternalId(String excludedTypes) throws IOException {
+        Response<PostLoansResponse> loanCreateResponse = testContext().get(TestContextKey.LOAN_CREATE_RESPONSE);
+        String loanExternalId = loanCreateResponse.body().getResourceExternalId();
+
+        Response<GetLoansLoanIdTransactionsResponse> transactionsByLoanIdFiltered = getTransactionsByLoanIExternalIdFiltered(loanExternalId,
+                excludedTypes);
+        log.info("Transaction list without the following transaction types: {} \n{}", excludedTypes,

Review Comment:
   I think some assertions would be better here, similarly as "Then Loan Transactions tab has the following data:" 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org