You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/24 23:35:17 UTC
[GitHub] [tvm] driazati opened a new pull request #10778: [ci] Manually merge code after checkout
driazati opened a new pull request #10778:
URL: https://github.com/apache/tvm/pull/10778
This is step 1 of 2 to fix the issue where Jenkins schedules a PR rebuild on non-code changes like editing the title. When the title is changed, GitHub sends an `pull_request` webhook to GitHub. Jenkins would ordinarily look at the webhook, query the PR and checks if the commit hash for the build has already been built. However, since we have it set in the Jenkins job to merge with main before this check occurs, the commit hash is different nearly every time. Disabling that setting fixes the issue, but we still need to merge the code with `main` to ensure that the build is valid if it completes successfully.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a change in pull request #10778: [ci] Manually merge code after checkout
Posted by GitBox <gi...@apache.org>.
driazati commented on a change in pull request #10778:
URL: https://github.com/apache/tvm/pull/10778#discussion_r837834405
##########
File path: Jenkinsfile
##########
@@ -100,6 +100,10 @@ def init_git() {
script: './tests/scripts/task_show_node_info.sh',
label: 'Show executor node info',
)
+ sh (
Review comment:
fixed in the update, it fetches origin once at the beginning and checks out that same commit in further stages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #10778: [ci] Manually merge code after checkout
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #10778:
URL: https://github.com/apache/tvm/pull/10778#discussion_r837925529
##########
File path: Jenkinsfile
##########
@@ -100,6 +101,23 @@ def init_git() {
script: './tests/scripts/task_show_node_info.sh',
label: 'Show executor node info',
)
+
+ // Determine merge commit to use for all stages
+ sh(
+ script: 'git fetch origin main',
+ label: 'Fetch upstream',
+ )
+ if (upstream_revision == null) {
Review comment:
q: what about race conditions with this approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #10778: [ci] Manually merge code after checkout
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #10778:
URL: https://github.com/apache/tvm/pull/10778#discussion_r835460089
##########
File path: Jenkinsfile
##########
@@ -100,6 +100,10 @@ def init_git() {
script: './tests/scripts/task_show_node_info.sh',
label: 'Show executor node info',
)
+ sh (
Review comment:
i think this might mean that different parts of the build use different merge commits, depending on when this runs, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a change in pull request #10778: [ci] Manually merge code after checkout
Posted by GitBox <gi...@apache.org>.
driazati commented on a change in pull request #10778:
URL: https://github.com/apache/tvm/pull/10778#discussion_r837926431
##########
File path: Jenkinsfile
##########
@@ -100,6 +101,23 @@ def init_git() {
script: './tests/scripts/task_show_node_info.sh',
label: 'Show executor node info',
)
+
+ // Determine merge commit to use for all stages
+ sh(
+ script: 'git fetch origin main',
+ label: 'Fetch upstream',
+ )
+ if (upstream_revision == null) {
Review comment:
Right now it's ok since this should happen during the `Sanity Check` stage which gates parallel execution on a sequential job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #10778: [ci] Manually merge code after checkout
Posted by GitBox <gi...@apache.org>.
areusch merged pull request #10778:
URL: https://github.com/apache/tvm/pull/10778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org