[GitHub] [flink] tillrohrmann commented on a change in pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #18534:
URL: https://github.com/apache/flink/pull/18534#discussion_r793771436



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterExecutionDeploymentReconciliationTest.java
##########
@@ -270,9 +271,11 @@ private void registerTaskExecutorAndOfferSlots(
             throws ExecutionException, InterruptedException {
         jobMasterGateway
                 .registerTaskManager(
-                        taskExecutorGateway.getAddress(),
-                        taskManagerLocation,
                         jobId,
+                        TaskManagerRegistrationInformation.create(
+                                taskExecutorGateway.getAddress(),
+                                taskManagerLocation,
+                                TestingUtils.zeroUUID()),

Review comment:
       Do you think that this can happen given that the method is part of `TestingUtils` which should not be in the scope for production code? But I do agree that we could also simply use `UUID.randomUUID()` here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org