You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "tanishqgandhi1908 (via GitHub)" <gi...@apache.org> on 2026/10/08 19:17:58 UTC
[PR] ix(frontend): clear the picked version when switching datasets in the dataset picker [texera]
tanishqgandhi1908 opened a new pull request, #8928:
URL: https://github.com/apache/texera/pull/8928
### What changes were proposed in this PR?
DatasetSelectionModalComponent.onDatasetChange cleared the file tree but kept the previously picked version and path. After switching datasets, the version box still showed the old version name, Select stayed enabled, and clicking it returned the previous dataset’s path.
It now clears selectedVersion and selectedPath when the dataset changes, as ModelSelectionModalComponent.onModelChange already does. In file mode this also drops the previous file when the new dataset has no versions or its versions are still loading.
Reopening the picker on a saved value now also re-selects that version in non-file mode; previously only file mode did, so File Lister showed an empty version box.
Before: after switching to weather-readings, “v1” is still shown and Select returns owner-access-demo’s path:
<img width="1440" height="900" alt="before-2-switched-to-b" src="https://github.com/user-attachments/assets/fb5d1fbc-6fd7-4385-93cd-555e861988f5" />
<img width="1440" height="900" alt="before-3-field-value" src="https://github.com/user-attachments/assets/d621cb88-9512-4975-9ba1-1cfd6f6239cc" />
After: the version box is emptied and Select is disabled until a version of the new dataset is picked, which then gives the right path:
<img width="1440" height="900" alt="after-1-switched-to-b" src="https://github.com/user-attachments/assets/4f696e69-be45-4eaa-9a02-dbf1c9894086" />
<img width="1440" height="900" alt="after-2-field-value" src="https://github.com/user-attachments/assets/aa95879d-c72f-4978-a9a5-5700642be4f8" />
Reopening the picker shows the saved dataset and version:
<img width="1440" height="900" alt="after-3-reopened" src="https://github.com/user-attachments/assets/26d07a7f-8c5f-4ba4-983e-70624574cb41" />
### Any related issues, documentation, discussions?
Closes #8927
### How was this PR tested?
Added three cases to dataset-selection-modal.component.spec.ts:
Switching datasets disables Select again (non-file mode).
Switching to a dataset with no versions drops the previous file (file mode).
Reopening on a saved value re-selects that version (non-file mode).
The first two fail without the fix.
cd frontend
yarn ng test --watch=false --include='**/dataset-selection-modal.component.spec.ts'
Tests 19 passed (19)
Also checked against a local stack with a File Lister operator, following the steps in #8927, and by reopening the picker afterwards.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): clear the picked version when switching datasets in the dataset picker [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8928:
URL: https://github.com/apache/texera/pull/8928#issuecomment-6067330047
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): clear the picked version when switching datasets in the dataset picker [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8928:
URL: https://github.com/apache/texera/pull/8928#issuecomment-6067505717
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8928?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 92.50%. Comparing base ([`be65bf8`](https://app.codecov.io/gh/apache/texera/commit/be65bf8564a32eea4196aa0190a04f73884bfe70?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3783ece`](https://app.codecov.io/gh/apache/texera/commit/3783ecef801c970c511f0712b40cdf31dc19d6c8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8928 +/- ##
============================================
- Coverage 92.60% 92.50% -0.10%
Complexity 5046 5046
============================================
Files 1252 1220 -32
Lines 53586 50722 -2864
Branches 6673 6162 -511
============================================
- Hits 49625 46922 -2703
+ Misses 2317 2219 -98
+ Partials 1644 1581 -63
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8928/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.38% <ø> (ø)` | | Carriedforward from [be65bf8](https://app.codecov.io/gh/apache/texera/commit/be65bf8564a32eea4196aa0190a04f73884bfe70?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <ø> (ø)` | | Carriedforward from [be65bf8](https://app.codecov.io/gh/apache/texera/commit/be65bf8564a32eea4196aa0190a04f73884bfe70?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.11% <ø> (ø)` | | Carriedforward from [be65bf8](https://app.codecov.io/gh/apache/texera/commit/be65bf8564a32eea4196aa0190a04f73884bfe70?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.48% <ø> (ø)` | | Carriedforward from [be65bf8](https://app.codecov.io/gh/apache/texera/commit/be65bf8564a32eea4196aa0190a04f73884bfe70?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.37% <ø> (ø)` | | Carriedforward from [be65bf8](https://app.codecov.io/gh/apache/texera/commit/be65bf8564a32eea4196aa0190a04f73884bfe70?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.53% <ø> (ø)` | | Carriedforward from [be65bf8](https://app.codecov.io/gh/apache/texera/commit/be65bf8564a32eea4196aa0190a04f73884bfe70?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.89% <100.00%> (+0.29%)` | :arrow_up: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [be65bf8](https://app.codecov.io/gh/apache/texera/commit/be65bf8564a32eea4196aa0190a04f73884bfe70?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.52% <ø> (ø)` | | Carriedforward from [be65bf8](https://app.codecov.io/gh/apache/texera/commit/be65bf8564a32eea4196aa0190a04f73884bfe70?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.09% <ø> (ø)` | | Carriedforward from [be65bf8](https://app.codecov.io/gh/apache/texera/commit/be65bf8564a32eea4196aa0190a04f73884bfe70?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8928?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): clear the picked version when switching datasets in the dataset picker [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 merged PR #8928:
URL: https://github.com/apache/texera/pull/8928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): clear the picked version when switching datasets in the dataset picker [texera]
Posted by "tanishqgandhi1908 (via GitHub)" <gi...@apache.org>.
tanishqgandhi1908 commented on PR #8928:
URL: https://github.com/apache/texera/pull/8928#issuecomment-6117941292
@xuang7 or @mengw15, Can you please review the PR when possible? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): clear the picked version when switching datasets in the dataset picker [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8928:
URL: https://github.com/apache/texera/pull/8928#issuecomment-6067344919
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. A `release/*` label nominates a backport target; the branch's release manager approving this PR is what sends the fix there. The required **Backport Approvals** check stays red until every label below is approved, so each manager either approves or removes their own label — which is why the labels left on a merged PR are exactly the branches it reached.
| Release branch | Analysis |
| --- | --- |
| ✅ `release/v1.3` | Change detected on this branch — label added; this fix is queued to backport here. @mengw15 decides: approving sends the fix here, removing this label declines it. The merge waits on one or the other. Review requested. |
| ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. @xuang7 decides: approving sends the fix here, removing this label declines it. The merge waits on one or the other. Review requested. |
_[Auto-label run](https://github.com/apache/texera/actions/runs/37830919474)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org