You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/09/17 20:12:45 UTC

[GitHub] [nifi] mr1716 opened a new pull request, #6429: NIFI-10520 Upgrade hazelcast to 4.2.5

mr1716 opened a new pull request, #6429:
URL: https://github.com/apache/nifi/pull/6429

   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-10520](https://issues.apache.org/jira/browse/NIFI-10520)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-10520) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [X] JDK 11
     - [X] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nifi] mattyb149 commented on pull request #6429: NIFI-10520 Upgrade hazelcast to 4.2.5

Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6429:
URL: https://github.com/apache/nifi/pull/6429#issuecomment-1253822388

   +1 LGTM, went through the release notes and noted no backwards incompatibilities. Please note that your commits in the future should start with the Jira case number and have a description about why you changed a file, not the file that was changed. I've updated this one before merging, just wanted to make you aware.
   
   Thanks for the upgrade! Merging to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nifi] mr1716 commented on pull request #6429: NIFI-10520 Upgrade hazelcast to 4.2.5

Posted by GitBox <gi...@apache.org>.
mr1716 commented on PR #6429:
URL: https://github.com/apache/nifi/pull/6429#issuecomment-1253846778

   @mattyb149 Thanks. Much appreciated. Will make note for future work. I did put the JIRA case number here and did add a reason for the change in the JIRA case, but will add that here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nifi] mr1716 commented on pull request #6429: NIFI-10520 Upgrade hazelcast to 4.2.5

Posted by GitBox <gi...@apache.org>.
mr1716 commented on PR #6429:
URL: https://github.com/apache/nifi/pull/6429#issuecomment-1250261451

   @exceptionfactory this is the pull request which was discussed. Wanted to let you know, so you're aware of it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nifi] mr1716 commented on pull request #6429: NIFI-10520 Upgrade hazelcast to 4.2.5

Posted by GitBox <gi...@apache.org>.
mr1716 commented on PR #6429:
URL: https://github.com/apache/nifi/pull/6429#issuecomment-1250154968

   This ran successfully when I ran it in my local branch. Might need to rerun the failed jobs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nifi] mattyb149 closed pull request #6429: NIFI-10520 Upgrade hazelcast to 4.2.5

Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #6429: NIFI-10520 Upgrade hazelcast to 4.2.5
URL: https://github.com/apache/nifi/pull/6429


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org