You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/12 04:53:41 UTC
[GitHub] [cloudstack] harikrishna-patnala opened a new pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
harikrishna-patnala opened a new pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991
## Description
Submitting multiple dynamic VM Scaling API commands for the same instance can result in two usage events in the same second causing a compound key violation in usage service
Root cause:
Even though dynamic scaling job is handled in vmworkjob queue which ensures serilizing multiple jobs but the database updating and generating usage events are out of the job queue.
Solution:
Moved all updations into the job queue
<!--- Describe your changes in detail -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ x] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Firstly I have tested all the scenarios to check if nothing is broken
1. Scaling on a running VM with normal compute offering
2. Scaling on a stopped VM with normal compute offering
3. Scaling on a running VM with custom compute offering
4. Scaling on stopped VM with custom compute offering
5. Scaling on stopped/running VM between custom compute offering and normal compute offering and combinations among these. Checked if the custom parameters have been populated or deleted accordingly based on the offering to which the VM is scaled
Since this is a corner scenario I could not test the exact point where two usage events are recorded at the same time for two different API calls on same VM.
In my testing found an NPE issue which is not related to my fix. I have fixed it and raised a separate PR https://github.com/apache/cloudstack/pull/3998.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-643064218
@harikrishna-patnala @borisstoyanov - is this ready for merge post-testing, if we do a final review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-643080537
@rhtyd, This was tested by @borisstoyanov. we can merge this after a final review if required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-644530219
> @harikrishna-patnala can you check/comment on the failing Travis tests?
The failed tests are not related to scale vm operations and the corresponding code flow @rhtyd.
I'll keep check the new travis ci results once generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-634747244
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-643064218
@harikrishna-patnala @borisstoyanov - is this ready for merge post-testing, if we a final review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-630053385
LGTM, I've managed to confirm the fix. I've started 2 api calls to scale a vm almost at the same time and it scheduled them one after. The usage records did not ended up with the same timestamp
```
cmk scale virtualmachine id=65d9020c-86ca-428c-95eb-c189f0df9425 serviceofferingid=7af64616-bc5f-482f-8110-1bb951067399 & cmk scale virtualmachine id=65d9020c-86ca-428c-95eb-c189f0df9425 serviceofferingid=d931b51c-b935-4c76-bfd4-8e799d20ce69
```
and in Logs we observe they are being scheduled one after another
```
[root@pr3991-t1534-vmware-67u3-mgmt1 ~]# cat /var/log/cloudstack/management/management-server.log | grep ScaleVmCommand
2020-05-18 08:45:38,396 DEBUG [c.c.a.t.Request] (Work-Job-Executor-129:ctx-7ed738e5 job-342/job-344 ctx-97363648) (logid:c2b833de) Seq 1-4627448617123185215: Sending { Cmd , MgmtId: 32989006334137, via: 1(10.2.3.134), Ver: v1, Flags: 100111, [{"com.cloud.agent.api.ScaleVmCommand":{"vm":{"id":1,"name":"i-2-50-VM","cpus":1,"minSpeed":250,"maxSpeed":500,"minRam":536870912,"maxRam":536870912,"enableHA":false,"limitCpuUse":false,"enableDynamicallyScaleVm":false,"params":{"vmware.reserve.mem":"false","vmware.reserve.cpu":"false"},"guestOsDetails":{},"extraConfig":{}},"vmName":"i-2-50-VM","cpus":1,"minSpeed":250,"maxSpeed":500,"minRam":536870912,"maxRam":536870912,"wait":0}}] }
2020-05-18 08:45:38,396 DEBUG [c.c.a.t.Request] (Work-Job-Executor-129:ctx-7ed738e5 job-342/job-344 ctx-97363648) (logid:c2b833de) Seq 1-4627448617123185215: Executing: { Cmd , MgmtId: 32989006334137, via: 1(10.2.3.134), Ver: v1, Flags: 100111, [{"com.cloud.agent.api.ScaleVmCommand":{"vm":{"id":1,"name":"i-2-50-VM","cpus":1,"minSpeed":250,"maxSpeed":500,"minRam":536870912,"maxRam":536870912,"enableHA":false,"limitCpuUse":false,"enableDynamicallyScaleVm":false,"params":{"vmware.reserve.mem":"false","vmware.reserve.cpu":"false"},"guestOsDetails":{},"extraConfig":{}},"vmName":"i-2-50-VM","cpus":1,"minSpeed":250,"maxSpeed":500,"minRam":536870912,"maxRam":536870912,"wait":0}}] }
2020-05-18 08:45:38,421 DEBUG [c.c.h.v.m.HostMO] (DirectAgent-162:ctx-7db81840 10.2.3.134, job-342/job-344, cmd: ScaleVmCommand) (logid:c2b833de) find VM i-2-50-VM on host
2020-05-18 08:45:38,421 INFO [c.c.h.v.m.HostMO] (DirectAgent-162:ctx-7db81840 10.2.3.134, job-342/job-344, cmd: ScaleVmCommand) (logid:c2b833de) VM i-2-50-VM not found in host cache
2020-05-18 08:45:38,422 DEBUG [c.c.h.v.m.HostMO] (DirectAgent-162:ctx-7db81840 10.2.3.134, job-342/job-344, cmd: ScaleVmCommand) (logid:c2b833de) load VM cache on host
2020-05-18 08:45:42,392 DEBUG [c.c.a.t.Request] (Work-Job-Executor-130:ctx-db54c10b job-343/job-346 ctx-16ea5097) (logid:e8cd41a0) Seq 1-4627448617123185217: Sending { Cmd , MgmtId: 32989006334137, via: 1(10.2.3.134), Ver: v1, Flags: 100111, [{"com.cloud.agent.api.ScaleVmCommand":{"vm":{"id":1,"name":"i-2-50-VM","cpus":1,"minSpeed":500,"maxSpeed":1000,"minRam":1073741824,"maxRam":1073741824,"enableHA":false,"limitCpuUse":false,"enableDynamicallyScaleVm":false,"params":{"vmware.reserve.mem":"false","vmware.reserve.cpu":"false"},"guestOsDetails":{},"extraConfig":{}},"vmName":"i-2-50-VM","cpus":1,"minSpeed":500,"maxSpeed":1000,"minRam":1073741824,"maxRam":1073741824,"wait":0}}] }
2020-05-18 08:45:42,392 DEBUG [c.c.a.t.Request] (Work-Job-Executor-130:ctx-db54c10b job-343/job-346 ctx-16ea5097) (logid:e8cd41a0) Seq 1-4627448617123185217: Executing: { Cmd , MgmtId: 32989006334137, via: 1(10.2.3.134), Ver: v1, Flags: 100111, [{"com.cloud.agent.api.ScaleVmCommand":{"vm":{"id":1,"name":"i-2-50-VM","cpus":1,"minSpeed":500,"maxSpeed":1000,"minRam":1073741824,"maxRam":1073741824,"enableHA":false,"limitCpuUse":false,"enableDynamicallyScaleVm":false,"params":{"vmware.reserve.mem":"false","vmware.reserve.cpu":"false"},"guestOsDetails":{},"extraConfig":{}},"vmName":"i-2-50-VM","cpus":1,"minSpeed":500,"maxSpeed":1000,"minRam":1073741824,"maxRam":1073741824,"wait":0}}] }
2020-05-18 08:45:42,403 DEBUG [c.c.h.v.m.HostMO] (DirectAgent-327:ctx-92d817a6 10.2.3.134, job-343/job-346, cmd: ScaleVmCommand) (logid:e8cd41a0) find VM i-2-50-VM on host
2020-05-18 08:45:42,403 INFO [c.c.h.v.m.HostMO] (DirectAgent-327:ctx-92d817a6 10.2.3.134, job-343/job-346, cmd: ScaleVmCommand) (logid:e8cd41a0) VM i-2-50-VM not found in host cache
2020-05-18 08:45:42,403 DEBUG [c.c.h.v.m.HostMO] (DirectAgent-327:ctx-92d817a6 10.2.3.134, job-343/job-346, cmd: ScaleVmCommand) (logid:e8cd41a0) load VM cache on host
```
and in usage records we observe they ended up with different timestamps.
```
MariaDB [cloud]> select type,created,offering_id from usage_event where type='VM.DYNAMIC.SCALE';
+------------------+---------------------+-------------+
| type | created | offering_id |
+------------------+---------------------+-------------+
| VM.DYNAMIC.SCALE | 2020-05-18 08:45:39 | 1 |
| VM.DYNAMIC.SCALE | 2020-05-18 08:45:43 | 2 |
+------------------+---------------------+-------------+
2 rows in set (0.01 sec)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-634661849
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-643532553
@harikrishna-patnala can you check/comment on the failing Travis tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-634747899
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-628553656
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-628842993
<b>Trillian test result (tid-1528)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29227 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3991-t1528-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 177.00 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 173.85 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 229.77 | test_privategw_acl.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 300.52 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-634675768
Packaging result: ✔centos7 ✔debian. JID-1250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-628542255
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-628541744
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala edited a comment on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala edited a comment on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-644530219
> @harikrishna-patnala can you check/comment on the failing Travis tests?
The failed tests are not related to scale vm operations and the corresponding code flow @rhtyd.
I'll check the new travis ci results once generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-634661031
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-628541665
@DaanHoogland are you happy with the code review?
@blueorangutan pakcage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-635077175
<b>Trillian test result (tid-1576)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40800 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3991-t1576-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 231.20 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 220.00 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 340.42 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-628551838
Packaging result: ✔centos7 ✔debian. JID-1224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-628553978
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-630053960
@DaanHoogland are you happy with latest changes wrt your requested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org