Re: [PR] kie-issues#208: Renaming any "NamedElement" on the DMN Editor should update all references to the old name [incubator-kie-tools]

["danielzhe (via GitHub)" <gi...@apache.org>]

danielzhe commented on code in PR #2760:
URL: https://github.com/apache/incubator-kie-tools/pull/2760#discussion_r1922845469


##########
packages/dmn-language-service/src/refactor/IdentifiersRefactor.ts:
##########


Review Comment:
   The problem is that outside, where the code is called, it would be only `Identifiers` and I think `IdentifiersRefactor` is a better name because only `Identifiers` can lead to think that there are more functions inside of it and not only functions related to Identifiers Refactor. Wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org